Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 10 27 spark for25 #377

Open
wants to merge 18 commits into
base: 25.0-release
Choose a base branch
from
Open

Commits on Jul 4, 2023

  1. [API] Using isAccessibleBy on candidate endpoint (aces#8824)

    Add accessibility check for candidate metadata, not just visits.
    xlecours authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f8f123d View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. [survey_accounts] notices, warnings and filter options (aces#8859)

    This was made to remove overrides on COPN and CBIGR
    
    - removes notices
    - removes deprecation warning
    - add filter options to filter with limited set of options
    ridz1208 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    14418af View commit details
    Browse the repository at this point in the history
  2. [LorisForm] add required to checkboxes (aces#8860)

    Checkbox elements can not be defined as required like the rest of the elements. This add support for required.
    
    A required checkbox must be checked for the form to be submitted. (ie. for questions like "Have you read the terms of service?")
    ridz1208 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    d69d61e View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. [Libraries] Feedback panel - fix fieldnames setting (aces#8848)

    In the feedback panel for an instrument, the only option in 'Field Name' was 'Across all fields'. This changes how the field names for an instrument are fetched so that all of them appear as an option too.
    charlottesce authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c6c05ae View commit details
    Browse the repository at this point in the history
  2. [tools][CouchDB_MRI_Importer] Fix date in MRI data (aces#8851)

    - Fix date imported into DQT to be a real date rather than a unix timestamp.
    - Fix incorrect order of parameters to `join` in import script
    charlottesce authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    6705373 View commit details
    Browse the repository at this point in the history
  3. [issue_tracker] Resolves special characters in titles (aces#8842)

    Do not escape data being inserted in the issue tracker, it gets escaped on rendering.
    charlottesce authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3baac58 View commit details
    Browse the repository at this point in the history
  4. [LINST/Dictionary] Add Numeric elements to dictionary (aces#8869)

    Currently the numeric element type is only being added to the
    instrument data dictionary if it's on the top page.
    
    This fixes it so that the elements are always added to the dictionary
    regardless of the page.
    driusan authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b381816 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. [bvl_feedback] Edit comment section (aces#8790)

    Fix display of bvl_feedback on mobile devices.
    
    - Switched Add Comment button from Pencil to a Comment (Original was confusing)
    - Set threads to be shown automatically for open threads as having them hidden made the UI confusing.
    - Added an Edit and Delete button for comments of which the author is the user viewing them
    - Flipped the order of comments around so that the newer comments show up below. Makes more sense when reading the comments
    - Made New Comment TextArea section show up below the thread, as that is where the new comment will appear
    - Changed panel width to work on mobile devices
    skarya22 authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b74e4ba View commit details
    Browse the repository at this point in the history
  2. [Core] Changed order of module directories (aces#8870)

    This change enables the use of project modules for requests that use AjaxHelper.
    
    The order in which the directories are defined, when the LorisInstance is instantiated, determines the order of locations where modules are searched for and registered.
    jeffersoncasimir authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    81a76fc View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. [imaging_uploader] Fix auto-populating VisitLabel (aces#8881)

    Properly handle parsing/auto-populating of visit label when there is a suffix after the visit label in the file name.
    
    Fixes aces#8803
    zaliqarosli authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    80740e4 View commit details
    Browse the repository at this point in the history
  2. [Dict] Skip hidden fields in data dictionary (aces#8882)

    Some instruments use hidden fields to pass data to the frontend. This skips over the fields in the dictionary building to prevent a 500 error.
    ridz1208 authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6d6d0d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Configuration menu
    Copy the full SHA
    48d4d0e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. [configuration] Escape values in config module (aces#8901)

    PR#8759 converted the escape module to use unsafeInsert/update
    to save data and prevent double escaping issues. The usages of
    the textarea were audited to make sure they were properly escaped,
    however the value is also displayed in the configuration module
    itself. Until the module is updated from smarty to react (PR#8471),
    they need to be escaped in the config module itself.
    
    This adds escaping to the config module smarty template.
    driusan authored Sep 28, 2023
    Configuration menu
    Copy the full SHA
    72bd0fd View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. [media] Fix problematic SQL (aces#8908)

    This fixes 2 problems with the SQL in the media FileUpload?action=getData
    endpoint
    1. There is an obvious SQL injection attack where user input from the
       request is directly concatenated into a string that's passed to the
       database.
    2. There was an unnecessary sub-select that could have been a join
    
    This whole section of the code is a mess that should to be re-written,
    but this PR just tackles the urgent string concatenation.
    driusan authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    9b08f46 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'aces/24.1-release' into Push2415To25

    Push 24.1.5 bugfixes into the 25.0.x release branch.
    driusan committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    e1de313 View commit details
    Browse the repository at this point in the history
  3. Merge pull request aces#8909 from driusan/Push2415To25

    Push v24.1.5 bug fixes into v25.0.x release branch
    driusan authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    56a636b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. [media] React Warning on Upload Tab (aces#8721)

    Modified Form.js to no longer use the "selected" attribute in option tags, and rather the "value" attribute of select tags.
    
    Resolves aces#8702
    skarya22 authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    91ceee1 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. spark

    kongtiaowang committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    ce90481 View commit details
    Browse the repository at this point in the history