Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 debug cm project filter #398

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Commits on Apr 16, 2024

  1. [notification] Fix sender name in email (aces#9203)

    Display the name of the user instead of their ID in the notification emails.
    
    Fixes aces#9202
    maximemulder authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e96d5a8 View commit details
    Browse the repository at this point in the history
  2. [publication] Fix number of files in Upload tab (aces#9179)

    In the uploadForm.js file is modified to increase / decrease the numFiles value according to whether a file was actually selected or not. If a file is selected, the numFiles increases. If a file is not selected, the numFiles decreases.
    
    This prevents the bug where "File to Upload" field is added indefinitely if the file is browsed and then cancelled.
    
    Fixes aces#9136
    CamilleBeau authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    92dbd76 View commit details
    Browse the repository at this point in the history
  3. [statistics] Recruitment graph optimization (aces#9196)

    The recruitment graphs on the dashboard provided by the
    statistics module are not efficient. They run one SQL query
    per month per year per site for each graph that is displayed.
    This is highly inefficient for large projects.
    
    This replaces the single queries in the inner loops with a
    single group-by query which it processes into the same format.
    
    The result should be significantly faster load times on the dashboard
    when the statistics module is loaded.
    driusan authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    65ad4b5 View commit details
    Browse the repository at this point in the history
  4. [Publication] Fix for auto-selecting Project in edit (aces#9187)

    The value expected by the field is the number id, but the fetch statement was returning the name - so I modified the sql statement to fetch the project ID.
    
    Fixes aces#9134
    skarya22 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    5b5170a View commit details
    Browse the repository at this point in the history
  5. [media] 413 error improperly handled (aces#9175)

    Display correct error message for files that are too large
    
    Resolves aces#9163
    kongtiaowang authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f96d9e4 View commit details
    Browse the repository at this point in the history
  6. [publication] Fix download prevention by overriding download notifica…

    …tion function (aces#9208)
    
    An error regarding the non-existence of a notification_module with module: publication and operation: download prevented the downloading of files.
    
    The notification function was overridden for this module to bypass the LorisException thrown by the non-existence of entries. It appeared by far to be a simpler solution than checking for and adding extra logic when the entries do not exist.
    
    Resolves  aces#9133.
    jeffersoncasimir authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f111b9c View commit details
    Browse the repository at this point in the history
  7. [Publication] Fix baseurl missing from emails (aces#9186)

    -The loris baseURL is now sent from the react pages to the ajax scripts on submit for both editing and uploading a new publication, and then is sent in the email.
    - I did it this way as \NDB_Factory::singleton()->settings()->getBaseURL() does not work in ajax files, and since it is deprecated it made more sense to do a hotfix rather than investigating the issue with ajax.
    - This was noticed and fixed for files in php folders in  PR#7807, however that same fix does not work for ajax. Thankfully publication is the only module with ajax still that uses getBaseUrl().
    
    Resolves aces#9132
    skarya22 authored Apr 16, 2024
    Configuration menu
    Copy the full SHA
    3d53b05 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Fix display of help text (aces#9210)

    Fix display of long help text or help text when scrolled past the start of the page.
    
    Resolves aces#9180
    laemtl authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    da70abd View commit details
    Browse the repository at this point in the history
  2. Make candidate_list use LORIS streamable binary format (aces#9195)

    This updates the candidate_list module to use format=binary
    format instead of format=json. For large projects with many
    candidates the encoding of the data to JSON can use up all
    the server's memory and then crash with an out-of-memory error.
    
    Since the format=binary format is a line-based streamable format,
    it does not require loading the entire result set into memory before
    transmitting it to the client and larger data sets can be loaded into
    LORIS.
    driusan authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    aca44a6 View commit details
    Browse the repository at this point in the history
  3. Add to configuration server_processes_manager module (aces#9189)

    Document required configurations for spm
    
    Fixes aces#9153
    GeorgeMurad authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fe303a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    07c9ca4 View commit details
    Browse the repository at this point in the history
  5. [dataquery] Use batch insert instead of prepared statement (aces#9205)

    Use a batch insert instead of a prepared statement loop to
    populate temporary table in new DQT for SQLQueryEngine.
    
    This makes the SQLQueryEngine use the same logic as
    modules/dataquery/php/query.class.inc, which is much more
    efficient for large data sets.
    driusan authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    9c590b5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ab5caa7 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. [Acknowledgements] Fix for selecting all roles (aces#9209)

    Fix insert statement when too many roles are added by converting the fields from varchar(255) to text.
    
    Fixes aces#9173
    skarya22 authored Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2167094 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. [dicom archive] Remove superfluous newline in dicom archive view deta…

    …ils (aces#9214)
    
    Remove unnecessary newline in dicom archive display.
    maximemulder authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e33fcd7 View commit details
    Browse the repository at this point in the history
  2. data_dictionary_builder.php unique constraint fix (aces#9201)

    Only re-build instrument data dictionaries, not all data dictionaries, to ensure all names are unique.
    laemtl authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    43f53e9 View commit details
    Browse the repository at this point in the history
  3. [behavioural_qc ] Auto-open behavioural panel with query parameter (a…

    …ces#9183)
    
    This adds the query parameter showFeedback=true to trigger auto-opening the feedback panel on-load.
    
    Fixes aces#8056.
    jeffersoncasimir authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8e21e88 View commit details
    Browse the repository at this point in the history
  4. [genomic_browser] Minor edits to the test plan (aces#9198)

    This modifies the test plan for the genomic browser module. The changes are mostly cosmetics but also include corrections of the permission names and table headers mentioned in the plan.
    
    Resolves aces#9151
    nicolasbrossard authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7eafeef View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. [examiner] Adds permission check when adding examiner to site. (aces#…

    …9188)
    
    Permissions are check now before allowing to add examiner to site.
    Before this, a user with only the permission Examiner: Add and Certify Examiners - Own Sites was able to add examiners to sites it don't belongs to. Now this feature is only granted to users with the corresponding level of permission.
    
    Fixes aces#9149
    racostas authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bff9931 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    1dcf6fc View commit details
    Browse the repository at this point in the history
  2. Add changelog

    CamilleBeau committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8417f4c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. debug

    kongtiaowang committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    62dc5a9 View commit details
    Browse the repository at this point in the history
  2. debug

    kongtiaowang committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3f335da View commit details
    Browse the repository at this point in the history
  3. phpcs

    kongtiaowang committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    a8229f4 View commit details
    Browse the repository at this point in the history