-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure): create azure cluster #428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/azure
branch
5 times, most recently
from
September 25, 2024 15:00
eebef6c
to
fbf0a88
Compare
mrsimonemms
force-pushed
the
sje/azure
branch
2 times, most recently
from
October 28, 2024 11:00
b3e8fda
to
dfef3dc
Compare
mrsimonemms
force-pushed
the
sje/azure
branch
from
October 28, 2024 15:29
dfef3dc
to
e214de5
Compare
mrsimonemms
force-pushed
the
sje/azure
branch
from
October 29, 2024 12:22
e214de5
to
674ba06
Compare
mrsimonemms
commented
Oct 29, 2024
mrsimonemms
force-pushed
the
sje/azure
branch
from
October 29, 2024 14:56
f70f605
to
01f99f9
Compare
mrsimonemms
commented
Oct 29, 2024
mrsimonemms
commented
Oct 29, 2024
mrsimonemms
force-pushed
the
sje/azure
branch
from
October 30, 2024 09:49
01f99f9
to
c5394b1
Compare
There's no realistic way of avoiding this error in Golang so it doesn't add much value
Necessary to keep the pattern of how the router works. This should be refactored so not required
mrsimonemms
force-pushed
the
sje/azure
branch
from
October 30, 2024 10:15
c5394b1
to
a46cd34
Compare
jokestax
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for Azure
Related Issue(s)
Fixes #458
How to test
This assumes you're running the console, API and CLI in local debug mode.
ARM_CLIENT_ID
,ARM_CLIENT_SECRET
,ARM_TENANT_ID
andARM_SUBSCRIPTION_ID
envvarsExample CLI commands:
Azure DNS
You will need to create a DNS Zone with your desired domain registered. I have the domains registered elsewhere and setup a subdomain in Azure (eg,
azure.domain.com
) and then setup an NS record on my domain registrar.Azure puts everything in resource groups, which is a logical grouping of multiple resources. You will need to provide the name of that in
--dns-azure-resource-group
.Cloudflare