Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding go-cli #67

Merged
merged 139 commits into from
Jul 19, 2022
Merged

adding go-cli #67

merged 139 commits into from
Jul 19, 2022

Conversation

converge
Copy link
Contributor

@converge converge commented Jun 29, 2022 •
edited by 6za
Loading

Adding kubefirst cli installer.

converge
converge commented Jun 29, 2022
View reviewed changes
README.md Show resolved Hide resolved
converge
converge commented Jun 29, 2022
View reviewed changes
Copy link
Contributor Author

@converge converge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to remove unnecessary/auto generated comments

6za added 2 commits June 29, 2022 15:34
@6za
adding go-cli
30da87c 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
sign commit
bd989f4 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
6za
6za reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@6za 6za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points reviewing PR:

go.mod Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
terraform/main.tf Outdated Show resolved Hide resolved
6za added 3 commits June 29, 2022 16:02
@6za
rename project
c8db3e4 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
adding init/create steps
ee55614 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
adding globals note
171bd5d 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@jarededwards
Copy link
Contributor

it would be nice to remove unnecessary/auto generated comments

I'm all for removing extra / auto generated code

6za added 3 commits June 30, 2022 13:02
@6za
removing the templates
9d7a5a7 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
update globals
de30a93 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
update security check
c0faaed 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2022
View reviewed changes
cmd/init.go Fixed Show fixed Hide fixed
6za added 12 commits June 30, 2022 13:30
@6za
rebranding cli
643070f 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
Add check tools and update outputs
6906657 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
simplify os.shell calls
ebf480b 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
minor notes tweaks
3a0d9bf 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
cleaning create steps
ef7b21c 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
address zip slip
a03550f 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
address zip slip
0eecf34 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
cleaning some steps
4756113 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
reshuffle create steps
410f0a3 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
Redirecting out to logs
438fa36 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
add create dry-run
97b5e70 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
Merge pull request #68 from kubefirst/go-cli-v0.0.2
a98418a 
Add check tools and update outputs
@converge converge marked this pull request as ready for review July 4, 2022 15:52
@converge converge self-assigned this Jul 4, 2022
@converge
Copy link
Contributor Author

converge commented Jul 4, 2022

all good for the initial move, we will keep cleaning up next PRs

@6za
add progress bars
d4d0076 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
João Paulo Vanzuita and others added 24 commits July 14, 2022 14:45
Merge pull request #104 from kubefirst/update_k1_folder
f1881f1 
refactor: update k1srt folder to k1
feat: add info styled screen
f5e963c 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
@6za
remove more noise
c9e3ee2 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
fixing conflict
9ab686d 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
fix vars
60b24f8 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
fix lint stuff
50e22b4 
Signed-off-by: 6za <53096417+6za@users.noreply.github.com>
@6za
Merge pull request #106 from kubefirst/go-cli-silence-cmds
2f5a24d 
remove more noise from output
Merge pull request #105 from kubefirst/add_handoff_screen_to_info
17920fb 
feat: add info styled screen
feat: add handoff for create command
7989ee4 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
feat: add non styled info command
74ad990 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
chore: clean up
0483782 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Merge pull request #109 from kubefirst/non-blocker-info
5b88920 
feat: add non styled info command
chore: clean up, and add tests
6397725 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
chore: enable docker colors, use 256 colors to avoid colors mismatch
30eff08 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
Merge pull request #107 from kubefirst/add_handoff_screen_for_create
2ccdf9d 
feat: add handoff for create command
chore: update info screen to be non blocking screen
f529818 
Signed-off-by: João Vanzuita <joao@kubeshop.io>
@johndietz
static kubeconfig naming convention (#112)
25a6a5a 
Signed-off-by: johndietz <john@kubefirst.com>
Merge pull request #111 from kubefirst/add_non_blocker_info_screen
7f70744 
chore: update info screen to be non blocking screen
@jarededwards
k-ray cluster create updates (#108)
5b18d82 
* merge conflicts

* upstream merge conflict resolution

* adopts new struct definition

* new wait functionality for vault

* remove unused vault code
@johndietz
fixes for vault unseal (#114)
8c196a1
@johndietz
Vault unseal (#117)
3c00bd1 
* fixes for vault unseal

* not my favorite commit

* remove not my stuff
@johndietz
Vault unseal (#118)
0206148 
* fixes for vault unseal

* not my favorite commit

* remove not my stuff

* add reports package back
@johndietz
Vault unseal (#119)
a7fae7c 
* fixes for vault unseal

* not my favorite commit

* remove not my stuff

* add reports package back

* viper check adjustments

* viper check adjustments
@johndietz @jarededwards @6za
Vault unseal (#120)
79d1281 
* fixes for vault unseal

* not my favorite commit

* remove not my stuff

* add reports package back

* viper check adjustments

* viper check adjustments

* vault local address

* changes, mostly formatting

* spaces

* adjustments through latest provisioning

* Vault unseal tweak 0718 (#121)

* allow the retry to work as expected
* re-enable dry-run create

Signed-off-by: 6za <53096417+6za@users.noreply.github.com>

* adjustments for gitlab takeover

* unused ref

* detokenization games

* add slash to .git/ on detokenize denylist

* adding registry sync after gitlab gitops registry

* terraform lock removal

* adding argocd app host check and recycling/resyncing

* addressinging orchestration issues from last run

* port-forward fix

Co-authored-by: jarededwards <jared@kubefirst.com>
Co-authored-by: Cesar Filho <53096417+6za@users.noreply.github.com>
jarededwards
jarededwards previously approved these changes Jul 19, 2022
View reviewed changes
@johndietz johndietz merged commit ebe5bfc into main Jul 19, 2022
@fharper fharper deleted the go-cli branch December 14, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6za 6za 6za left review comments

@jarededwards jarededwards jarededwards approved these changes

Assignees

@converge converge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@converge @jarededwards @6za @johndietz @pagottoo