Use PHP 7.3 compatible html dom parser #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply007
suggested changes
Aug 23, 2019
There was a problem hiding this comment.
Thank you @NoodlesNZ for the fix!
Would it be possible to add PHP 7.3 environment to travis.yml as a part of this pull request to run the tests in this environment on the CI pipeline?
Add PHP 7.2 and 7.3 to Travis config
|
Thanks @Simply007, I added PHP 7.2 and 7.3 to the Travis config just for completeness. |
Simply007
approved these changes
Sep 16, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #79
Checklist
How to test
Use
DeliveryClient::getItem()on a PHP 7.3 system. It should not throw tons of warnings.The sunra package for php-simple-html-dom-parser is not being actively maintained. This PR changes it to another package which is maintained. It still uses the same underlying code from Sourceforge, but a later version which has fixes for PHP 7.3.