Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removing of the destruct method #13

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Conversation

Simply007
Copy link

@Simply007 Simply007 commented Oct 9, 2019

Motivation

As a part of #10 - the workaround about the destruct was removed, because of changing the parser in the PHP SDK.
But the same issue appeared in the new parser as well.

Related to #11

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@Simply007 Simply007 merged commit 8419dd0 into master Oct 9, 2019
@Simply007 Simply007 deleted the Simply007-fix-destruct-loop branch October 9, 2019 07:47
@Simply007 Simply007 mentioned this pull request Oct 9, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant