Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/laravel 6 #12

Merged
merged 6 commits into from
Oct 9, 2019
Merged

Feature/laravel 6 #12

merged 6 commits into from
Oct 9, 2019

Conversation

nikspyratos
Copy link

Motivation

Implements #8 - Laravel upgrade to 6.0

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added (changes are minor and mostly to non-app logic files)
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Install the site on local, load the pages.

@Simply007 Simply007 self-requested a review October 9, 2019 07:54
Copy link

@Simply007 Simply007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @nikolaos-spyratos. Thanks!

@Simply007
Copy link

FYI: I was forced to place a workaround back: #13

How did you find this repository (or that specific issue)? Are you participating in Hacktoberfrest?

@nikspyratos
Copy link
Author

nikspyratos commented Oct 9, 2019 via email

@Simply007
Copy link

Great @nikolaos-spyratos - thanks for sharing and the pull request itself!

Feel free to pick another issue, or contact via Gitter and we could find something else.

Check out Global collaborators dicsussions for some lat news about Kentico Open source activity.

@Simply007 Simply007 merged commit 4e10163 into kontent-ai:master Oct 9, 2019
@Simply007 Simply007 added the hacktoberfest https://hacktoberfest.digitalocean.com label Oct 9, 2019
@nikspyratos nikspyratos deleted the feature/laravel-6 branch October 9, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants