fix(sidebar): 13451 - also define app name by app id and change icon in tab #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaIzr
commented
Dec 8, 2022
IlyaIzr
commented
Dec 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 10.31% 10.30% -0.01%
==========================================
Files 521 521
Lines 37778 37806 +28
Branches 1031 1031
==========================================
Hits 3895 3895
- Misses 33454 33482 +28
Partials 429 429
|
propakov
reviewed
Dec 8, 2022
propakov
reviewed
Dec 8, 2022
src/features/side_bar/components/AppNameAndIcon/AppNameAndIcon.tsx
Outdated
Show resolved
Hide resolved
propakov
reviewed
Dec 8, 2022
src/features/side_bar/components/AppNameAndIcon/AppNameAndIcon.tsx
Outdated
Show resolved
Hide resolved
propakov
reviewed
Dec 8, 2022
src/features/side_bar/components/AppNameAndIcon/AppNameAndIcon.tsx
Outdated
Show resolved
Hide resolved
propakov
approved these changes
Dec 9, 2022
Akiyamka
reviewed
Dec 12, 2022
Akiyamka
suggested changes
Dec 12, 2022
Akiyamka
reviewed
Dec 13, 2022
src/features/side_bar/components/AppNameAndIcon/AppNameAndIcon.tsx
Outdated
Show resolved
Hide resolved
Akiyamka
reviewed
Dec 13, 2022
Akiyamka
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App name and icon (also in tab) defined by app id
also small fix for toggle button styles (that was written off by rebases)
Am i putting effect of changing tab icon in the right place? Should component name be affected by that? What do you think?