Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core: Resizer): 13601 - increase length of analytical panel #290

Merged
merged 9 commits into from
Dec 14, 2022

Conversation

IlyaIzr
Copy link
Contributor

@IlyaIzr IlyaIzr commented Dec 9, 2022

Analytical panel open fully by smart column as was requested
(value of desired height was added to describe it)
image
I've changed logic of class Resizer - previously if panels were to high they were shrinking evenly until they couldn't and then panels were closing in case space was still needed. As a result - we had shrinked and closed panels with free screen space
image
to lessen the damage and improve logic overall now we check if shrinking panels can help at all - if yes - we're shrinking. If no - we're closing and calculating again

@IlyaIzr IlyaIzr requested a review from Akiyamka December 9, 2022 12:28
@IlyaIzr IlyaIzr self-assigned this Dec 9, 2022
@Akiyamka
Copy link
Contributor

Akiyamka commented Dec 12, 2022

Short view looks broken, maby not related to this task
image
After switching to short state panel keep size - should we recalculate pannel size after short/long change, or maybe make short view non-resizable?

@IlyaIzr
Copy link
Contributor Author

IlyaIzr commented Dec 12, 2022

Short view looks broken

Yeah, fixed elsewhere

@Akiyamka
Copy link
Contributor

image
App logo looks broken in mobile view (on prod it's ok)

@IlyaIzr
Copy link
Contributor Author

IlyaIzr commented Dec 12, 2022

App logo looks broken in mobile view (on prod it's ok)

Happened because backend on dev now gives relative path, and on FE it's properly accepted only here #285

@Akiyamka
Copy link
Contributor

image
Look like some miss calculations - in firefox and chrome i have a few pixels scroll that disappear after close-open action

@IlyaIzr
Copy link
Contributor Author

IlyaIzr commented Dec 12, 2022

Look like some miss calculations - in firefox and chrome i have a few pixels scroll that disappear after close-open action

Interesting, i can tweak number for aesthetics!
In any case the task is to make sure all analytical fields can be seen in open panel without need for resizing

@Akiyamka
Copy link
Contributor

Akiyamka commented Dec 12, 2022

Interesting, i can tweak number for aesthetics!

Sound like it some hardcode 😅

@IlyaIzr
Copy link
Contributor Author

IlyaIzr commented Dec 12, 2022

Sound like it some hardcode 😅

Yes, it is! Since we have minimum height requirements in pixels i think it's okay

Copy link
Contributor

@Akiyamka Akiyamka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. DESIRED_HEIGHT must be calculated from content
  2. debug_caller - remove it or add logick that use it. In second case - looks like it's "pannelDebugName" o just "id"
  3. use reduce or forEach, instead of use reduce as forEach

@IlyaIzr IlyaIzr requested a review from Akiyamka December 12, 2022 19:06
Copy link
Contributor

@Akiyamka Akiyamka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes analytics panel have wrong height

@IlyaIzr IlyaIzr merged commit 0076b65 into main Dec 14, 2022
@IlyaIzr IlyaIzr deleted the 13601-length-of-analytics-panel-was-reduced branch December 14, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants