-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core: Resizer): 13601 - increase length of analytical panel #290
Conversation
Yeah, fixed elsewhere |
Happened because backend on dev now gives relative path, and on FE it's properly accepted only here #285 |
Interesting, i can tweak number for aesthetics! |
Sound like it some hardcode 😅 |
Yes, it is! Since we have minimum height requirements in pixels i think it's okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DESIRED_HEIGHT must be calculated from content
- debug_caller - remove it or add logick that use it. In second case - looks like it's "pannelDebugName" o just "id"
- use reduce or forEach, instead of use reduce as forEach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes analytics panel have wrong height
Analytical panel open fully by smart column as was requested
(value of desired height was added to describe it)
I've changed logic of
class Resizer
- previously if panels were to high they were shrinking evenly until they couldn't and then panels were closing in case space was still needed. As a result - we had shrinked and closed panels with free screen spaceto lessen the damage and improve logic overall now we check if shrinking panels can help at all - if yes - we're shrinking. If no - we're closing and calculating again