Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add WASM transformer #1119

Closed
wants to merge 2 commits into from
Closed

feat: add WASM transformer #1119

wants to merge 2 commits into from

Conversation

Soumil-07
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Dec 12, 2023
@Soumil-07 Soumil-07 mentioned this pull request Dec 12, 2023
Merged
HarikrishnanBalagopal
HarikrishnanBalagopal requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine. Just some minor changes.

Makefile Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
transformer/external/wasmtransformer.go Outdated Show resolved Hide resolved
transformer/external/wasmtransformer.go Outdated Show resolved Hide resolved
transformer/external/wasmtransformer.go Outdated Show resolved Hide resolved
@HarikrishnanBalagopal
Copy link
Contributor

Possibly we can move to https://github.com/tetratelabs/wazero which is pure Go with no dependency.

@Soumil-07
feat: add handler for wasm transformer
1a3e656 
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>

Based on work by Vamsi Krishna <vamsikrishnasatyasi971@gmail.com>
@HarikrishnanBalagopal HarikrishnanBalagopal added the lfx-project https://lfx.linuxfoundation.org/tools/mentorship/ label Dec 13, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal mentioned this pull request Jan 4, 2024
Closed
@HarikrishnanBalagopal HarikrishnanBalagopal linked an issue Jan 4, 2024 that may be closed by this pull request
feat: wasm transformers #1061
Open
@HarikrishnanBalagopal
Copy link
Contributor

HarikrishnanBalagopal commented Jan 30, 2024 •
edited
Loading

With WASI preview 2 being officially released https://github.com/WebAssembly/WASI/tree/main/preview2 it brings the WASM component model.

Possibly we can move to the WASM component model for marshalling and unmarshalling https://component-model.bytecodealliance.org/design/why-component-model.html

Only implemented in Wasmtime (and JCO) I think
https://github.com/WebAssembly/WASI/tree/main/preview2#wasi-preview-2-implementations
https://component-model.bytecodealliance.org/runtimes/wasmtime.html
https://github.com/BytecodeAlliance/jco

@HarikrishnanBalagopal
Copy link
Contributor

Related #1144

@HarikrishnanBalagopal
Copy link
Contributor

Implemented in #1172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarikrishnanBalagopal HarikrishnanBalagopal HarikrishnanBalagopal requested changes

Assignees
No one assigned
Labels
feat lfx-project https://lfx.linuxfoundation.org/tools/mentorship/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: wasm transformers
2 participants
@Soumil-07 @HarikrishnanBalagopal