Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support WASM external transformers using Wazero runtime #1172

Merged
merged 4 commits into from
Apr 19, 2024
Merged

feat: Support WASM external transformers using Wazero runtime #1172

merged 4 commits into from
Apr 19, 2024

Conversation

shashank381
Copy link
Contributor

No description provided.

@Soumil-07 @shashank381
feat: add handler for wasm transformer
87c48aa 
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>

Based on work by Vamsi Krishna <vamsikrishnasatyasi971@gmail.com>

Signed-off-by: shashank381 <satholashashank@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Apr 4, 2024
@shashank381
feat: Support WASM external transformers using Wazero
ed34266 
Signed-off-by: shashank381 <satholashashank@gmail.com>
@shashank381 shashank381 force-pushed the wasmtransformer-wazero branch from 81b2bbf to ed34266 Compare April 9, 2024 18:30
@kmehant kmehant force-pushed the wasmtransformer-wazero branch 2 times, most recently from 0ee95f1 to 47b3f6e Compare April 10, 2024 07:01
@kmehant
Copy link
Member

kmehant commented Apr 10, 2024

@shashank381 Thank you, one of us would review it.

HarikrishnanBalagopal
HarikrishnanBalagopal requested changes Apr 10, 2024
View reviewed changes
transformer/external/wasmtransformer.go

envVars := t.prepareEnv()
for _, envVar := range envVars {
keyValue := strings.SplitN(envVar, wasmEnvDelimiter, 2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we joining the key and value with = delimiter and then splitting again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix the DCO check by signing

@shashank381 shashank381 force-pushed the wasmtransformer-wazero branch from 47b3f6e to 9dea47b Compare April 12, 2024 04:57
@kmehant
Copy link
Member

kmehant commented Apr 12, 2024 •
edited
Loading 

INFO[0001] Planning started on its sub directories      
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/django/pom.xml: file does not exist

wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/django/simplewebapp/pom.xml: file does not exist

wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/django/webroot/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/django/webroot/migrations/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/golang/pom.xml: file does not exist

wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/gradle/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/gradle/wrapper/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/main/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/main/java/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/main/java/com/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/main/java/com/myuser/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/main/webapp/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-gradle/src/main/webapp/WEB-INF/pom.xml: file does not exist
INFO[0004] Identified 1 named services and 0 to-be-named services in java-maven 
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/java-war/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/nodejs/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/php/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/python/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/ruby/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/ruby/views/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/rust/pom.xml: file does not exist
wasm stat failed: stat /Users/haribala/temp/temp-m2k-cli-wasm/t1/language-platforms/rust/src/pom.xml: file does not exist
INFO[0005] Planning finished on its sub directories
  1. Can you investigate from where these logs coming from
  2. See if you can silent them for info mode and show them in debug mode.
    @shashank381

@shashank381
fix: add compiler execution mode as a bool value
8929169 
Signed-off-by: shashank381 <satholashashank@gmail.com>
@shashank381 shashank381 force-pushed the wasmtransformer-wazero branch from 9dea47b to 8929169 Compare April 12, 2024 05:23
HarikrishnanBalagopal
HarikrishnanBalagopal approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit a721b93 into konveyor:main Apr 19, 2024
3 checks passed
@HarikrishnanBalagopal HarikrishnanBalagopal mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarikrishnanBalagopal HarikrishnanBalagopal HarikrishnanBalagopal approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shashank381 @kmehant @HarikrishnanBalagopal @Soumil-07