-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ import global ci workflow #418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we could also change the test-e2e job to this, since the global-ci will install minikube/tackle as part of its run:
|
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
aufi
added a commit
to aufi/tackle2-hub
that referenced
this pull request
Jun 23, 2023
Integration E2E tests using API are now in https://github.com/konveyor/go-konveyor-tests those are executed using global CI workflows. Related to: - konveyor#310 - konveyor#418 Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fabianvf Can you add a brief description about what this will do? |
aufi
added a commit
that referenced
this pull request
Jun 30, 2023
Integration E2E tests using API are now in https://github.com/konveyor/go-konveyor-tests those are executed using global CI workflows. Related to: - #310 - #418 Signed-off-by: Marek Aufart <maufart@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will import the global CI workflow, which runs the end to end tests defined in https://github.com/konveyor/go-konveyor-tests (for now, it will be expanded to more suites as they become quick and stable enough). This helps to ensure that individual components aren't breaking the project as a whole, which should help to smooth out the release process.