Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH DEBT] Remove use of APIClient #1821

Closed
sjd78 opened this issue Apr 5, 2024 · 1 comment · Fixed by #1822
Closed

[TECH DEBT] Remove use of APIClient #1821

sjd78 opened this issue Apr 5, 2024 · 1 comment · Fixed by #1822
Assignees
@sjd78
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. tech-debt Technical debt triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.4.0

Comments

@sjd78
Copy link
Member

sjd78 commented Apr 5, 2024

Only a few things in the UI still use the legacy APIClient class.

Those uses should be transitions to using standard axios the same way as everything else.
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 5, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 5, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. tech-debt Technical debt and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Apr 5, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label Apr 5, 2024
@sjd78 sjd78 self-assigned this Apr 5, 2024
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 5, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
da4deea 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 mentioned this issue Apr 5, 2024
Merged
@sjd78 sjd78 added this to the v0.4.0 milestone Apr 5, 2024
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 5, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
9d2e08b 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 9, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
af2291f 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
@sjd78 sjd78 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. labels Apr 11, 2024
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 12, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
b83ebdf 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 16, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
58b1d3e 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Apr 19, 2024
@sjd78
🌱 Remove APIClient, update affected rest functions
f6c3bad 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use
    axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub
    handler function responses

Resolves: konveyor#1821
Part-of: konveyor#1411

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78 added a commit that referenced this issue Apr 19, 2024
@sjd78
🌱 Remove APIClient, update effected rest functions (#1822)
8b13af6 
Changes:
  - Remove `APIClient`
  - Update the affected functions in `rest.ts` to use axios directly
  - Double check the return types of the effected functions
  - Updated a few API model types based on current hub handler function
    responses
  - `getApplicationSummaryCSV()` URL query param was incorrectly named and
    could lead to more results returned than expected. Query param updated
    to the correct name as per the OpenAPI definition / golang handler code.

Resolves: #1821
Part-of: #1411

---------

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. tech-debt Technical debt triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

🌱 Remove APIClient, update effected rest functions sjd78/tackle2-ui
1 participant
@sjd78