🌱 Remove APIClient, update effected rest functions
#1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rszwajko
reviewed
Apr 10, 2024
ibolton336
approved these changes
Apr 12, 2024
sjd78
force-pushed
the
remove-apiClient
branch
2 times, most recently
from
b83ebdf
to
58b1d3e
Compare
rszwajko
approved these changes
Apr 18, 2024
Changes:
- Remove `APIClient`
- Update the affected functions in `rest.ts` to use
axios directly
- Double check the return types of the effected functions
- Updated a few API model types based on current hub
handler function responses
Resolves: konveyor#1821
Part-of: konveyor#1411
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
It |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
APIClientrest.tsto use axios directlygetApplicationSummaryCSV()URL query param was incorrectly named and could lead to more results returned than expected. Query param updated to the correct name as per the OpenAPI definition / golang handler code.Resolves: #1821
Part-of: #1411