Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Cannot manually enter some values on the application review page #1844

Closed
1 task done
sjd78 opened this issue Apr 12, 2024 · 1 comment · Fixed by #1839
Closed
1 task done

[BUG] Cannot manually enter some values on the application review page #1844

sjd78 opened this issue Apr 12, 2024 · 1 comment · Fixed by #1839
Assignees
@sjd78
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.3.2

Comments

@sjd78
Copy link
Member

sjd78 commented Apr 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3

Priority

Major

Current Behavior

The "Business criticality" and "Work priority" fields on the Application Review page do not allow typing of an input. The plus and minus buttons work. Typing an input does not.

Expected Behavior

For those 2 fields, the minus button, plus button and the input fields should all work as expected. You should be able to directly enter a value.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Review an application
  2. Click / focus in to the business criticality input field
  3. Try to delete the value or enter a new value
  4. file

Environment

All

Anything else?

No response
@sjd78 sjd78 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 12, 2024
@sjd78 sjd78 added this to Planning Apr 12, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Apr 12, 2024
@sjd78 sjd78 self-assigned this Apr 12, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Apr 12, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 12, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Apr 12, 2024
@sjd78 sjd78 mentioned this issue Apr 12, 2024
Merged
@sjd78 sjd78 moved this from 🆕 New to 🏗 In progress in Planning Apr 12, 2024
@sjd78 sjd78 added priority/normal Higher priority than priority/minor. Nice to have. and removed needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 12, 2024
@sjd78 sjd78 added this to the v0.3.2 milestone Apr 12, 2024
sjd78 added a commit that referenced this issue Apr 15, 2024
@sjd78 @ibolton336
🐛 Review form, fix onChange handlers (#1839)
276bedd 
On the review form, fix the `onChange` handler for the following
`NumberInput` fields:
  - criticality
  - priority

Note: This fix is a follow up to the fix in #1831. A grep across the
codebase showed 2 more or the same problems.

Resolves: #1844

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Apr 15, 2024
github-actions bot pushed a commit that referenced this issue Apr 15, 2024
@sjd78 @ibolton336 @web-flow
🐛 Review form, fix onChange handlers (#1839)
3143726 
On the review form, fix the `onChange` handler for the following
`NumberInput` fields:
  - criticality
  - priority

Note: This fix is a follow up to the fix in #1831. A grep across the
codebase showed 2 more or the same problems.

Resolves: #1844

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
@konveyor-ci-bot konveyor-ci-bot bot mentioned this issue Apr 15, 2024
Merged
sjd78 pushed a commit that referenced this issue Apr 15, 2024
@konveyor-ci-bot @ibolton336
🐛 Review form, fix onChange handlers (#1839) (#1848)
c3267ab 
On the review form, fix the `onChange` handler for the following
`NumberInput` fields:
  - criticality
  - priority

Note: This fix is a follow up to the fix in #1831. A grep across the
codebase showed 2 more of the same problems.

Resolves: #1844
Backport-of: #1839

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Co-authored-by: Ian Bolton <ibolton@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.2
Development

Successfully merging a pull request may close this issue.

🐛 Review form, fix onChange handlers sjd78/tackle2-ui
1 participant
@sjd78