🐛 Review form, fix onChange handlers
#1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in konveyor#1831. A grep across the codebase showed 2 more or the same problems. Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
fix-review-form-onChange
branch
from
c5929ea
to
1826000
Compare
ibolton336
approved these changes
Apr 12, 2024
sjd78
added
the
cherry-pick/release-0.3
rszwajko
approved these changes
Apr 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in #1831. A grep across the codebase showed 2 more or the same problems. Resolves: #1844 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
sjd78
pushed a commit
that referenced
this pull request
Apr 15, 2024
On the review form, fix the `onChange` handler for the following `NumberInput` fields: - criticality - priority Note: This fix is a follow up to the fix in #1831. A grep across the codebase showed 2 more of the same problems. Resolves: #1844 Backport-of: #1839 Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Co-authored-by: Ian Bolton <ibolton@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the review form, fix the
onChangehandler for the followingNumberInputfields:Note: This fix is a follow up to the fix in #1831. A grep across the codebase showed 2 more or the same problems.
Resolves: #1844