✨ Update Applications Analyze table to pf5 #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1353 +/- ##
=======================================
Coverage 42.41% 42.41%
=======================================
Files 138 138
Lines 4315 4315
Branches 1017 1017
=======================================
Hits 1830 1830
Misses 2473 2473
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gildub
suggested changes
Sep 13, 2023
Signed-off-by: gitdallas <dallas.nicol@gmail.com>
|
@gildub - fixed |
gildub
approved these changes
Sep 14, 2023
gildub
added a commit
that referenced
this pull request
Sep 15, 2023
#1353 follow-up to fix broken display of analysis status. `ApplicationAnalysisStatus` must be used to display analysis state. `IconedStatus` cannot be used here (or at least not yet) because analysis state mapping for tasks is specific.
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried keeping things as similar as possible to assessment table (order/formatting/etc) for easier refactoring to shared components later.