🐛 ApplicationAnalysisStatus is required for status #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
=======================================
Coverage 41.50% 41.50%
=======================================
Files 137 137
Lines 4281 4281
Branches 1027 1027
=======================================
Hits 1777 1777
Misses 2417 2417
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gitdallas
reviewed
Sep 14, 2023
| <IconedStatus | ||
| preset={application.review ? "Completed" : "NotStarted"} | ||
| <ApplicationAnalysisStatus | ||
| state={getTaskState(application)} |
There was a problem hiding this comment.
could do this and remove the getTaskState
Suggested change
| state={getTaskState(application)} | |
| state={ getTask(application)?.state || "No task" } |
There was a problem hiding this comment.
@gitdallas, much slicker !!!
gitdallas
reviewed
Sep 14, 2023
Comment on lines
457
to
462
| const getTaskState = (application: Application) => { | ||
| const task = getTask(application); | ||
| if (task && task.state) return task.state; | ||
| return "No task"; | ||
| }; | ||
|
|
There was a problem hiding this comment.
should be able to remove this now
Suggested change
| const getTaskState = (application: Application) => { | |
| const task = getTask(application); | |
| if (task && task.state) return task.state; | |
| return "No task"; | |
| }; |
There was a problem hiding this comment.
@gitdallas , I forgot to save the file ! Thanks
gitdallas
approved these changes
Sep 14, 2023
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
Signed-off-by: Gilles Dubreuil <gdubreui@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1353 follow-up to fix broken display of analysis status.
ApplicationAnalysisStatusmust be used to display analysis state.IconedStatuscannot be used here (or at least not yet) because analysis state mapping for tasks is specific.