🐛 Add lists of associated apps & archetypes #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibolton336 <ibolton@redhat.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
=======================================
Coverage 40.84% 40.84%
=======================================
Files 139 139
Lines 4456 4456
Branches 1018 1018
=======================================
Hits 1820 1820
Misses 2624 2624
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
reviewed
Oct 12, 2023
| @@ -52,7 +45,7 @@ const ArchetypeDetailDrawer: React.FC<IArchetypeDetailDrawerProps> = ({ | |||
| archetype?.tags?.filter((t) => t?.source === "assessment") ?? []; | |||
| return dedupeArrayOfObjects<TagRef>(rawAssessmentTags, "name"); | |||
| }, [archetype?.tags]); | |||
|
|
|||
| console.log("archetype", archetype); | |||
| const ApplicationLabels: React.FC<{ applicationRefs?: Ref[] }> = ({ | ||
| applicationRefs, | ||
| }) => | ||
| (applicationRefs?.length ?? 0) === 0 ? null : ( |
There was a problem hiding this comment.
With the length wrapper already in the description list, applicationRefs should be required and this step can be skipped.
| const ArchetypeLabels: React.FC<{ archetypeRefs?: Ref[] }> = ({ | ||
| archetypeRefs, | ||
| }) => | ||
| (archetypeRefs?.length ?? 0) === 0 ? null : ( |
There was a problem hiding this comment.
With the length wrapper already in the description list, archetypeRefs should be required and this step can be skipped.
...or push the "None" text into this component
|
Looks like this PR also covers: #1464 |
sjd78
pushed a commit
that referenced
this pull request
Oct 31, 2023
Follow up to: #1470 - Added a reusable component for drawer labels. - Adds random colors to the tags just for differentiation between the tags when viewing in the drawer. --------- Signed-off-by: Ian Bolton <ibolton@redhat.com>
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTA-1384?filter=12422675