👻 Adds colors to drawer tags & removes boilerplate #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
force-pushed
the
cleanup-associated-apps-archetypes
branch
from
24f218a
to
e0c71ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
=======================================
Coverage 40.16% 40.16%
=======================================
Files 144 144
Lines 4551 4551
Branches 1096 1096
=======================================
Hits 1828 1828
Misses 2626 2626
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sjd78
requested changes
Oct 19, 2023
Comment on lines
11
to
18
| const getRandomColor = () => { | ||
| const letters = "0123456789ABCDEF"; | ||
| let color = "#"; | ||
| for (let i = 0; i < 6; i++) { | ||
| color += letters[Math.floor(Math.random() * 16)]; | ||
| } | ||
| return color; | ||
| }; |
There was a problem hiding this comment.
There is an alternative that looks like it can generate some better colors (like keeping super dark and super light colors out): https://gist.github.com/bendc/76c48ce53299e6078a76
...s/applications/components/application-detail-drawer/application-detail-drawer-assessment.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/labels-from-items/labels-from-items.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/labels-from-items/labels-from-items.tsx
Outdated
Show resolved
Hide resolved
ibolton336
force-pushed
the
cleanup-associated-apps-archetypes
branch
from
e0c71ec
to
69cca76
Compare
Signed-off-by: ibolton336 <ibolton@redhat.com>
ibolton336
force-pushed
the
cleanup-associated-apps-archetypes
branch
from
69cca76
to
dcf3056
Compare
sjd78
reviewed
Oct 30, 2023
| }): JSX.Element { | ||
| const { t } = useTranslation(); | ||
|
|
||
| if (items?.length === 0) { |
There was a problem hiding this comment.
If items is undefined, this will reduce to undefined === 0 which is false.
Try if (items?.length ?? 0 === 0) { to force a 0 if items is undefined.
client/src/app/pages/archetypes/components/archetype-detail-drawer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Ian Bolton <ibolton@redhat.com>
sjd78
approved these changes
Oct 31, 2023
Signed-off-by: Ian Bolton <ibolton@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #1470