Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single user changes #166

Merged
merged 10 commits into from
May 6, 2022
Merged

Single user changes #166

merged 10 commits into from
May 6, 2022

Conversation

ibolton336
Copy link
Member

@ibolton336 ibolton336 commented May 6, 2022

  • Update env var names
  • Conditionally render the keycloak provider wrapper based on an env var.
  • Updated the PR to follow the forklift env var approach for supporting encrypted env vars in production loaded at runtime & loading development mode env vars at build time.
    Pending operator changes: Allow single user mode #63

Depends upon konveyor/operator#43

  • Adds cookie handling for unauthenticated direct hub api requests. Fixes 401 errors for reports when auth turned on

@ibolton336 ibolton336 changed the title Env var auth Single user changes May 6, 2022
# This is the 1st commit message:

update env var names

# This is the commit message #2:

add conditional for auth check message

# This is the commit message #3:

update error message

# This is the commit message #4:

Restore env var checks and pull from env var in keycloak config

# This is the commit message konveyor#5:

define and load env vars for consumption

# This is the commit message konveyor#6:

Finish adding auth required check
# This is the 1st commit message:

add conditional for auth check message

update error message

Restore env var checks and pull from env var in keycloak config

define and load env vars for consumption

Finish adding auth required check

fix rbac component

# This is the commit message #2:

fix rbac component

# This is the commit message #3:

fix rbac component

# This is the commit message #4:

remove

# This is the commit message konveyor#5:

.env file instructions

# This is the commit message konveyor#6:

fix tests

# This is the commit message konveyor#7:

looking into express api served env vars

# This is the commit message konveyor#8:

Implement encrypted env var window object for prod

# This is the commit message konveyor#9:

Env var window object implementation

# This is the commit message konveyor#10:

Fix app crashing
Implement encrypted env var window object for prod

Use cookies for unauthenticated routes against the hub
@gildub
Copy link
Contributor

gildub commented May 6, 2022

@ibolton336, In the description don't you mean this PR depends upon konveyor/operator#45 instead ?

@ibolton336
Copy link
Member Author

ibolton336 commented May 6, 2022

@ibolton336, In the description don't you mean this PR depends upon konveyor/tackle2-operator#45 instead ?

Yeah - Although I think we decided to go ahead and merge the UI PR since it won't really break anything without the env var in place.

@ibolton336
Copy link
Member Author

@ibolton336, In the description don't you mean this PR depends upon konveyor/tackle2-operator#45 instead ?

Yeah - Although I think we decided to go ahead and merge the UI PR since it won't really break anything without the env var in place.

@gildub

pkg/client/public/locales/en/translation.json Outdated Show resolved Hide resolved
pkg/client/public/locales/en/translation.json Outdated Show resolved Hide resolved
pkg/client/public/locales/en/translation.json Outdated Show resolved Hide resolved
pkg/client/public/locales/es/translation.json Outdated Show resolved Hide resolved
pkg/client/public/locales/es/translation.json Outdated Show resolved Hide resolved
pkg/client/src/index.tsx Outdated Show resolved Hide resolved
pkg/client/tsconfig.json Outdated Show resolved Hide resolved
pkg/client/config/webpack.common.js Outdated Show resolved Hide resolved
pkg/client/src/app/common/KeycloakProvider.tsx Outdated Show resolved Hide resolved
pkg/server/setupProxy.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's jump in the water....

@ibolton336 ibolton336 merged commit 25303e3 into konveyor:main May 6, 2022
@ibolton336 ibolton336 deleted the env-var-auth branch May 6, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants