Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm workspaces #8

Merged
merged 5 commits into from
Feb 24, 2022
Merged

Use npm workspaces #8

merged 5 commits into from
Feb 24, 2022

Conversation

gildub
Copy link
Contributor

@gildub gildub commented Feb 23, 2022

Leverage the monospace structure with npm workspaces

  • pkg/server: Consolidate index and proxy in one file - Because it's really short
  • pkg/client: Npm rule start:dev:local is now start:dev and can be executed from top level
  • pkg/qa-tests: Adjusted cypress so it can run properly
  • consolidate npm packages at top level (/package.json)
  • npm dist rule: allow to test locally full production distribution

@gildub gildub merged commit dc8aa76 into konveyor:main Feb 24, 2022
@gildub gildub deleted the workspaces branch February 24, 2022 14:32
ibolton336 added a commit that referenced this pull request Feb 24, 2022
This reverts commit dc8aa76, reversing
changes made to 9d322e4.
gildub added a commit that referenced this pull request Feb 24, 2022
Revert "Merge pull request #8 from gildub/workspaces"
ibolton336 added a commit to ibolton336/tackle2-ui that referenced this pull request May 6, 2022
# This is the 1st commit message:

add conditional for auth check message

update error message

Restore env var checks and pull from env var in keycloak config

define and load env vars for consumption

Finish adding auth required check

fix rbac component

# This is the commit message #2:

fix rbac component

# This is the commit message #3:

fix rbac component

# This is the commit message #4:

remove

# This is the commit message konveyor#5:

.env file instructions

# This is the commit message konveyor#6:

fix tests

# This is the commit message konveyor#7:

looking into express api served env vars

# This is the commit message konveyor#8:

Implement encrypted env var window object for prod

# This is the commit message konveyor#9:

Env var window object implementation

# This is the commit message konveyor#10:

Fix app crashing
ibolton336 added a commit that referenced this pull request May 6, 2022
* Change env var names to match hub

* # This is a combination of 6 commits.
# This is the 1st commit message:

update env var names

# This is the commit message #2:

add conditional for auth check message

# This is the commit message #3:

update error message

# This is the commit message #4:

Restore env var checks and pull from env var in keycloak config

# This is the commit message #5:

define and load env vars for consumption

# This is the commit message #6:

Finish adding auth required check

* # This is a combination of 10 commits.
# This is the 1st commit message:

add conditional for auth check message

update error message

Restore env var checks and pull from env var in keycloak config

define and load env vars for consumption

Finish adding auth required check

fix rbac component

# This is the commit message #2:

fix rbac component

# This is the commit message #3:

fix rbac component

# This is the commit message #4:

remove

# This is the commit message #5:

.env file instructions

# This is the commit message #6:

fix tests

# This is the commit message #7:

looking into express api served env vars

# This is the commit message #8:

Implement encrypted env var window object for prod

# This is the commit message #9:

Env var window object implementation

# This is the commit message #10:

Fix app crashing

* Finish adding auth required check

Implement encrypted env var window object for prod

Use cookies for unauthenticated routes against the hub

* fix

* wip

* cleanup

* cleanup

* pr comment responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants