Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entrypoint server dir #4

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix entrypoint server dir #4

merged 1 commit into from
Feb 22, 2022

Conversation

fbladilo
Copy link
Contributor

  • Exec node call should be within pkg/server instead of server

@gildub Not sure if we should be using exec npm run -s start instead of exec node index.js to start the server there , is there any difference?

@fbladilo fbladilo requested a review from gildub February 22, 2022 00:17
@gildub
Copy link
Contributor

gildub commented Feb 22, 2022 •
edited
Loading

@fbladilo,

Thanks for catching that.

The "pkg" path is not really necessary and will ultimately disappear on the target.
Because we're not using npm workspace yet we have to handle each pkg sub-project (for client and server) and that makes it more cumbersome than it needs to be.
We'll remove the pkg from the target later on.

Regarding exec npm run -s start vs exec node index.js, npm is always installed along node as part of the nodejs bundle, so we could use npm meanwhile in production we target nodejs runtime to run the Express server.

@gildub gildub closed this Feb 22, 2022
@gildub gildub reopened this Feb 22, 2022
gildub
gildub approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gildub gildub merged commit ca253c3 into konveyor:main Feb 22, 2022
ibolton336 referenced this pull request in ibolton336/tackle2-ui May 6, 2022
@ibolton336
# This is a combination of 6 commits.
62ca03d 
# This is the 1st commit message:

update env var names

# This is the commit message #2:

add conditional for auth check message

# This is the commit message #3:

update error message

# This is the commit message #4:

Restore env var checks and pull from env var in keycloak config

# This is the commit message konveyor#5:

define and load env vars for consumption

# This is the commit message konveyor#6:

Finish adding auth required check
ibolton336 referenced this pull request in ibolton336/tackle2-ui May 6, 2022
@ibolton336
# This is a combination of 10 commits.
c8d6659 
# This is the 1st commit message:

add conditional for auth check message

update error message

Restore env var checks and pull from env var in keycloak config

define and load env vars for consumption

Finish adding auth required check

fix rbac component

# This is the commit message #2:

fix rbac component

# This is the commit message #3:

fix rbac component

# This is the commit message #4:

remove

# This is the commit message konveyor#5:

.env file instructions

# This is the commit message konveyor#6:

fix tests

# This is the commit message konveyor#7:

looking into express api served env vars

# This is the commit message konveyor#8:

Implement encrypted env var window object for prod

# This is the commit message konveyor#9:

Env var window object implementation

# This is the commit message konveyor#10:

Fix app crashing
ibolton336 added a commit that referenced this pull request May 6, 2022
@ibolton336
Single user changes (#166)
25303e3 
* Change env var names to match hub

* # This is a combination of 6 commits.
# This is the 1st commit message:

update env var names

# This is the commit message #2:

add conditional for auth check message

# This is the commit message #3:

update error message

# This is the commit message #4:

Restore env var checks and pull from env var in keycloak config

# This is the commit message #5:

define and load env vars for consumption

# This is the commit message #6:

Finish adding auth required check

* # This is a combination of 10 commits.
# This is the 1st commit message:

add conditional for auth check message

update error message

Restore env var checks and pull from env var in keycloak config

define and load env vars for consumption

Finish adding auth required check

fix rbac component

# This is the commit message #2:

fix rbac component

# This is the commit message #3:

fix rbac component

# This is the commit message #4:

remove

# This is the commit message #5:

.env file instructions

# This is the commit message #6:

fix tests

# This is the commit message #7:

looking into express api served env vars

# This is the commit message #8:

Implement encrypted env var window object for prod

# This is the commit message #9:

Env var window object implementation

# This is the commit message #10:

Fix app crashing

* Finish adding auth required check

Implement encrypted env var window object for prod

Use cookies for unauthenticated routes against the hub

* fix

* wip

* cleanup

* cleanup

* pr comment responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gildub gildub gildub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbladilo @gildub