Redesign Data Input/Output Interface #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: moved ExpressionChromosome to the expression package. Feature: Added methods to TreeChromosome. Feature: Added methods to LinearChromosome. Refactor: Removed LinearExpressionChromosome. Refactor: ExpressionChromosome now implements both TreeChromosome and LinearChromosome. Refactor: Removed dead code from MeanSquaredError. Feature: Implemented Cloneable for ExpressionChromosome.
Refactor ExpressionChromosome
Documentation: documented the 'Chromosome' and 'Expression' packages. Documentation: made some minor style changes to the documentation of DefaultObjective and ErrorBasedObjective.
Feature: added a base factory class for producing chromosomes and a factory for expression chromosomes. Refactor: changed existing classes to use chromosome factories.
Refactor: changed the method for adding functional primitives to a chromosome factory to accept a variable number of arguments.
Documentation: documented most of the ExpressionChromosomeFactory class Refactor: changed ChromosomeFactory::addFunction to accept a list and refactored all users of the method. Bugfix: ChromosomeFactory::addFunction was attempting to add functions to a clone instead of the actual class member.
Documentation: feeatures are like better features, but we're saving those for Iconic Plus.
Testing: ExpressionChromosomeFactory now has a test suite and ExpressionChromosome's test has been updated for easier reuse. Documentation: added some brief documentation to all the tests.
Add Chromosome Factories
…r from finished. More methods and refactoring will be required.
Bugfix: if containsHeader was set to false the statement to fill the header row wouldn't be executed. Refactor: changed raw arrays to collection types. Refactor: FeatureClass now keeps track of whether or not it's an expected output. Refactor: Added a NumericFeatureClass subclass specifically for dealing with numeric types. Refactor: Added a Preprocessor superclass for preprocessors. Bugfix: Objectives and chromosomes now use the new input system. It probably works, but please add a regression suite. Misc: commented out the code in the GUI workspace controller that enabled data normalisation. We're moving to preprocessors so we're better off rewriting it instead. Warning: the changes to Objectives and Chromosomes are temporary workarounds to enable testing, they'll need to be changed later on.
JasbirShah
added
enhancement
Freakout2114
approved these changes
Aug 14, 2018
|
Remove WIP tag when you're ready for a merge |
JasbirShah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The current DataManager class was only designed with the prototype in mind, and so isn't suitable for meeting all of our requirements. It will need to be redesigned to support our final implementation as follows, Datasets will be stored as a Hashmap<String, Feature> where a Feature is a class containing the following:
This will allow us to store data by feature rather than by row, which will also make it much more efficient to access and modify. As two sets of data are stored for each feature: the original input, and the other with transformations applied, we'll be able to easily rollback/reverse transformations on-demand.
Going forward, users will also have to select whether their file has a header row. If there is one, the headers will be read in as is, other wise we'll generate a header row for them using A-Z, AA-ZZ, etc., in place of feature names.