Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge code to newest #1

Open
wants to merge 528 commits into
base: master
Choose a base branch
from
Open

merge code to newest #1

wants to merge 528 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 7, 2016

  1. transfer_log_lock_test.sh is redundant with wdt_lock_failfast.sh and … 

    …has sleep race

Summary:
transfer_log_lock_test.sh is redundant with wdt_lock_failfast.sh and has sleep race
so let's delete the one with sleep and use the one with -fork which always
(should) work

Reviewed By: uddipta

Differential Revision: D3526129

fbshipit-source-id: ff4fe3eaf6682cefacd5e633a574b351fcb748f5
    @ldemailly
    ldemailly authored and Facebook Github Bot 9 committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    f250461 View commit details
    Browse the repository at this point in the history

  2. wdt version bump 

    Summary: wdt version bump auto commit

fbshipit-source-id: 38c5e51d818645a55f7cae4f5266b90ca47ef3d1
    svcscm@fb.com authored and Facebook Github Bot 0 committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    6c65e28 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2016

  1. cxx14 folly dependency / fixing build 

    Summary:
This hopefully
Fixes #126
without creating more issues
Closes #127

Reviewed By: mzlee

Differential Revision: D3549614

Pulled By: ldemailly

fbshipit-source-id: c93faf5ecbc40c1906e56b56bdf7d760446d46bf
    @ldemailly
    ldemailly authored and Facebook Github Bot 0 committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    93bc0f7 View commit details
    Browse the repository at this point in the history

  2. wdt version bump 

    Summary: wdt version bump auto commit

fbshipit-source-id: 5593abd6bb39c3ba81a547385c778f70e3f45794
    svcscm@fb.com authored and Facebook Github Bot 8 committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    7197492 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2016

  1. WDT apps can be released 

    Summary: For unit testing stargate, we need to be able to remove WDT object for an app

Reviewed By: ldemailly

Differential Revision: D3554004

fbshipit-source-id: eb8261bd9732916273086254bcfe8a0a9deab0e5
    @uddipta
    uddipta authored and Facebook Github Bot 8 committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    fa7830d View commit details
    Browse the repository at this point in the history

  2. wdt version bump 

    Summary: wdt version bump auto commit

fbshipit-source-id: afd5faec7ff71b96ec0a33dcba53bb429ed6a66d
    svcscm@fb.com authored and Facebook Github Bot 2 committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    ba032ae View commit details
    Browse the repository at this point in the history

  3. Download coordination in stargate 

    Summary:
Adding a mode of stargate where we try to minimize cross region data transfer.
For this, hosts in the same region elect one host to download data cross region.
It is then distributed to other hosts using WDT.

Reviewed By: ldemailly

Differential Revision: D3542052

fbshipit-source-id: 6fe4cf828c7cc4f7da3f9efd64b14e970c522b2a
    @uddipta
    uddipta authored and Facebook Github Bot committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    939fbac View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2016

  1. Add wdtReceiveAsync 

    Summary:
Add wdtReceiveAsync on wdt as wdtSend already exists.

It's follow up diff on D3515823.

Reviewed By: uddipta

Differential Revision: D3532271

fbshipit-source-id: efb2ae6fa9ecabb80f97ae04c6518e68123fad76
    Zun Wang authored and Facebook Github Bot 5 committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    40641b3 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2016

  1. OpenSSL 1.1.0 compatibility: fix remaining cases of non-heap-allocate… 

    …d EVP_CIPHER_CTX in fbcode

Summary: Fixed remaining cases of stack-allocated or class/struct member EVP_CIPHER_CTX structures, since that won't work in OpenSSL 1.1.0+. Clang-format-diff.py is responsible for a lot of the whitespace changes.

Reviewed By: knekritz

Differential Revision: D3707470

fbshipit-source-id: e36a99756ab84bbe32812be9791a6e692da72deb
    @ivmaykov
    ivmaykov authored and Facebook Github Bot 4 committed Aug 16, 2016
    Configuration menu
    Copy the full SHA
    ccf86c8 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2016

  1. revert wdt changes introduced in D3707470 

    Summary: See title. Apparently my changes are causing crashes.

Reviewed By: uddipta

Differential Revision: D3752985

fbshipit-source-id: 71fff8d3252b10fcc1bd52faefe30c81de31ed5f
    @ivmaykov
    ivmaykov authored and Facebook Github Bot 5 committed Aug 22, 2016
    Configuration menu
    Copy the full SHA
    65e04e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. Global sender and receiver limit configuration through gflag was not … 

    …working

Summary:
Global sender and receiver limit configuration through gflag was not working.
Resource controller was getting created before options were updated from flags.

Reviewed By: ldemailly

Differential Revision: D3789161

fbshipit-source-id: c7acb805273c59e8e63f2f38d0a4a4ef053de39a
    @uddipta
    uddipta authored and Facebook Github Bot 7 committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    3bd2c51 View commit details
    Browse the repository at this point in the history

  2. fix broken build thx to folly changes 

    Summary: Closes #129

Differential Revision: D3793113

Pulled By: ldemailly

fbshipit-source-id: 97b2cfa945e596daa09dfc576fb8549a8c7957a9
    @ldemailly
    ldemailly authored and Facebook Github Bot 6 committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    1653f81 View commit details
    Browse the repository at this point in the history

  3. also show stargate history in build email 

    Summary: also show stargate history in build email because we now also run extended stargate tests which can break

Reviewed By: uddipta

Differential Revision: D3792218

fbshipit-source-id: 147b696e75d47d7bb810d00b0c4349939c13ac28
    @ldemailly
    ldemailly authored and Facebook Github Bot 0 committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    57e660d View commit details
    Browse the repository at this point in the history

  4. fixing test failing because options of timeout test impacted other test 

    Summary: fixing test failing because options of timeout test impacted other test

Reviewed By: uddipta

Differential Revision: D3794716

fbshipit-source-id: c7b8cfd8a23cfafa346477b4a9421090ac4ccbcb
    @ldemailly
    ldemailly authored and Facebook Github Bot 7 committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    591cb1e View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2016

  1. codemod: add explicit headers parameter for C/C++ rules under 

    Summary:
This codemods `TARGETS` under `[a-d]*` directories in fbcode to make
the `headers` parameter explicitly refer to `AutoHeaders.RECURSIVE_GLOB`.

Reviewed By: yfeldblum

Differential Revision: D3801845

fbshipit-source-id: 715c753b6d4ca3a9779db1ff0a0e6632c56c0655
    @andrewjcg
    andrewjcg authored and Facebook Github Bot 6 committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    728c5d9 View commit details
    Browse the repository at this point in the history

  2. Add ScopeGuard.h include in places where it is needed. 

    Summary: Fix code that is transitively including ScopeGuard.h via FBString.h.

Reviewed By: yfeldblum

Differential Revision: D3801328

fbshipit-source-id: 7e1dc37cd6dd3aa691dd1baf31385d3a8c51eed0
    Eric Niebler authored and Facebook Github Bot 8 committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    fdb7b0b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2016

  1. Mac brew openssl issue and cmake 3.6 compat 

    Summary:
also explicitly search in $HOME to find double-conversion etc

fixes #130
Closes #131

Differential Revision: D3815176

Pulled By: ldemailly

fbshipit-source-id: 9c1689414f70ff8ffa3307234fda12f2620e636b
    @ldemailly
    ldemailly authored and Facebook Github Bot 7 committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    3496ef0 View commit details
    Browse the repository at this point in the history

  2. wdt version bump 

    Summary: wdt version bump auto commit

fbshipit-source-id: 43816469871a356c8d184038d15b884f0306d8cd
    svcscm@fb.com authored and Facebook Github Bot 1 committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    3d5f79a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2016

  1. auto version bump was failing 

    Summary:
auto version bump was failing
because hg pull decided to start sending stuff to stderr
( https://www.facebook.com/groups/sourcecontrol/permalink/1075501102499509/ )
this fixes that

Reviewed By: hehe-wz

Differential Revision: D3815710

fbshipit-source-id: b3842ed9d03e871e67d87cb1c4f97117f2b4e10d
    @ldemailly
    ldemailly authored and Facebook Github Bot 7 committed Sep 7, 2016
    Configuration menu
    Copy the full SHA
    138a011 View commit details
    Browse the repository at this point in the history

  2. wdt version bump 

    Summary: wdt version bump auto commit

fbshipit-source-id: bb80d8cee7d80cf3dc62d01a4a5ff09cd271f45a
    svcscm@fb.com authored and Facebook Github Bot 2 committed Sep 7, 2016
    Configuration menu
    Copy the full SHA
    b3ee0e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2016

  1. sync repo hashes 

    Summary:
sync repo hashes
fbshipit-source-id: e6bfdc30ee5b0d0242f8c4f3a35bc2bb6cac2021

Test Plan:
n/a

Reviewers:

Subscribers:

Tasks:

Blame Revision:
    @ldemailly
    ldemailly committed Sep 9, 2016
    Configuration menu
    Copy the full SHA
    c17d3aa View commit details
    Browse the repository at this point in the history

  2. wdt version bump 

    Summary: wdt version bump auto commit

fbshipit-source-id: 3219116d44d9afa810a64f0bafc257909e279dc4
    svcscm@fb.com authored and Facebook Github Bot 7 committed Sep 9, 2016
    Configuration menu
    Copy the full SHA
    041523b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2016

  1. Version update script for stargate 

    Summary:
1) version update script for stargate
2) auto version upgrade in case of successful build

Reviewed By: ldemailly

Differential Revision: D3851015

fbshipit-source-id: 3a7cd014f7ee1fe1520d44121c8f133f23b577f4
    @uddipta
    uddipta authored and Facebook Github Bot 1 committed Sep 12, 2016
    Configuration menu
    Copy the full SHA
    7342fe8 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 989d142469ac5a8e07d70bf650dca45c521944f0
    svcscm@fb.com authored and Facebook Github Bot 6 committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    c50ea50 View commit details
    Browse the repository at this point in the history

  2. fixing stargate tests leaking space in dev/shm 

    Summary:
fixing stargate tests leaking space in dev/shm
also use hg log from either stargate or wdt to generate auto version

Reviewed By: uddipta

Differential Revision: D3857948

fbshipit-source-id: 6d1e355066e083d10b5533306dde1777f5b44a60
    @ldemailly
    ldemailly authored and Facebook Github Bot 0 committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    5d17d17 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2016

  1. WDT throttler rate can now be lowered in the middle of a transfer 

    Summary:
WDT throttler rate can now be lowered in the middle of a transfer. We reset
throttler state in case rate changes

Reviewed By: ldemailly

Differential Revision: D3860371

fbshipit-source-id: f19b3ce772cc1f85065bfa9e9ec6bb5757807f6a
    @uddipta
    uddipta authored and Facebook Github Bot 9 committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    7257759 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 54c480e0ba965e62b54dbed3ecb1a1eb134e4833
    svcscm@fb.com authored and Facebook Github Bot 9 committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    d190c0c View commit details
    Browse the repository at this point in the history

  3. Reducing throttler rate in test so that it passes with asan 

    Summary: Reducing throttler rate in test so that it passes with asan

Reviewed By: ldemailly

Differential Revision: D3861060

fbshipit-source-id: f575fe636f90b4781fd1c3388cb31a5bd3c1a502
    @uddipta
    uddipta authored and Facebook Github Bot 8 committed Sep 14, 2016
    Configuration menu
    Copy the full SHA
    e985545 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 233bc23e43cc75096ead6815d883ab9f836783b4
    svcscm@fb.com authored and Facebook Github Bot committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    e19ccf5 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2016

  1. Server-id as second key for sender in WDT resource controller 

    Summary: Server-id as second key for sender in WDT resource controller.

Reviewed By: ldemailly

Differential Revision: D3880699

fbshipit-source-id: 416df541cc4dfba37e487f90c97262e9f64a4cc0
    @uddipta
    uddipta authored and Facebook Github Bot committed Sep 17, 2016
    Configuration menu
    Copy the full SHA
    937539a View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 967115a49a26df6b878e9beb20b6ad1b7c8f78f8
    svcscm@fb.com authored and Facebook Github Bot 8 committed Sep 17, 2016
    Configuration menu
    Copy the full SHA
    aea22f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2016

  1. make wdt uri binary safe so we can use any shard value in stargate 

    Summary:
make wdt uri binary safe so we can use any shard value in stargate
also elminate empty query args

Reviewed By: uddipta

Differential Revision: D3898750

fbshipit-source-id: 9f074622dd0829f1b83dcbc78de965b4dc2e3d0d
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    f9a46a4 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 56ff2567326c5c5326963f9c36576750cec2f1da
    svcscm@fb.com authored and Facebook Github Bot 5 committed Sep 21, 2016
    Configuration menu
    Copy the full SHA
    390ff27 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2016

  1. Sender in WDT is created before preparing snapshot, also multiple cle… 

    …anups

Summary:
1) Sender constructor cleanup
2) Removing WDT support from rocks log server code
3) Sender is created before preparing snapshots
4) Sender is not run in thrift serving thread pool
5) Fixing stargate-wdt destination identifier problem, added a test for that

Reviewed By: ldemailly

Differential Revision: D3887608

fbshipit-source-id: c0ea210b468fa13a7715f6037ef7747aff5b5454
    @uddipta
    uddipta authored and Facebook Github Bot 2 committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    6c656c3 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: a0dcea14a62ed196039be84e47c1e2adffd9ed3c
    svcscm@fb.com authored and Facebook Github Bot 8 committed Sep 23, 2016
    Configuration menu
    Copy the full SHA
    b020553 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2016

  1. Support for long prepareSnapshot in WDT service 

    Summary: t13405078 has the details of the problem due to long prepareSnapshot

Reviewed By: ldemailly

Differential Revision: D3925084

fbshipit-source-id: b99a74d0a97d92eda13b2812c7d663f185dc1490
    @uddipta
    uddipta authored and Facebook Github Bot 9 committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    3a173a4 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 1dcef96fb143afe8b8498536c16f9d0eca9568d1
    svcscm@fb.com authored and Facebook Github Bot 7 committed Sep 28, 2016
    Configuration menu
    Copy the full SHA
    c0e0be4 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2016

  1. legocastle json files for wdt build 

    Summary:
the _test file works:

https://our.intern.facebook.com/intern/sandcastle/1971357929/

Reviewed By: uddipta, perryjrandall

Differential Revision: D3941714

fbshipit-source-id: 5383d12e8c6ed291543683d042c7dd993ce23540
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Sep 29, 2016
    Configuration menu
    Copy the full SHA
    1887f2f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2016

  1. fixes json correctness 

    Summary:
used jsonlint.com to find the actual issues that internal stuff didn't show
run json_verify on output

Reviewed By: hehe-wz

Differential Revision: D3948103

fbshipit-source-id: 8036ced1eed9b606611b1983257f0571945b5638
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    779e2ef View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 5c8760a63612610f79417d0fbc434fba049f9602
    svcscm@fb.com authored and Facebook Github Bot committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    0f40e3a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2016

  1. fix wdt oss build script for landscastle 

    Summary: making brownian changes until it works

Reviewed By: uddipta

Differential Revision: D3949430

fbshipit-source-id: c2d94356b93c04f5c6a7a492f6e0fe10470075ae
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    a38ef09 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 6d616fe5b3d03ade5de945e4bcfc60130fd80428
    svcscm@fb.com authored and Facebook Github Bot committed Oct 11, 2016
    Configuration menu
    Copy the full SHA
    0e0a5cd View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2016

  1. Improving fairness of the throttler 

    Summary:
WDT throttler is now used in stargate to throttle hdfs backup/download, and
application specific downloads. Rocksdb backup engine throttles 5M at a time.
However, WDT sender/receiver throttles 256K at a time. If a thread requests to
throttle more data, it gets higher percentage of the bandwidth available. For
example, Backup engine threads will get 20 time more bandwidth than WDT threads.
This sometimes causes WDT transfers to fail with NO_PROGRESS.
To solve this, any throttle request for more than 256K is broken down internally
to bunch of 256K requests. This ensures that one single thread is not able to
take too much of the bandwidth.

Reviewed By: ldemailly

Differential Revision: D4028660

fbshipit-source-id: ab65e1a9ac4861364a801083e56bf30efbb4e153
    @uddipta
    uddipta authored and Facebook Github Bot committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    65b96ce View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 9e533d3dadaa55d89bf6a168f5b2c495c6da6f9b
    svcscm@fb.com authored and Facebook Github Bot committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    932a5c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2016

  1. Reporting number of bytes saved due to incremental download 

    Summary: Reporting number of bytes saved due to incremental download

Reviewed By: hehe-wz

Differential Revision: D4028667

fbshipit-source-id: fe109bf76dda75f401af5529bbc4577009bff944
    @uddipta
    uddipta authored and Facebook Github Bot committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    a1090f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 752a9858dd60c4553ea04a0945e1df779b8f4f8c
    svcscm@fb.com authored and Facebook Github Bot committed Oct 28, 2016
    Configuration menu
    Copy the full SHA
    0c03b9a View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2016

  1. Add option to sync files at the end of the transfer 

    Summary: `sync_file_range()`, which is used by default, is not synchronous, so WDT can complete before the received data has been committed to disk. This diff adds an option, `fsync_at_completion`, that calls `fsync` at the end of each file transfer, even when not in resumable mode.

Reviewed By: ldemailly

Differential Revision: D4103280

fbshipit-source-id: 88e903693566201f17b5536e1c5fd309e890702b
    @ot
    ot authored and Facebook Github Bot committed Oct 31, 2016
    Configuration menu
    Copy the full SHA
    00ccb61 View commit details
    Browse the repository at this point in the history

  2. wdt: avoid shadowing warnings 

    Summary:
Fix warnings exposed by (gcc's upstream-to-be-added) -Wshadow-compatible-local
(and/or the stricter -Wshadow-local) options.  Note that these
are both less onerous than -Wshadow.

Reviewed By: uddipta

Differential Revision: D4105027

fbshipit-source-id: 9109845a39710001f92fdf4107f3617f929c4222
    @meyering
    meyering authored and Facebook Github Bot committed Oct 31, 2016
    Configuration menu
    Copy the full SHA
    cc9f9a9 View commit details
    Browse the repository at this point in the history

  3. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 5dc6d519c21477927d917479e6bfca6513164d53
    svcscm@fb.com authored and Facebook Github Bot committed Oct 31, 2016
    Configuration menu
    Copy the full SHA
    5c66a89 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: f16130a49e693ec4d968a5874c62f65a96ac3399
    svcscm@fb.com authored and Facebook Github Bot committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    c567316 View commit details
    Browse the repository at this point in the history

  2. minor improvement on doc on how to run single test 

    Summary: minor improvement on doc on how to run single test

Reviewed By: uddipta

Differential Revision: D4125914

fbshipit-source-id: 7f201531965599df2bbb86c6c67bf2e28be21351
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    07ad0c0 View commit details
    Browse the repository at this point in the history

  3. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: cf727f9d0cef14916f0c0c9c37d97b9eae9929b0
    svcscm@fb.com authored and Facebook Github Bot committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    d7eb1c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2016

  1. integer overflow in disk mode (wrong type for offset in socket handling) 

    Summary: integer overflow in disk mode (wrong type for offset in socket handling)

Reviewed By: uddipta

Differential Revision: D4199365

fbshipit-source-id: e0879d70b666e0c2ce95a008800b2c6c32b2d0b3
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    16e0678 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: a315ffe7fee0781e252de08aca6f26e2e4d5f8af
    svcscm@fb.com authored and Facebook Github Bot committed Nov 17, 2016
    Configuration menu
    Copy the full SHA
    f8930c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2016

  1. Add gflag support 

    Summary:
This diff allow user to pass basic (bool/int/string) gflag and convert to StargateOptions.

Need to add support for vector of int/string, plan to use "xxx,yyy,zzz" to format
Hacked on some macro. ldemailly

Reviewed By: ldemailly

Differential Revision: D4191042

fbshipit-source-id: ab17d7ea8cae4ad8a6193e60c59a6da210e883c5
    Zun Wang authored and Facebook Github Bot committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    59985c6 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: ddaebbc776c317e2ddd577499d0bcc873e35ffa4
    svcscm@fb.com authored and Facebook Github Bot committed Nov 18, 2016
    Configuration menu
    Copy the full SHA
    2b6ecc4 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2016

  1. codemod --extensions="*" folly::make_uniq std::make_uniq ; with 'Yes … 

    …to all'

Summary:
codemod --extensions="*" folly::make_uniq std::make_uniq ; with 'Yes to all'
will reduce dependencies (for wdt, checked we already require gcc 4.9)

Reviewed By: nedelchev

Differential Revision: D4215453

fbshipit-source-id: 7a9bf0824d8bee9311e5302082e77ddd3102b21c
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    b5ff57d View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2016

  1. fix for change in folly and for sierra macos compile 

    Summary:
avoids:
/Users/ldemailly/github/wdt/../folly/folly/portability/Time.h:32:17:
error: typedef redefinition with different types ('uint8_t' (aka
'unsigned char') vs 'enum clockid_t')
typedef uint8_t clockid_t;
^
/usr/include/time.h:171:3: note: previous definition is here
} clockid_t;
^

and

Undefined symbols for architecture x86_64:
"folly::ScopeGuardImplBase::warnAboutToCrash()", referenced from:

folly::ScopeGuardImpl<facebook::wdt::ClientSocket::connect()::$_0>::~Sco
peGuardImpl() in ClientSocket.cpp.o
Closes #134

Differential Revision: D4234290

Pulled By: ldemailly

fbshipit-source-id: bb4a66e4ab31d677865f982ad24aea92e2b04ef3
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 26, 2016
    Configuration menu
    Copy the full SHA
    4f690c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: e102556374a617cc3fb3d9e9375939a3e499588e
    svcscm@fb.com authored and Facebook Github Bot committed Nov 27, 2016
    Configuration menu
    Copy the full SHA
    c99bd69 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2016

  1. wdt cont build: what I had to change to run on devbig991.ash4 (centos7) 

    Summary: wdt cont build: what I had to change to run on devbig991.ash4 (centos7)

Reviewed By: nedelchev

Differential Revision: D4235033

fbshipit-source-id: 45d0fafaf6a1366945f3cd93285f946958248352
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    8813d20 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 05eb9e12cfd441f2b76da3812b9f309fb15916b9
    svcscm@fb.com authored and Facebook Github Bot committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    c87923c View commit details
    Browse the repository at this point in the history

  3. allow running the tests from their .py / .sh test script directly aga… 

    …in without buck test

Summary:
allow running the tests from their .py / .sh test script directly again without buck test

super minor  and quick change but allows to run say
./wdt/test/wdt_network_test.sh
./wdt/test/wdt_bad_server_test.py
after buck build wdt:
(because the script defaults had only support for the open source/fbmake
locations)

Reviewed By: nedelchev

Differential Revision: D4238957

fbshipit-source-id: d07e8a2db7fd255062c90b212152e53d146112ee
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    cbcd6c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: f8dd00622c66b9b87870574903db4c47b891ad03
    svcscm@fb.com authored and Facebook Github Bot committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    5db93b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2016

  1. avoid crashes, faster varint, fewer dependencies 

    Summary:
wdt could corrupt memory on bad input

re speed:  buck build mode/opt and :
  [19:27 devbig650.prn1:fbcode(sg2)]$ ./buck-out/gen/wdt/test_encdeci64_perf
  ============================================================================
  wdt/test/test_encdeci64_perf.cpp                relative  time/iter  iters/s
  ============================================================================
  BM_encodeDecodeI64(0)                                       10.67ns   93.73M
  BM_encodeDecodeI64(m10k)                                     3.67ns  272.66M
  BM_encodeDecodeI64(10000)                                    3.67ns  272.66M
  BM_encodeDecodeI64(m1k)                                      2.67ns  374.93M
  BM_encodeDecodeI64(1000)                                     2.67ns  374.93M
  BM_encodeDecodeI64(m100)                                     2.67ns  374.93M
  BM_encodeDecodeI64(100)                                      2.77ns  360.85M
  BM_encodeDecodeI64(m10)                                      2.05ns  488.55M
  BM_encodeDecodeI64(10)                                       2.05ns  488.34M
  BM_encodeDecodeI64_vi(0)                                    13.56ns   73.73M
  BM_encodeDecodeI64_vi(m10k)                                  7.33ns  136.34M
  BM_encodeDecodeI64_vi(10000)                                 7.33ns  136.34M
  BM_encodeDecodeI64_vi(m1k)                                   5.00ns  199.97M
  BM_encodeDecodeI64_vi(1000)                                  5.00ns  199.97M
  BM_encodeDecodeI64_vi(m100)                                  5.00ns  199.97M
  BM_encodeDecodeI64_vi(100)                                   5.00ns  199.97M
  BM_encodeDecodeI64_vi(m10)                                   2.38ns  420.09M
  BM_encodeDecodeI64_vi(10)                                    2.38ns  420.53M
  BM_encodeDecodeI64_str(0)                                   44.63ns   22.41M
  BM_encodeDecodeI64_str(m10k)                                18.67ns   53.55M
  BM_encodeDecodeI64_str(10000)                               18.69ns   53.50M
  BM_encodeDecodeI64_str(m1k)                                 16.08ns   62.20M
  BM_encodeDecodeI64_str(1000)                                16.08ns   62.19M
  BM_encodeDecodeI64_str(m100)                                16.08ns   62.20M
  BM_encodeDecodeI64_str(100)                                 16.08ns   62.20M
  BM_encodeDecodeI64_str(m10)                                 13.38ns   74.74M
  BM_encodeDecodeI64_str(10)                                  13.38ns   74.73M
  BM_encodeDecodeI64_vi_str(0)                                31.10ns   32.16M
  BM_encodeDecodeI64_vi_str(m10k)                             22.70ns   44.04M
  BM_encodeDecodeI64_vi_str(10000)                            22.72ns   44.02M
  BM_encodeDecodeI64_vi_str(m1k)                              21.37ns   46.80M
  BM_encodeDecodeI64_vi_str(1000)                             21.37ns   46.79M
  BM_encodeDecodeI64_vi_str(m100)                             21.37ns   46.80M
  BM_encodeDecodeI64_vi_str(100)                              21.35ns   46.84M
  BM_encodeDecodeI64_vi_str(m10)                              20.21ns   49.47M
  BM_encodeDecodeI64_vi_str(10)                               20.09ns   49.78M
  ============================================================================

_vi is the folly varint version, without _vi is the new, faster, more compact one

Reviewed By: uddipta

Differential Revision: D4225139

fbshipit-source-id: d85683fe70416738208883e86a6dd5f6db2d05b2
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    86c82a5 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 0b5501c7049cc18e4f3b7d212313a4241a906bee
    svcscm@fb.com authored and Facebook Github Bot committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    c4c8fc6 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2016

  1. download_resume sender/receiver handshake 

    Summary:
the diff ensures that wdt receiver imposes its download_resume
(if = true) on the sender.  it also makes sure that download_resume with
delete_extra_files=true, the set of files are kept identical on the sender
and receiver.

Reviewed By: ldemailly

Differential Revision: D4251809

fbshipit-source-id: 725c3ef02f2a10339223aca9958703ad49ae3e3c
    @nedelchev
    nedelchev authored and Facebook Github Bot committed Dec 3, 2016
    Configuration menu
    Copy the full SHA
    143fcf5 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: f3a1339458ba24c75a6b86d45eb45c730ea7620f
    svcscm@fb.com authored and Facebook Github Bot committed Dec 3, 2016
    Configuration menu
    Copy the full SHA
    564c916 View commit details
    Browse the repository at this point in the history

  3. forgot to modify this in my last checkin 

    Summary: i made a haste checkin without reading thru the last remaining comments

Reviewed By: ldemailly

Differential Revision: D4271013

fbshipit-source-id: f59d148505b2ef7f66e487d7e8e94ab7af87c2ee
    @nedelchev
    nedelchev authored and Facebook Github Bot committed Dec 3, 2016
    Configuration menu
    Copy the full SHA
    feae306 View commit details
    Browse the repository at this point in the history

  4. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: af265982b4f2a7e31539159a29bf3e4ea55a38a5
    svcscm@fb.com authored and Facebook Github Bot committed Dec 3, 2016
    Configuration menu
    Copy the full SHA
    6fe8140 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2016

  1. Trigger lego-mac build too 

    Summary:
This should let me get rid of the 2 mac minis on my desk
and find open source mac breakage on diffs instead of after the facts

Reviewed By: perryjrandall

Differential Revision: D4287428

fbshipit-source-id: d6c9d80b64bc834a2a69496f2ee4cd2866427d0f
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    9d18475 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. mac lego build test and fix 

    Summary:
testing mac lego build
fixing typos from D4287428

Reviewed By: hehe-wz, nedelchev

Differential Revision: D4289371

fbshipit-source-id: 331eef1f0f8e2f5268188562ecc9648632644255
    @ldemailly
    ldemailly authored and Facebook Github Bot committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    2138b3b View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 3665529067cc667bc1ac72867b7bd37786b179ce
    svcscm@fb.com authored and Facebook Github Bot committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    4df157b View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2016

  1. Require xcode for wdt-opensource-mac 

    Summary:
When this happens to get scheduled on a machine without xcode, it fails:
https://www.facebook.com/groups/734933446555273/permalink/1244653532249926/

Reviewed By: dorserg

Differential Revision: D4319519

fbshipit-source-id: 0e4e4f2391909e5b3d7af69e59d8705f1f924221
    @illicitonion
    illicitonion authored and Facebook Github Bot committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    a55889e View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 0f4a11bafd44eb97347f8e83e81e6ea4f8594663
    svcscm@fb.com authored and Facebook Github Bot committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    779a693 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2016

  1. fbcode: remove unused includes from .cpp files with no #if and #define 

    Summary:
This is a first diff to remove the "easiest" unused includes in fbcode.

* For safety, we only touch .cpp files without #if and #define,
* We do not try to remove redundant systems headers (aka. "packing").

The diff was generated as follows:
```
foundation/scripts/ls-cpp-dirs | grep -v '^\(\.\.\|external/\|.*/external\)' | xargs ffmr -o /tmp/ffmr-diff-1 codegraph/scripts/ffmr/analyze_includes_no_headers_no_packing_skipping_ifdefs.sh

cat /tmp/ffmr-diff-1/*.diff | patch -p2
hg commit -m something
arc diff --prepare --nolint --nounit --less-context --excuse refactoring
```

Note: `grep -v` is just an optimization. The actual configuration is in these two files:
diffusion/FBS/browse/master/fbcode/codegraph/analysis/config.py
diffusion/FBS/browse/master/fbcode/codegraph/scripts/ffmr/analyze_includes_no_headers_no_packing_skipping_ifdefs.sh

See the task for more context, and the recent "safety" improvements on the tool.

depends on D4317825 for very few cases where `nolint` had to be manually added.

Reviewed By: igorsugak

Differential Revision: D4312617

fbshipit-source-id: ecc1f0addfd0651fa4770fcc43cd1314661a311a
    @ma2bd @facebook-github-bot
    ma2bd authored and facebook-github-bot committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    b6d56f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2016

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 2de2aab34d47951ef91172aa9257097588f5490d
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    9338ad5 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2016

  1. manual code mod to ensure all logs are prefixed correctly 

    Summary:
added WPLOG and WTPLOG macros - renamed WTVLOG for consistency
checked:
hg grep "LOG(" |egrep -v "W.*LOG\("|less
such as only bench/ and tests are using naked *LOG without W prefix

Reviewed By: jjleng

Differential Revision: D4370903

fbshipit-source-id: 33e462cea4520f89ded5969c0869c32d9a7c47fb
    @ldemailly @facebook-github-bot
    ldemailly authored and facebook-github-bot committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    f658b66 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 11b8e82478fa01c45bab1b1b2dece7bc6fe31c30
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    0908e6c View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2017

  1. Support transfer log compaction 

    Summary: Implementation of transfer log compactor

Reviewed By: uddipta

Differential Revision: D4369818

fbshipit-source-id: 14868beb2d007a177c8cc092506d9f88f206b521
    @facebook-github-bot
    Jason Leng authored and facebook-github-bot committed Jan 7, 2017
    Configuration menu
    Copy the full SHA
    18b2fdd View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 3b7534e3dc3ac57c8da6ba739de3df6a133d6be2
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    e5c33d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2017

  1. moving stats from wormhole to wdt so it can be used in stargate 

    Summary:
moving stats from wormhole to wdt so it can be used in stargate
also stepped on using std::string in some wormhole.h that I fixed
(though that creates noise on the diff)

misc: clangformat and missing opensource headers

Reviewed By: ThomasFersch

Differential Revision: D4401393

fbshipit-source-id: 43317702814327736b332da128eab64e9ec14959
    @ldemailly @facebook-github-bot
    ldemailly authored and facebook-github-bot committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    8dbffb4 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 1524beafa0485234e567203e98ca2fb6265a3581
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    8042605 View commit details
    Browse the repository at this point in the history

  3. codemod: normalize target names in TARGETS files 

    Summary:
An upcoming change will make the translator in the macro library
more strict about what it accepts.

Reviewed By: ldemailly, yfeldblum

Differential Revision: D4413635

fbshipit-source-id: d11979af999bfe0b689a4d4ad5cd198355a8fdbc
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    d57c638 View commit details
    Browse the repository at this point in the history

  4. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: bf19c21ab12b16fd5c276427bb65177043a20ec1
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    c6b6ce2 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2017

  1. codemod: fixup more build targets in TARGETS 

    Summary:
Ran script from:
differential/diff/21475830/

Reviewed By: Gownta

Differential Revision: D4419263

fbshipit-source-id: 7631ea2c2cb3b6e27756ecc9da9e492b2a3b2dab
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    85c0848 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 895df8759697757d1b23d124d0b565b78f129639
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    fd31298 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2017

  1. Detecting filesystem type and changing options according to that 

    Summary:
Detecting filesystem type and changing options according to that. Also, setting
correct wdt options in case of incremental peer backup

Reviewed By: nedelchev

Differential Revision: D4447904

fbshipit-source-id: 30cb4d8513bbf5ddbbea84e39b2ddd3400c2645b
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    1735d26 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 07286587b69ab933c508166ba30136fafd9eeb57
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Jan 24, 2017
    Configuration menu
    Copy the full SHA
    0cc0d28 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2017

  1. wdt/test/ProtocolTest.cpp: fix two typos 

    Summary:
Fix two typos.

Not only is nbd.dataSize always going to be equal to itself, but
from context, it is clear that the RHS should use "bd", not "nbd":

  EXPECT_EQ(nbd.fileSize, bd.fileSize);
  EXPECT_EQ(nbd.offset, bd.offset);
  EXPECT_EQ(nbd.dataSize, nbd.dataSize);
                          ^

Reviewed By: uddipta

Differential Revision: D4457563

fbshipit-source-id: 0191867eaa32755b65db5575f88814236c873614
    @meyering @facebook-github-bot
    meyering authored and facebook-github-bot committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    dd58738 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 7e83fa86157e19a97c80fc0e9a75a4d911f52dd4
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Jan 25, 2017
    Configuration menu
    Copy the full SHA
    e0d004c View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2017

  1. remove unused includes in fbcode (skipping #if, new default mode) 

    Summary:
This solves most include warnings as seen in Phabricator (no header files, no "packing" system headers, new default mode where more user headers are removed).

We cowardly skip files containing #if for now.

Generated by
```
rm -f /tmp/ffmr-diff/* &&
cd fbcode &&
(foundation/scripts/ls-cpp-dirs | grep -v '^\(\.\.\|external/\|.*/external\|folly/|watchman/\)' |
xargs ffmr -o /tmp/ffmr-diff codegraph/scripts/ffmr/analyze_includes_no_headers_no_packing_skipping_if.sh) &&
(cat /tmp/ffmr-diff/*.diff | patch -p2) &&
hg commit -m foo &&
cd .. &&
arc amend --yes --revision D4414676 && arc diff --nolint --nounit --excuse refactoring --prepare --big-diff -m 'something'
```

folly and watchman are in separate diffs.

Reviewed By: meyering

Differential Revision: D4414676

fbshipit-source-id: 75e2e11f4fac8a5f8071a1bafcc4ddc355fd6f4e
    @ma2bd @facebook-github-bot
    ma2bd authored and facebook-github-bot committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    f83e070 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2017

  1. Moving encryption to a separate layer (preparation for compression) 

    Summary:
In WDT, encryption was implemented in two layers. Encryption/decryption was done
at socket layer. But, incremental tag verification happened at sender/receiver
layer. Due to this, it is hard to add features like compression.
To solve this, we are moving tag verification to socket layer. Encryption tags
will get added to the data stream at regular interval and will get verified on
the receiving side. Higher layer will be able to set a callback to receive tag
verification success events.
This change is however not backward compatible with current version of WDT. So,
we will disable encryption (by changing url key) for new <-> old transfers.
New <-> new transfers will be encrypted.

Reviewed By: nedelchev

Differential Revision: D4480953

fbshipit-source-id: d5c31ecfcb435c8196e2ca3cdfb9aa4a7cbb8c94
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    73675e5 View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: d3f6ce2fa2115a5734e79760765232316f3686dc
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    6ecde8b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2017

  1. Fixing double logging in wdt/stargate 

    Summary: Fixing double logging in wdt/stargate

Reviewed By: nedelchev

Differential Revision: D4500770

fbshipit-source-id: c5270be18f13d8ebc23f63234d25d6ccafc2a4e0
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    6c071c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 3522bde656cc783119002946858032e37b5e726a
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Feb 7, 2017
    Configuration menu
    Copy the full SHA
    4ae9927 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2017

  1. wdt now builds and works with openssl1.1.0 

    Summary:
Necessary changes for making WDT work with openssl1.1.0.
Simplified the code to not reuse encryption context, because the code to reuse
context is openssl version dependent.
Couldn't get buck to work locally with openssl1.1.0. So, used wdt's open source
cmake build and used latest openssl code from github.
Ran tests where one side was using openssl1.0.1 and the other 1.1.0.

Reviewed By: jjleng

Differential Revision: D4592601

fbshipit-source-id: 209d767fb7b0370f113e82a9641f536763feb12c
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Feb 22, 2017
    Configuration menu
    Copy the full SHA
    c65a56b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2017

  1. updating BUILD.md for newer Mac OS and brew 

    Summary:
updating Mac instructions
brew can install everything

ps: some test seems to take a very long time and/or fail on my personal MacOS 10.12.3 (2.9 GHz Intel Core i5, 256Gb SSD, (only)8Gb ram)
Closes #147

Reviewed By: jjleng

Differential Revision: D4621867

Pulled By: uddipta

fbshipit-source-id: 857bdad56e10e875ab11843fb1d8268f5b75025e
    @ldemailly @facebook-github-bot
    ldemailly authored and facebook-github-bot committed Feb 27, 2017
    Configuration menu
    Copy the full SHA
    9a99a65 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2017

  1. update gflags 

    Reviewed By: yfeldblum

Differential Revision: D4646271

fbshipit-source-id: 5d21407e815588ae2b016001b859a4816851ab00
    @facebook-github-bot
    Igor Sugak authored and facebook-github-bot committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    84fd93c View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2017

  1. Receiver now sends periodic heart-beats to keep the sender waiting 

    Summary: WdtOptions.h has details

Reviewed By: nedelchev

Differential Revision: D4660004

fbshipit-source-id: e374e22235e1866a57d02d3944f63842bd05bfae
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    62be7c8 View commit details
    Browse the repository at this point in the history

  2. CodeMod: google::SetCommandLineOption to gflags::SetCommandLineOption 

    Summary:
CodeMod: `google::SetCommandLineOption` to `gflags::SetCommandLineOption`.

For gflags, `namespace google` is deprecated in favor of `namespace gflags`.

Automated with:

```lang=bash
hg grep -lw google::SetCommandLineOption | xargs perl -pi -e 's,\bgoogle(::SetCommandLineOption)\b,gflags\1,g'
```

Reviewed By: igorsugak, jsedgwick

Differential Revision: D4665863

fbshipit-source-id: 87c22b278370b41011e4da20e2d8e8d557ff187b
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    57b9da8 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2017

  1. use gflags namespace instead of google 

    Summary:
`google` namespace is deprecated in gflags. Replacing it with `gflags` namespace.

gflags was generated from this diff: P57170122
```
% echo $gflags
google::(RegisterFlagValidator|CommandLineFlagInfo|GetAllFlags|ShowUsageWithFlags|ShowUsageWithFlagsRestrict|\
DescribeOneFlag|SetArgv|GetArgvs|GetArgv|GetArgv0|GetArgvSum|ProgramInvocationName|ProgramInvocationShortName|\
ProgramUsage|VersionString|GetCommandLineOption|GetCommandLineFlagInfo|GetCommandLineFlagInfoOrDie|]
FlagSettingMode|SET_FLAGS_VALUE|SET_FLAG_IF_DEFAULT|SET_FLAGS_DEFAULT|SetCommandLineOption|\
SetCommandLineOptionWithMode|FlagSaver|CommandlineFlagsIntoString|ReadFlagsFromString|AppendFlagsIntoFile|\
ReadFromFlagsFile|BoolFromEnv|Int32FromEnv|Uint32FromEnv|Int64FromEnv|Uint64FromEnv|DoubleFromEnv|\
StringFromEnv|SetUsageMessage|SetVersionString|ParseCommandLineNonHelpFlags|HandleCommandLineHelpFlags|\
AllowCommandLineReparsing|ReparseCommandLineNonHelpFlags|ShutDownCommandLineFlags|FlagRegisterer)

% hg grep -wlE "$gflags" 're:fbcode.*\.(cc|cpp|h)' | xargs perl -pi -e 's,\bgoogle::,gflags::,g if /'"$gflags"'/'
```

Reviewed By: meyering

Differential Revision: D4669201

fbshipit-source-id: 8053ba6fba9acf6eaf6796f0f297a9e07784973f
    @facebook-github-bot
    Igor Sugak authored and facebook-github-bot committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    b25cd3f View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 67669fcca77edbccc4627a3ca816c01341036cf5
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    e5e4cf5 View commit details
    Browse the repository at this point in the history

  2. s,google::gflags_exitfunc,gflags::gflags_exitfunc, 

    Summary: `google::gflags_exitfunc` is an internal gflags function. It was missed in D4669201, that updated referenced only to API gflags symbols, and consequently broken by D4683944

Differential Revision: D4692251

fbshipit-source-id: daa1b236f2acb3ecd154191443da5620f99fda7e
    @facebook-github-bot
    Igor Sugak authored and facebook-github-bot committed Mar 10, 2017
    Configuration menu
    Copy the full SHA
    3bfcb50 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2017

  1. fix OSS build 

    Reviewed By: uddipta

Differential Revision: D4698362

fbshipit-source-id: ff25551b9ecce292e785ef1c01ee52b2b3d0f84b
    @facebook-github-bot
    Igor Sugak authored and facebook-github-bot committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    6a99d2b View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 1005511f029b1bad07cb9af16321800855354640
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    136fead View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2017

  1. Remove user override from wdt jobs 

    Summary: In the job script, the creator used his own unixname as the 'user'. This overrides the user field for diffs.

Reviewed By: ttsugriy, grzmiel

Differential Revision: D4707899

fbshipit-source-id: 7cf7b1f2527cc5eda18f0d96267b5b9799f3b3bc
    @facebook-github-bot
    Jeremy Sze Wei Teo authored and facebook-github-bot committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    bf46366 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: a7190d6fceb634120cf89925e4b8d9c25cb31a55
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    31d5485 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2017

  1. Fix wdt to call folly::Singleton's registrationComplete() 

    Reviewed By: uddipta

Differential Revision: D4725815

fbshipit-source-id: f734fe4ced70f5c92ea78bec7b9166c53aafeb29
    @andriigrynenko @facebook-github-bot
    andriigrynenko authored and facebook-github-bot committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    9d001ef View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2017

  1. change EXPECT_EQ(false, ... to EXPECT_FALSE(...; ditto for ASSERT_EQ 

    Summary:
Change every instance of EXPECT_EQ(false, ... to the simpler/shorter EXPECT_FALSE(...
Do the same for ASSERT_EQ, for consistency, and for true/TRUE.

Reviewed By: Orvid

Differential Revision: D4751397

fbshipit-source-id: 045293dbf8be1167f0cb1b85a2f9cd59a6a30f73
    @meyering @facebook-github-bot
    meyering authored and facebook-github-bot committed Mar 23, 2017
    Configuration menu
    Copy the full SHA
    91e06a6 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 1510ab83f568521830f24ece778fd7f00e8f0186
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    d888b3f View commit details
    Browse the repository at this point in the history

  2. Remove the extra space before the comment after RECURSIVE_GLOBs in TA… 

    …RGETS [4/4]

Summary:
It has bugged me for long enough. It's time to fix it.

```
codemod --start 75% --extensions '*' -m --exclude-paths _bin,_build,buck-out,third-party2,third-party-buck 'headers = AutoHeaders.RECURSIVE_GLOB,  # https://fburl.com/424819295' 'headers = AutoHeaders.RECURSIVE_GLOB, # https://fburl.com/424819295'
```

Reviewed By: yfeldblum

Differential Revision: D4774502

fbshipit-source-id: b174fdd40e8771331d532f2295da4f70e36cb63d
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    506bb5a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: f864cd23b71fea7c3192afb2cfaeee9db58bb574
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 26, 2017
    Configuration menu
    Copy the full SHA
    8fec055 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2017

  1. periodically changing encryption initialization vector 

    Summary:
We can not use the same iv for more than 64GB. Encryption updates failed for
long transfers. Found the issue during figtable testing.
So, we are changing the iv every 32GB. Sender periodically sends tags for
verification. After each such tag, we check whether we should change the iv or
not.

Reviewed By: nedelchev

Differential Revision: D4772960

fbshipit-source-id: 5dff6516fb33e84cc6db0378da6c7bbf228ec5f8
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    e38665d View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 9d8e5a51f856d272bb9124d4626f0ca6e39865ee
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 29, 2017
    Configuration menu
    Copy the full SHA
    6a0343c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2017

  1. wdt: switch protocol printing log to WVLOG(1) 

    Summary: #accept2ship

Reviewed By: uddipta

Differential Revision: D4791720

fbshipit-source-id: 4046a71c85ea1021a54c1aa2dcc18ac9dd71f255
    @luciang @facebook-github-bot
    luciang authored and facebook-github-bot committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    0130fe4 View commit details
    Browse the repository at this point in the history

  2. Ensuring that we don't print an error log while changing iv 

    Summary:
If we don't call finish on the decryptor before destroying it, an error msg gets
printed. So, always calling finish before destroying the decryptor.
Also, refactored the iv change code a bit.

Reviewed By: nedelchev

Differential Revision: D4797936

fbshipit-source-id: 72e46f294ae7d145ef256e7df6c16402f87b3c75
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Mar 30, 2017
    Configuration menu
    Copy the full SHA
    5a8bd9f View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2017

  1. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 6a3aedda2f7554863199fe3eedf5e4b707ffdffc
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Mar 31, 2017
    Configuration menu
    Copy the full SHA
    72b221f View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2017

  1. use googletest instead of gtest with gmock 

    Summary:
This updates all of the references to gtest and gmock with googletest.

The change is mechanilcal, generated with the following one-liner:
```lang=bash
hg grep -lwE '(gtest|gmock)' 'glob:**/TARGETS' | grep -v '^third-party-buck' | xargs perl -pi -e '
$gt=qr!(["'"'"'])gtest\g1!;
(
  s!$gt(\s*,\s*(.any.|None))(\s*,\s*)?\),?!\1googletest\1\2, \1gtest\1\),!g or
  s!$gt((\s*,\s*(.any.|None)[^\)]+))\),?!\1googletest\1\2\),!g or
  s!\(\s*$gt,?\s*\),?!\(\1googletest\1, None, \1gtest\1\),!g or
  s!$gt,?!\(\1googletest\1, None, \1gtest\1\),!g
) unless /(name|type) *=/;

$gm=qr!(["'"'"'])gmock\g1!;
(
  s!$gm(\s*,\s*(.any.|None))(\s*,\s*)?\),?!\1googletest\1\2, \1gmock\1\),!g or
  s!$gm((\s*,\s*(.any.|None)[^\)]+))\),?!\1googletest\1\2\),!g or
  s!\(\s*$gm,?\s*\),?!\(\1googletest\1, None, \1gmock\1\),!g or
  s!$gm,?!\(\1googletest\1, None, \1gmock\1\),!g
) unless /(name|type) *=/;
'
```

Reviewed By: meyering

Differential Revision: D4643237

fbshipit-source-id: fda7f41760c7e44254231df87634631c343e6355
    @facebook-github-bot
    Igor Sugak authored and facebook-github-bot committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    7077431 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2017

  1. Multiple msg-streams multiplexed over one persistent connection 

    Summary:
This should be useful for p2p continuous rocksdb replication.
I think we should not need more than one connection/socket between two hosts.
Right now, multiple streams can send msg over one connection. If there is no msg
sent for a while, a heart-beat is sent keep the connection alive.
There is no limit on the size of the msg.
TODOs -- better/more tests
This diff does not include thrift control channel and connection pool
management.

Reviewed By: nedelchev

Differential Revision: D4825774

fbshipit-source-id: b7c4167ad14efe6b47a47cc374d6b89a7aa23720
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Apr 11, 2017
    Configuration menu
    Copy the full SHA
    d781a61 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2017

  1. Add missing includes 

    Summary: These files were relying on these transitively, but the upstream includes are going away, so the includes need to be made explicit.

Reviewed By: yfeldblum

Differential Revision: D4888861

fbshipit-source-id: 8b49be032a4b53ed2976a7178daeff25551741a7
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Apr 14, 2017
    Configuration menu
    Copy the full SHA
    7f5c7e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2017

  1. Fix the OSS build due to upstream change in Folly 

    Summary:
When I added support for building folly without PThreads, I added a configuration define which WDT needs to pass.
WDT does not currently support building without PThreads, and there are no current plans to make it do so, so hard-code pthread support for now.

Reviewed By: uddipta, yfeldblum

Differential Revision: D4906993

fbshipit-source-id: 0050d3b82cc1fd7353c6892f88ab7da94877e5d4
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    1d1850c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2017

  1. Changes to run wdt test on a host with 30G of /dev/shm 

    Summary:
We used to run WDT continuous tests on a devserver with 256G of ram, so we had
128G of /dev/shm. But, now we will run it on a host with 60G of ram or 30G of
/dev/shm. Reducing the amount of data generated for each test, also reducing the
throttler speed.

(Note: this ignores all push blocking failures!)

Reviewed By: nedelchev

Differential Revision: D4911479

fbshipit-source-id: b3c43e1d11295b5f3cc689afe175109ef1d49737
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    b0be230 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2017

  1. Disabling some tests from wdt/stargate cont build 

    Summary:
WDT tests are timing dependent. Some of them are failing in our new cont build
machine. Disabling some low pri tests to make sure other tests pass.

(Note: this ignores all push blocking failures!)

Reviewed By: jjleng

Differential Revision: D4925109

fbshipit-source-id: 176ef8d31b85f55175bf8cf6ac3d024a438701a9
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Apr 20, 2017
    Configuration menu
    Copy the full SHA
    b0f80ea View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2017

  1. Enabling fadvise for removing data from page cache in disk mode 

    Summary: Enabling fadvise for removing data from page cache in disk mode

Differential Revision: D4959506

fbshipit-source-id: 85704f66d9b96d8b3792826711a53ca9014f45df
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    c5688ad View commit details
    Browse the repository at this point in the history

  2. wdt/stargate version bump 

    Summary: wdt/stargate version bump auto commit

fbshipit-source-id: 291570c82d3de77898c2e2f51c0704c5c9e918e5
    @facebook-github-bot
    svcscm@fb.com authored and facebook-github-bot committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    2c191b2 View commit details
    Browse the repository at this point in the history

  3. File permission transfer 

    Summary:
Implementation and test for keeping file permission during transfer v0.1

Design decision:
1. Get permission from the same st_mode that is used to get file size, and store permission in each metadata entry of DirectorySourceQueue, in order to avoid calling stat another time.
2. Default permission is 512 (01000). When perm in WdtFileInfo is default, library behavior is not changed.
Closes #155

Reviewed By: jjleng

Differential Revision: D4813356

Pulled By: uddipta

fbshipit-source-id: 588487f73d4a100ad0f8bd79272a65eb991aaea6
    @dliang36 @facebook-github-bot
    dliang36 authored and facebook-github-bot committed Apr 27, 2017
    Configuration menu
    Copy the full SHA
    3a5b195 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2017

  1. Fixing build failure due to unused variable 

    fbshipit-source-id: f1d1fe34aea596fea92614d9bbaa7aed1e22275d
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    d2e512f View commit details
    Browse the repository at this point in the history

Commits on May 2, 2017

  1. Switch the wdt-mac test to request an xcode sdk that actually has cap… 

    …acity

Summary: XCode SDK testing for lego-linux is a mess and this was requesting a capability that had 2 hosts, so was queuing for an absurdly long amount of time :(

Reviewed By: yfeldblum

Differential Revision: D4989867

fbshipit-source-id: a2a688b398df7076a6bd53d08dbc6a00121aaeac
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed May 2, 2017
    Configuration menu
    Copy the full SHA
    e60f749 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2017

  1. codemod: remove AutoHeaders.RECURSIVE_GLOBs which don't break build 

    Reviewed By: yfeldblum, meyering

Differential Revision: D5017789

fbshipit-source-id: 139e43d7640ed47552feafa25016946295225b7b
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed May 7, 2017
    Configuration menu
    Copy the full SHA
    325d668 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2017

  1. Add hardware crc impl 

    Summary:
A faster crc32 impl for folly.  Similar to crc32c, except
intel doesn't provide crc32 directly in hardware - instead, pclmul can be used,
which is ~2x slower than crc32c, but still ~5-10x faster than software implementation.

Reviewed By: Orvid, yfeldblum

Differential Revision: D4994761

fbshipit-source-id: ad8ba856649eea6dc7b541d561329ff7d7fe2d60
    @facebook-github-bot
    Dave Watson authored and facebook-github-bot committed May 8, 2017
    Configuration menu
    Copy the full SHA
    7659225 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2017

  1. Update macos travis 

    Summary:
7.1 (doesn’t exist on travis anymore) -> 8.3
Closes #157

Differential Revision: D5028914

Pulled By: uddipta

fbshipit-source-id: 99b73252785d0aacea427e10f3b7e411f435fc58
    @ldemailly @facebook-github-bot
    ldemailly authored and facebook-github-bot committed May 9, 2017
    Configuration menu
    Copy the full SHA
    c26110f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2017

  1. Revert D4813356: [wdt][PR] File permission transfer 

    Summary: This reverts commit 588487f73d4a100ad0f8bd79272a65eb991aaea6

Differential Revision: D4813356

fbshipit-source-id: ec993c8a1f3f2db4fdc820807c8500359f6055c2
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed May 17, 2017
    Configuration menu
    Copy the full SHA
    45c34c2 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2017

  1. buckification: add @nolint to TARGETS which can run buildifier 

    Summary: Prereq for deploying buildifier linter and codemodding existing TARGETS.

Reviewed By: bolinfest

Differential Revision: D5092478

fbshipit-source-id: 8cbb77b15487d46ea2b2aff01f20504d87846fe4
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed May 21, 2017
    Configuration menu
    Copy the full SHA
    0c9f89f View commit details
    Browse the repository at this point in the history

Commits on May 23, 2017

  1. Update to XCode 8.3.2 

    Summary: Because of mistakes made, there are no longer any XCode 8.3.1 hosts in the lego-mac tier, so jobs are queueing for 6 hours then timing out. This just bumps the version being requested to 8.3.2

Reviewed By: yfeldblum

Differential Revision: D5108379

fbshipit-source-id: d5ec36e61a888345954fc982d19b18ba49ce7209
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed May 23, 2017
    Configuration menu
    Copy the full SHA
    334c214 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2017

  1. codemod: replace headers = AutoHeaders.* with auto_headers 

    Reviewed By: meyering

Differential Revision: D5094332

fbshipit-source-id: 3df2f693def8ca418bc9febe3e20ccf051f2e19d
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed May 25, 2017
    Configuration menu
    Copy the full SHA
    a287ba6 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2017

  1. Fix OpenSSL 1.1.0 build break 

    Summary:
These callbacks are defined to null in 1.1.0, so comparing them with
null is redundant

Reviewed By: knekritz, uddipta

Differential Revision: D5136462

fbshipit-source-id: 8199e0f576f11d9e7cb899682a7ca764c7012143
    @anirudhvr @facebook-github-bot
    anirudhvr authored and facebook-github-bot committed May 28, 2017
    Configuration menu
    Copy the full SHA
    5a6ab9e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2017

  1. Fix FdTest 

    Summary:
`FdTest` is broken because it only relies on the reported
transfer status, which returns `OK` even if file discovery failed
(which will be fixed separately). Change the test to verify that a
file passed by fd is actually transferred even if it doesn't exist in
the filesystem.

Reviewed By: uddipta

Differential Revision: D5144952

fbshipit-source-id: 97ece300d8accb9d15ef962d45a04d464f940ddd
    @ot @facebook-github-bot
    ot authored and facebook-github-bot committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    8e897bf View commit details
    Browse the repository at this point in the history

  2. Do not crash in case of an invalid block header 

    Summary: Do not crash in case of an invalid block header

Reviewed By: nedelchev

Differential Revision: D5165256

fbshipit-source-id: ba06e4b852de76eb0f7487ef7e85a7df598660df
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    60bc32e View commit details
    Browse the repository at this point in the history

  3. Adding boost filesystem as a dependency in travis 

    Summary:
Adding boost filesystem as a dependency in travis. Build is failing after we
added this dependency.

Reviewed By: ot

Differential Revision: D5167517

fbshipit-source-id: feaa06c134d9114be67a4b659c62be1a5694947b
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    fc363f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. codemod: format TARGETS with buildifier [5/5] (D5092623) 

    Reviewed By: igorsugak

fbshipit-source-id: 906b744c179eb932f5a388b39f93209cecd50a80
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    0a3de2f View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2017

  1. Do not ignore errors in file discovery 

    Summary:
If the `stat` in `enqueueFiles` fails the error will be
ignored and the transfer reported as successful. Propagate instead
the error to the sender threads so that they can abort the transfer.

Reviewed By: uddipta

Differential Revision: D5145003

fbshipit-source-id: 9f0664b0319411b99874ed1613de56885cdb4575
    @ot @facebook-github-bot
    ot authored and facebook-github-bot committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    4cf2f2c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2017

  1. Rename @/folly:folly-sse42 to @/folly:checksum 

    Summary: To better reflect what it actually is.

Reviewed By: yfeldblum

Differential Revision: D5186774

fbshipit-source-id: c13b5f6c93c3764a28510d825faec0fb4232d1f2
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    a0bab52 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2017

  1. Don't reference folly:subbase from within Folly 

    Summary:
Stop pulling in a lot of Folly just for a single header or to.

There are now no remaining references to `@/folly:folly`, `@/folly:base`, or `@/folly:subbase` within Folly itself.

Reviewed By: yfeldblum, mzlee

Differential Revision: D5188157

fbshipit-source-id: da7ea3032dd18a0108b2602ac23d8e92246b9f37
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    e1678a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2017

  1. apply clang-tidy modernize-use-override 

    Summary: Use clang-tidy to mechanically add missing `override` and remove redundant `virtual`.

Reviewed By: igorsugak

Differential Revision: D5211868

fbshipit-source-id: 15cec17d39690ffa8072ffeccdf9fedaae1f6839
    @vgao1996 @facebook-github-bot
    vgao1996 authored and facebook-github-bot committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    e4b0087 View commit details
    Browse the repository at this point in the history

  2. apply clang-tidy modernize-use-override 

    Summary: Use clang-tidy to mechanically add missing `override` and remove redundant `virtual`.

Reviewed By: igorsugak

Differential Revision: D5211868

fbshipit-source-id: 4118c4c72f8ec3485507f69679f7e852b3eaeb73
    @vgao1996 @facebook-github-bot
    vgao1996 authored and facebook-github-bot committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    32a7fec View commit details
    Browse the repository at this point in the history

  3. apply clang-tidy modernize-use-override 

    Summary: Use clang-tidy to mechanically add missing `override` and remove redundant `virtual`.

Reviewed By: igorsugak

Differential Revision: D5211868

fbshipit-source-id: 6a85f7c4a543a4c9345ec5b0681a8853707343dc
    @vgao1996 @facebook-github-bot
    vgao1996 authored and facebook-github-bot committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    8bdf0d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. Another mac travis fix 

    Summary:
And instructions for using it outside of travis
Closes #158

Differential Revision: D5247190

Pulled By: uddipta

fbshipit-source-id: 0f1189f44ae701c3c6782f1f9dae3269c6e15bb6
    @ldemailly @facebook-github-bot
    ldemailly authored and facebook-github-bot committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    6db7b28 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2017

  1. Rename the RWSpinLock target to comply with folly conventions 

    Summary: Which perscribe that acronyms don't get indivual underscores separating the invidivual letters.

Reviewed By: yfeldblum

Differential Revision: D5318897

fbshipit-source-id: 3ea218c4ac98367c4aef8f3b2340423045c26900
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    e21b238 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2017

  1. ensure that data is written to disk, and proper IO error handling 

    Summary:
there are currently multiple issues in wdt FileWriter that this diff aims to fix:
1/ By default data is not synced to disk at the end of the transfer. This diff ensures that files are always synced to disk
2/ IO errors were almost always silent and would rarely cancel the file transfer. This diff ensures that all IO calls are checked for errors and we fail the transfer on any error.

For some context, zippydb has seen a very high number of corrupted files in the past few months, leading to repeated SEVs and data loss. So far our investigation leads us to think that wdt writer is the culprit here as it doesn't fail the transfer in case of IO errors, which leads to corrupted data on the receiver. I'll try to confirm that by stress testing wdt transfers on a faulty host, with and without this diff.

Reviewed By: uddipta

Differential Revision: D5273341

fbshipit-source-id: 9b906196671058c02effc69751cbe7d454ac7d5a
    @benrnd @facebook-github-bot
    benrnd authored and facebook-github-bot committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    5fcbe68 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2017

  1. Adding missing stat collector for fsync 

    Summary: #title

Reviewed By: benrnd

Differential Revision: D5377036

fbshipit-source-id: 59bd8872da81dd1948377e87dd6a9c1465a25233
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    29b2e7e View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2017

  1. Improve stats 

    Summary:
And corresponding test
Closes #161

Differential Revision: D5381805

Pulled By: uddipta

fbshipit-source-id: 78b57f891a1da295c7ce8086572ded4504eef4c7
    @ldemailly @facebook-github-bot
    ldemailly authored and facebook-github-bot committed Jul 8, 2017
    Configuration menu
    Copy the full SHA
    1c8f0c1 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2017

  1. Receiver now gives up while waiting for sender to start after some ti… 

    …meout

Summary:
Receiver now gives up while waiting for sender to start after some timeout.
This makes sure that bad host can not block other hosts in the same tier.

Reviewed By: ThomasFersch

Differential Revision: D5412766

fbshipit-source-id: b857369572fa6e44079da2399b2d7714d3cd6423
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Jul 15, 2017
    Configuration menu
    Copy the full SHA
    32c019d View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. 3-way crc32c 

    Summary: Current folly version uses a single crc32c.  crc32c has a latency of 3, so pipelining three in a row makes it nearly 3x faster (for data all in cache).

Reviewed By: yfeldblum

Differential Revision: D5418228

fbshipit-source-id: d3a250e1b4fe1f0bc99b44c660df94cf233aebd6
    @facebook-github-bot
    Dave Watson authored and facebook-github-bot committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    048d26e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2017

  1. comment out unused parameters 

    Summary: This uses `clang-tidy` to comment out unused parameters (in functions, methods and lambdas) in fbcode. Cases that the tool failed to handle are fixed manually.

Reviewed By: igorsugak

Differential Revision: D5454343

fbshipit-source-id: 5dee339b4334e25e963891b519a5aa81fbf627b2
    @vgao1996 @facebook-github-bot
    vgao1996 authored and facebook-github-bot committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    93c4599 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. Add a helper defs for os.getenv() 

    Summary: And use it to make a number of `TARGETS` files formattable.

Reviewed By: yfeldblum

Differential Revision: D5548287

fbshipit-source-id: 7e393920eac6d78c1106fd2f8e481e5483b85471
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    65c9bd6 View commit details
    Browse the repository at this point in the history

  2. Format newly formattable TARGETS after D5548287 

    Summary: After D5548287 these targets files can now be formatted, so do so.

Reviewed By: yfeldblum

Differential Revision: D5548330

fbshipit-source-id: dd7777f56ee694818e4d4c0825f8a2ca1b77368c
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    82dd567 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2017

  1. Adding rate limiters for zippy read/write calls 

    Summary:
Adding rate limiters for zippy read/write calls.
Reusing wdt throttler and adding a wrapper around it. Wdt throttler is thread
safe and fair (threads working at similar speed gets same amount of slots).
Throttler speeds can be changed dynamically through configerator.

Differential Revision: D5582254

fbshipit-source-id: 66df2a226ac22ca40a2974bcb46f231dc537aa32
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    87b03e2 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2017

  1. Remove explicit XCode SDK versions from legocastle jobs 

    Summary:
Once upon a time there was a lonely hhvm-mac job. It was running merrily through the lego-mac tier. Then someone came and added more hosts to the tier, but something was wrong! They were missing any form of xcode SDK at all! Any job that tried to run in the tier and ended up running on those new hosts failed. Why? Because the jobs were expecting XCode to be present, but it wasn't. To workaround this, an explicit request for xcode was added to the capability list of hhvm-mac. Over time more lego-mac jobs were added, and some gained explicit xcode specifications as well.

The time is long past where explicit version requests for xcode sdks is needed, so let's just remove them. If something starts failing because it's trying to build against `beta`, great, that's useful signal that things are going to break when `beta` becomes mainstream.

Reviewed By: yfeldblum

Differential Revision: D5627221

fbshipit-source-id: c61e359bf44a489f8fc365d78b521c9e2c97ca5e
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    019cfa9 View commit details
    Browse the repository at this point in the history

  2. Shift folly:thread_local out of folly:base 

    Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly:thread_local
```

Reviewed By: yfeldblum

Differential Revision: D5715635

fbshipit-source-id: b1e770e59de7406aa2a2f669ce974b8d87ccc1a5
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    27841b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2017

  1. Shift folly:synchronized out of folly:folly 

    Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly:synchronized
```

Reviewed By: yfeldblum

Differential Revision: D5802850

fbshipit-source-id: 7587e6352953879ed193b4931617db7028f730b1
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    a6ed1cd View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2017

  1. fix -Wtautological-unsigned-enum-zero-compare 

    Summary:
Exposed by the latest clang:
```lang=bash
wdt/ErrorCodes.cpp:19:12: error: comparison of unsigned enum expression >= 0 is always true [-Werror,-Wtautological-unsigned-enum-zero-compare]
  if (code >= 0 && code < numErrorCodes) {
      ~~~~ ^  ~
wdt/util/EncryptionUtils.cpp:38:22: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
  if (encryptionType < 0 || encryptionType >= NUM_ENC_TYPES) {
      ~~~~~~~~~~~~~~ ^ ~
wdt/util/EncryptionUtils.cpp:120:13: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
  if (type_ < 0 || type_ >= NUM_ENC_TYPES) {
      ~~~~~ ^ ~
stderr: wdt/util/EncryptionUtils.cpp:38:22: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
  if (encryptionType < 0 || encryptionType >= NUM_ENC_TYPES) {
      ~~~~~~~~~~~~~~ ^ ~
wdt/util/EncryptionUtils.cpp:120:13: error: comparison of unsigned enum expression < 0 is always false [-Werror,-Wtautological-unsigned-enum-zero-compare]
  if (type_ < 0 || type_ >= NUM_ENC_TYPES) {
      ~~~~~ ^ ~
```

Reviewed By: meyering

Differential Revision: D5978670

fbshipit-source-id: 4b00aa3d7da2e7a6e0846bb534e6afcc7875946a
    @facebook-github-bot
    Igor Sugak authored and facebook-github-bot committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    db1fb8d View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2017

  1. Add missing deps for boost, gflags, and sparsehash 

    Summary: Ensure external_deps are specified where needed for boost, gflags, and sparsehash

Reviewed By: igorsugak

Differential Revision: D6015078

fbshipit-source-id: adfc8a327b7c10a9aa7c8632f1c3deff6781748a
    @facebook-github-bot
    Keith Birney authored and facebook-github-bot committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    866ad72 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. Move folly/Checksum.h into folly/hash/ 

    Summary: [Folly] Move `folly/Checksum.h` into `folly/hash/`.

Reviewed By: Orvid

Differential Revision: D6045825

fbshipit-source-id: 02d3e6a49e2c0fc115cfee09e1186be7a13525ba
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    56e5118 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Make Range.h and FBString.h mutually independent 

    Summary:
[Folly] Make `Range.h` and `FBString.h` mutually independent.

This means that `Range` cannot directly know about `fbstring`, so any interactions between the two types must be indirected through templates.

Motivation: `FBString.h` is a relatively heaviweight `#include` for things that need `Range.h` but which do not use `fbstring`.

Reviewed By: ericniebler

Differential Revision: D6062434

fbshipit-source-id: e2f21c33f482eadffd0a8679eff4ece59bab53e9
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Oct 17, 2017
    Configuration menu
    Copy the full SHA
    03936d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. move Arena, ThreadCachedArena, and Malloc to memory/ 

    Summary: all memory/-destined components besides hphp includes

Reviewed By: yfeldblum, mzlee

Differential Revision: D6121822

fbshipit-source-id: 6c6214d84dcdefe4789ed5200399ae27203d6340
    @facebook-github-bot
    James Sedgwick authored and facebook-github-bot committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    4ed6033 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2017

  1. Outline most throw expressions in Expected 

    Summary:
[Folly] Outline most `throw` expressions in `Expected`.

They are definitionally cold, but in-line `throw` statements can expand code size more than is desirable.

* Inline `throw` statement: https://godbolt.org/g/LPaf7V.
* Outline `throw` statement: https://godbolt.org/g/HZBXn6.

Reviewed By: Orvid

Differential Revision: D6183613

fbshipit-source-id: 28240bb4aa40790d99da783a3c368db81fded124
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Oct 31, 2017
    Configuration menu
    Copy the full SHA
    095b8a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2017

  1. Actually mark Unexpected as cold 

    Summary:
Testing indicates that GCC ignores the cold attribute when the function
is available for inlining. Because Unexpected is a template class we
can't make the constructors non-inline, but we can make it derive from a
class with a cold constructor, which has the effect of making all the
Unexpected constructors implicitly cold.

Reviewed By: yfeldblum

Differential Revision: D6261013

fbshipit-source-id: 482e49253d5b104742018133c53fb60279dd9f9b
    @WillerZ @facebook-github-bot
    WillerZ authored and facebook-github-bot committed Nov 9, 2017
    Configuration menu
    Copy the full SHA
    64aa710 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2017

  1. Increase wdt transfer id max length 

    Summary:
50 was small for some of existing shards. Bumping it to 1k. Beyond
that, linux won't allow to create directories anyway.

Reviewed By: uddipta

Differential Revision: D6303598

fbshipit-source-id: e9d8d4106eaddf2c36361ed9b1ac975ae4d5b7ed
    @prateek1404 @facebook-github-bot
    prateek1404 authored and facebook-github-bot committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    3eedb69 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Fix stale snapshot release codepath crash 

    Summary:
Snapshots were released before senders. Code to release snapshot kicks
in at some point and expects the snapshot to be there. Disconnect exists
because sender and receiver can have different number of store locations during
jbod migration.

Reviewed By: uddipta

Differential Revision: D6383209

fbshipit-source-id: 00ad5edec7d0bddaaeb98a2dc4b5dda8d38b0ba6
    @usumeet @facebook-github-bot
    usumeet authored and facebook-github-bot committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    24a660d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2017

  1. Shift folly:atomic_hash_map, folly:logging, and folly:spin_lock out o… 

    …f folly:folly and folly:base

Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly:atomic_hash_map
```

Reviewed By: yfeldblum

Differential Revision: D6409078

fbshipit-source-id: 2f72d617dd7d4b2d3adba8e81301dc78d5275f6d
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Nov 25, 2017
    Configuration menu
    Copy the full SHA
    668cd0e View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2017

  1. Shift folly:conv out of folly:base 

    Summary:
This is the single most included target in Folly, and also among the least directly referenced >_>...
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly:conv
```

Reviewed By: yfeldblum

Differential Revision: D6411299

fbshipit-source-id: 40ca1b62e9f456186c88d63adab0e6e34dded7ae
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    bf475f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Shift folly:string out of folly:base 

    Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly:string
```

Reviewed By: yfeldblum

Differential Revision: D6411357

fbshipit-source-id: 97afac97e8c1bfb15af5a53fadfb8d6a098a0d37
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    c37a30c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2017

  1. Remove the os_getenv for the test setup 

    Summary: Noticed os_getenv. These should probably be deleted as getting input from the environment is not a great idea.

Reviewed By: zertosh, ttsugriy

Differential Revision: D6427339

fbshipit-source-id: 5bd3b79da8f4882652141a525d0dc2926844ace1
    @mzlee @facebook-github-bot
    mzlee authored and facebook-github-bot committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    89dffe9 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Shift folly:memory out of folly:base 

    Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly:memory
```

Reviewed By: yfeldblum

Differential Revision: D6456837

fbshipit-source-id: 197d6d697dd24c26a23aab4a3a9d20ded7549537
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    540f582 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Move folly/Bits.h to folly/lang/ 

    Summary: [Folly] Move `folly/Bits.h` to `folly/lang/`.

Reviewed By: phoad, Orvid

Differential Revision: D6495547

fbshipit-source-id: a93159321df8277f8a4b4f10a5e4e0fc58cb6022
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    3a2b12c View commit details
    Browse the repository at this point in the history

  2. WDT: Fixing an issue with error processing that may lead to assert 

    Summary: A legit error status gets overwritten by a shady "error recovery" code. This causes an assert when the sent bytes count mismatch is found. With the fix, the error recovery is bypassed if the byte count check fails. Also, the assert has been removed to avoid crashing a process due to a transient error. (The caller should check the error status and proceed accordingly.)

Reviewed By: nedelchev

Differential Revision: D6517387

fbshipit-source-id: ff47671bcc76eb92a5d4c4c7ee5d86a22733615c
    @facebook-github-bot
    Eugene Pekurovsky authored and facebook-github-bot committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    eab39c5 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2017

  1. Shift folly:executor, folly/lang:bits, folly:scope_guard and folly:rw… 

    …_spin_lock out of folly:base

Summary:
```
foundation/depenendency_management/ensure-explicit-dependencies.sh folly:executor
foundation/depenendency_management/ensure-explicit-dependencies.sh folly:bits
foundation/depenendency_management/ensure-explicit-dependencies.sh folly/lang:bits
foundation/depenendency_management/ensure-explicit-dependencies.sh folly:scope_guard
foundation/depenendency_management/ensure-explicit-dependencies.sh folly:rw_spin_lock
```

Reviewed By: yfeldblum

Differential Revision: D6529842

fbshipit-source-id: fc13ef398402a0323ce4f6cf61d12b30c196ce43
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    e94e6d1 View commit details
    Browse the repository at this point in the history

  2. Shift folly:range out of folly:base 

    Summary: And then there were... 2.

Reviewed By: yfeldblum

Differential Revision: D6469788

fbshipit-source-id: 8a2d2f01f2d1fdbac05922701ba60c494061c8b9
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Dec 10, 2017
    Configuration menu
    Copy the full SHA
    db2860a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2017

  1. Uniformize the references to the glog external dependency 

    Summary:
Also adds more broken targets files to the filter helper.
```
foundation/dependency_management/uniformize-third-party-dependency.sh glog glog
```

Reviewed By: yfeldblum

Differential Revision: D6574545

fbshipit-source-id: 697c253f6fbd2be2cdcaf4d1c20b635cd907bc72
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    a80fefb View commit details
    Browse the repository at this point in the history

  2. Ensure explicit dependency on glog 

    Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh -e 'glog' glog/logging.h
```

Reviewed By: yfeldblum

Differential Revision: D6577184

fbshipit-source-id: 53aec2ba7f15976c3294846e7e46543dfc65c2cf
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    4efd310 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2017

  1. Migrate TARGETS files from @/ to // 

    Summary:
This is a codemod to change from using @/ to // in basic cases.
- TARGETS files with lines starting with @/ (but excluding @/third-party:
- autodeps lines in source and TARGETS files ( (dep|manual)=@/ ), excluding @/third-party
- Targets in string macros

The only thing left of the old format should be @/third-party:foo:bar

drop-conflicts

Reviewed By: ttsugriy

Differential Revision: D6605856

fbshipit-source-id: cbb737f9d5d6dc76cd6e972a088a2a183aea62fb
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    e12fea7 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2018

  1. Move folly/RWSpinLock.h to folly/synchronization/ 

    Summary: [Folly] Move `folly/RWSpinLock.h` to `folly/synchronization/`.

Reviewed By: elsteveogrande

Differential Revision: D6659265

fbshipit-source-id: 307723e22f42ceb104f26657aed8b34f7e183afb
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    096f308 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. Let Futex import base-class ctors 

    Summary:
[Folly] Let `Futex` import base-class ctors.

Rather than needing to define ctors and inherit `boost::noncopyable`.

Reviewed By: WillerZ

Differential Revision: D6674054

fbshipit-source-id: 59e0a4815682b227346954fe47c6eda49e3ad62f
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    569434b View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2018

  1. Suppress lint in old files 

    Summary:
ACTION ITEM:
1. Best option: take the time to actually fix this stuff or delete the files. Preferrably, accept this and do so after this diff lands.
2. Second best option: if you want clean arc lint and a healthier ecosystem and the tests pass (and exist!), accept this diff.
3. Annnnd: if you don't have tests and can't take the risk (it is possible in some very very rare cases for the generator to make mistakes), reject this, and forever live with lint excuses

What's going on:

We recently made it so that lint that is at the error severity level (higher than advice/warnings) blocks a "clean" land in fbcode, disabling delayed lands. This is part of an effort to get lint to a managable state where what's still being reported actually matters. This diff adds a permanent lint suppression to files that were last touched prior to 2017, that way lint will just ignore these issues and carry on; no need for a lint excuse at diff time. We're grandfathering this stuff in so we can pay more attention to what's new/in active use. This will also let us better track which issues are out there and hopefully codemod them away someday or just ignore noisy issues across the board. This will also help other codemodders who invariably touch all parts of the codebase and have no interest in fixing your lint. Note that the error severity level is the stuff that shows up any time you touch the file, regardless of whether or not you touched the relevant lines, making errors particularly annoying.

This diff is generated by running hg status -mancu fbcode/ --print0 | xargs -0 -n 50 "/var/www/scripts/bin/phps" AddLintSuppressions.

Most of these diffs will be dominated by Python's flake8 and shellcheck. We are actively working with Python Foundation on this problem to address lint health for the long-term.

Reviewed By: yfeldblum

Differential Revision: D6827286

fbshipit-source-id: d2a1566c8e5d6d5bd4e01d8c9f2bab23f1fefc00
    @markisaa @facebook-github-bot
    markisaa authored and facebook-github-bot committed Jan 29, 2018
    Configuration menu
    Copy the full SHA
    980552d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Cut folly/portability/BitsFunctexcept.h 

    Summary: [Folly] Cut `folly/portability/BitsFunctexcept.h`.

Reviewed By: simpkins

Differential Revision: D7066504

fbshipit-source-id: ed260ab36759a58dee103addd92c6a5a47dac330
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    9622317 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. Cut build config items for bits/functexcept.h 

    Summary:
[Folly] Cut build config items for `bits/functexcept.h`.

Folly no longer uses the non-portable functions declared in that internal libstdc++ header.

Reviewed By: mzlee

Differential Revision: D7119064

fbshipit-source-id: 6879dc6a5bc490726b188d65d7686a2eca136980
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    c450852 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2018

  1. Set priority of various legocastle jobs to match SandcastleFBCodeUtil… 

    …s::getSuggestedChildPriority

Summary:
Part of the fallout of the fbcode queue SEV was that misprioritized diff time jobs led to even longer queue times than were necessary. This moves diff time jobs to be in alignment with the standard over in www, `SandcastleFBCodeUtils::getSuggestedChildPriority`. See comments for more context:
diffusion/E/browse/tfb/trunk/www/flib/intern/sandcastle/fbcode/SandcastleFBCodeUtils.php;3828124$450-458

Reviewed By: Ben0mega

Differential Revision: D7697364

fbshipit-source-id: feb820e2d472965a6468e3f6500ea48e67da55e2
    @markisaa @facebook-github-bot
    markisaa authored and facebook-github-bot committed Apr 21, 2018
    Configuration menu
    Copy the full SHA
    64d2b9b View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2018

  1. Shift all but the headers dependency out of common/stats:stats 

    Summary: This will allow the eventual removal of the `common/stats:stats` target entirely.

Reviewed By: yfeldblum

Differential Revision: D7598239

fbshipit-source-id: be72015eead6cd4dcae52429889da5a15c809ba9
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    fc5a018 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2018

  1. buck macros: remove output_subdir parameter 

    Summary: This parameter was only supported for fbbuild.

Reviewed By: yfeldblum

Differential Revision: D8246482

fbshipit-source-id: 95db878a34dce5694639364f2838bb4cccd723d3
    @andrewjcg @facebook-github-bot
    andrewjcg authored and facebook-github-bot committed Jun 2, 2018
    Configuration menu
    Copy the full SHA
    e868568 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2018

  1. Fix cmake build: folly/Expected.cpp no longer exists 

    Summary: [WDT] Fix cmake build: `folly/Expected.cpp` no longer exists.

Reviewed By: andrewjcg

Differential Revision: D8345134

fbshipit-source-id: 752a0912e905c061dd384d64d486981559ec4de8
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Jun 10, 2018
    Configuration menu
    Copy the full SHA
    0979ac9 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2018

  1. Remove common/stats:stats and common/stats:headers 

    Summary: The splitup of `common/stats:stats` is complete, and everything is now referencing the split targets. Time to remove the old ones.

Reviewed By: yfeldblum

Differential Revision: D8346619

fbshipit-source-id: 6e10be990d5f6c4fb00cc6153ae8dffc54c559d4
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    558c604 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. dscp support 

    Summary: (draft) of dscp suppose

Reviewed By: uddipta

Differential Revision: D8036978

fbshipit-source-id: b9dd00faad27138faef99a936e2f0f1446461222
    @facebook-github-bot
    Mikhail Antonov authored and facebook-github-bot committed Jun 13, 2018
    Configuration menu
    Copy the full SHA
    7f6f8d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Remove def from TARGETS in wdt 

    Summary:
As part of our migration to skylark, we must remove any skylark incompatible constructs.
One of these constructs is having function definitions in build files (rather than .bzl files)
These series of diffs seek to eliminate the definition by either moving to a sibling :defs.bzl file, removing unneeded functions, or other various methods

Reviewed By: yfeldblum

Differential Revision: D9140738

fbshipit-source-id: 9c6cfe0bb3abdd73429c5773ca814f0e804b7a3c
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    1cf1b9d View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2018

  1. Replace FOLLY_HAVE_BITS_CXXCONFIG_H with __has_include 

    Summary:
[Folly] Replace `FOLLY_HAVE_BITS_CXXCONFIG_H` with `__has_include`.

Now that folly only targets which support `__has_include`.

Reviewed By: Orvid

Differential Revision: D9280942

fbshipit-source-id: cd843b4e903b2c96d3a40611f2274572b8b0600a
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    45aedce View commit details
    Browse the repository at this point in the history

  2. Replace FOLLY_HAVE_MALLOC_H with __has_include 

    Summary:
[Folly] Replace `FOLLY_HAVE_MALLOC_H` with `__has_include`.

Now that folly only targets which support `__has_include`.

Reviewed By: Orvid

Differential Revision: D9281875

fbshipit-source-id: eb895f3e034e4a4d3c9eb34fb73d47893e59f5ef
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    49d9d62 View commit details
    Browse the repository at this point in the history

  3. Replace FOLLY_HAVE_FEATURES_H with __has_include 

    Summary:
[Folly] Replace `FOLLY_HAVE_FEATURES_H` with `__has_include`.

Now that folly only targets which support `__has_include`.

Reviewed By: simpkins

Differential Revision: D9281991

fbshipit-source-id: 2e263681df5a980220fc133e8ac0495f229f6084
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    7016464 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. crc32_combine 

    Summary: Adds a crc32_combine function to folly (and crc32c hardware)

Reviewed By: yfeldblum

Differential Revision: D7687302

fbshipit-source-id: 86393c54776fa63ecfb34e9a589256e92505eeae
    @facebook-github-bot
    Dave Watson authored and facebook-github-bot committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    349f3ce View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Explicitly import AutoHeaders 

    Summary: Make build files require an explicit AutoHeaders import, remove it from the global export

Reviewed By: WillerZ

Differential Revision: D9475176

fbshipit-source-id: 5c3806b37645e5f7410bb0fb21d6e46ae3fc607f
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    c62f644 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2018

  1. Lint TARGETS files with buildifier 

    Summary: Build file formatting

Reviewed By: mzlee

Differential Revision: D9728238

fbshipit-source-id: 99a266d5d2260eabfd63a200b2994c6850b59cf4
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    c3cd00b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2018

  1. Format bzl files with new buildifier 

    Summary: Build file formatting

Reviewed By: ttsugriy

Differential Revision: D9763531

fbshipit-source-id: f20b5e60df15f28dfed121cf6483f885895d5509
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Sep 12, 2018
    Configuration menu
    Copy the full SHA
    d493bc2 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Ensure explicit dependency on folly/io/async:async_base 

    Summary:
```
foundation/dependency_management/ensure-explicit-dependencies.sh folly/io/async:async_base
```

Reviewed By: yfeldblum

Differential Revision: D9892601

fbshipit-source-id: 525c9a08d16402776bb68921d85e76095f6df19c
    @Orvid @facebook-github-bot
    Orvid authored and facebook-github-bot committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    1f43a96 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Buildify build files. 

    Reviewed By: philipjameson

Differential Revision: D13356953

fbshipit-source-id: 3e2121277b5ab46e898f7d1bb41dbfc9d5f163b1
    @ttsugriy @facebook-github-bot
    ttsugriy authored and facebook-github-bot committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    4d06e17 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. Buildify build files. 

    Summary:
This is to avoid spurious lint warnings for unrelated
changes.

drop-conflicts

Reviewed By: philipjameson

Differential Revision: D13356938

fbshipit-source-id: 94af0a7231d23243515b88bbf864ef7dac56f300
    @ttsugriy @facebook-github-bot
    ttsugriy authored and facebook-github-bot committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    a288ed7 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Add TLS support to WDT 

    Summary:
- Adds support to use TLS for data transfer
- TLS can be enabled using --tls option available on fbonly version
  of wdt(wdt_fb)

Reviewed By: uddipta

Differential Revision: D9721459

fbshipit-source-id: 8e1dd71e6eedf68fedabea6e3aaa33ba5de123db
    @sls-fb @facebook-github-bot
    sls-fb authored and facebook-github-bot committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    99eea2f View commit details
    Browse the repository at this point in the history

  2. Expose TLS option via wdt url 

    Summary:
This change implements following:
1. Expose the TLS option through wdt url. This will allow the receiver
   side to dictate when TLS should be used.
2. Add API to set/reset TLS option. This option is currently a no-op
   for the opensource version of wdt.

Reviewed By: uddipta

Differential Revision: D13576248

fbshipit-source-id: c080f0746c3753421b424c0ef99695983ceb0232
    @sls-fb @facebook-github-bot
    sls-fb authored and facebook-github-bot committed Jan 14, 2019
    Configuration menu
    Copy the full SHA
    687c1e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. TLS socket bug fix and client change necessary for integration 

    Summary:
SSLClientSocket::connect can fail without the errno being set to some non-zero value. In that case, we were failing with an assert P60821147. To fix that, we no longer depend on errno.

Also, added support to enable tls through WdtClient api. It gives us an option to override tls values specified in WdtOptions, and needed for wormhole integration.

Differential Revision: D13676677

fbshipit-source-id: 59755dd630ed8586f5ad2a6f8d3fc6cbe2f183ee
    @uddipta @facebook-github-bot
    uddipta authored and facebook-github-bot committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    eff877d View commit details
    Browse the repository at this point in the history

  2. s/fwdproxy.any/fwdproxy/g in fbsource 

    Summary: codemod with 'Yes to all': s/fwdproxy.any/fwdproxy/g in fbsource

Reviewed By: nxsy

Differential Revision: D13666378

fbshipit-source-id: 4b033562eba7d333904de4f972f1aeb88613b2f4
    @kyl191 @facebook-github-bot
    kyl191 authored and facebook-github-bot committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    4c0f450 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. Fetch the correct fd while returning error from ClientSocket::connect() 

    Reviewed By: uddipta

Differential Revision: D13743420

fbshipit-source-id: ff5c44ba4a354db2acc54215b3b578e1fc6b5465
    @sls-fb @facebook-github-bot
    sls-fb authored and facebook-github-bot committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    54c46bb View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. wdt: add '@logview-trait(ignore_task;1)' to mark frequent information… 

    …al logger as ignorable

Reviewed By: uddipta

Differential Revision: D13771196

fbshipit-source-id: 241b164e839073f814d1a65ae3fd62ab64c8785a
    @luciang @facebook-github-bot
    luciang authored and facebook-github-bot committed Jan 22, 2019
    Configuration menu
    Copy the full SHA
    dd0e6b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Add load() statements to bzl files 

    Reviewed By: luciang

Differential Revision: D13734597

fbshipit-source-id: f27e035af94b906ce919d226114ddb4f7ae91d5a
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    dbed61f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Add load() statements to TARGETS files 

    Reviewed By: styurin

Differential Revision: D13734474

fbshipit-source-id: 427723e7888c6fcd33c8e198d9bcd868ab0aa913
    @nataliejameson @facebook-github-bot
    nataliejameson authored and facebook-github-bot committed Jan 25, 2019
    Configuration menu
    Copy the full SHA
    61b9ccb View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Adding support to plug custom throttler in WDT. 

    Summary:
Noticed that default throttler in WDT lib isn't working as expected in some use cases. We have a scenario where we download several snapshots across different clients at once and default throttler keeps on reseting limits on each new sender/receiver thread.

Current approach requires custom throttler to inherit from Throttler class but better approach should be to expose a pure abstract class. I've introduced one but not using at all of the places. Thoughts?

Reviewed By: ami17

Differential Revision: D13844254

fbshipit-source-id: 5a3bf2c96b6a33a25524f939e06e040875c5f3cc
    @facebook-github-bot
    Atul Goyal authored and facebook-github-bot committed Feb 1, 2019
    Configuration menu
    Copy the full SHA
    072af3b View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2019

  1. Bump minor version 

    Reviewed By: uddipta

Differential Revision: D14287299

fbshipit-source-id: ad99256a83a15061145090f0851c8d8e44e51b91
    @sls-fb @facebook-github-bot
    sls-fb authored and facebook-github-bot committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    603f988 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2019

  1. Adding gflag to disable WDT logging. 

    Summary: Our logs and eventually logview are getting DOS'd with WDT logs. This change adds gflag to disable logging.

Reviewed By: uddipta

Differential Revision: D14417105

fbshipit-source-id: d3754cd36af4785965341e16fe7a76a772dbc24e
    @facebook-github-bot
    Atul Goyal authored and facebook-github-bot committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    bc22626 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. open source HistogramExporter 

    Summary: Move HistogramExporter into the open source fb303 repo.

Reviewed By: simpkins

Differential Revision: D15331361

fbshipit-source-id: 833e9256e29b8d5a1c04101ae9019849523bda4a
    @chadaustin @facebook-github-bot
    chadaustin authored and facebook-github-bot committed May 24, 2019
    Configuration menu
    Copy the full SHA
    3936ac4 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Adding Code of Conduct file (#187) 

    Summary:
This is pull request was created automatically because we noticed your project was missing a Code of Conduct file.

Code of Conduct files facilitate respectful and constructive communities by establishing expected behaviors for project contributors.

This PR was crafted with love by Facebook's Open Source Team.
Pull Request resolved: #187

Differential Revision: D15524109

Pulled By: uddipta

fbshipit-source-id: a8735c8d347efaf91d7c37e7ea93a2fde15dbac9
    @facebook-github-bot
    facebook-github-bot committed May 28, 2019
    Configuration menu
    Copy the full SHA
    8cb7576 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Account for ntp time adjustment in wdt stats 

    Summary:
The wdt progress reporting path checks that time spent is non-negative for a given step but the stats collection part doesn't account for it.

The source of the problem might be some other path or issue but checking for time underflow is safe to add in any case.

Differential Revision: D15602928

fbshipit-source-id: 85f283fbd7d197713f14ec955d2b6501ef8c8af7
    @facebook-github-bot
    Nitin Garg authored and facebook-github-bot committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    63d1571 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. fix sender progress reporting interval 

    Summary:
Should not be using `WdtBase::options_` directly in ctor, as those are
just default values, and parent's options are applied after sender is created
(`sender->setWdtOptions(parent_->getOptions())`).

Reviewed By: david-y-lam

Differential Revision: D16730577

fbshipit-source-id: ddd195894a1d55f4b031c80716da06d856977821
    @philippv @facebook-github-bot
    philippv authored and facebook-github-bot committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    3681e5f View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Adopt Contributor Covenant 

    Summary:
In order to foster healthy open source communities, we're adopting the
[Contributor Covenant](https://www.contributor-covenant.org/). It has been
built by open source community members and represents a shared understanding of
what is expected from a healthy community.

Reviewed By: josephsavona, danobi, rdzhabarov

Differential Revision: D17104640

fbshipit-source-id: d210000de686c5f0d97d602b50472d5869bc6a49
    @zpao @facebook-github-bot
    zpao authored and facebook-github-bot committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    22ef0bd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. FileInfoGenerator for sending files in batches 

    Summary:
Today sender computes the list of files to be send at the
begining of the transfer, transfers all of the files and
finishes. When we are transferring, for example, a large DB
we might have ended up with new files while the transfer is
in progress, which requires some application side changes to
start another transfer and send these changes. This diff tries
to simplify this by providing the Sender an ability to check
for more files before completing the transfer.

Differential Revision: D17215618

fbshipit-source-id: 3cad04f92bba00efa0510b132c78c3f0989e32ba
    @sarangbh @facebook-github-bot
    sarangbh authored and facebook-github-bot committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    1557fce View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2019

  1. Bump minor version 

    Differential Revision: D18092796

fbshipit-source-id: 3bf7e719c3317ef2a05e925eb323f0e43757d143
    @sls-fb @facebook-github-bot
    sls-fb authored and facebook-github-bot committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    0184e65 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2019

  1. Bugfix: Ensure waitForPreviousTransfer exits during error 

    Summary:
The condition use previously in waitForPreviousTransfer was incorrect
and could block the thread indefinitely if some of the sender threads
exited due to errors. This diff fixes the behavior and also adds progress
reporting for better visibility.

Differential Revision: D18921721

fbshipit-source-id: 7e21c7f9b958470ab87c51cecb4e9cd5ae2bcaee
    @sarangbh @facebook-github-bot
    sarangbh authored and facebook-github-bot committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    8a0273c View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Remove folly's ColdClass, which was of dubious utility 

    Summary: `folly::cold_detail::ColdClass` was marking things (like `folly::Unexpected`) cold, but at the cost of inhibiting the inliner from doing its job. This is leading to bad codegen, which offsets any small wins we mind get for the `cold` attribute.

Reviewed By: yfeldblum

Differential Revision: D19324159

fbshipit-source-id: 7ed431b6c9d6e963c3bf438c707fa6cf6a38bf9d
    @facebook-github-bot
    Eric Niebler authored and facebook-github-bot committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    0dea09e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. Add optional fadvise call following sync_file_range 

    Summary:
We experimented with enabling DirectIO within FileWriter but the logic
became a bit too complex. The primary goal was to reduce page cache pollution
from files being downloaded if they are not needed immediately.

An alternative approach is to fadvise the cached blocks away periodically
following syncs. Here we add a fadvise call with FAD_DONTNEED immediately
following the call to `sync_file_range` to inform the kernel that the
corresponding pages may be dropped immediately. This call is conditioned on a
new flag added to WdtOptions.

Reviewed By: gwicke

Differential Revision: D19606983

fbshipit-source-id: 2d12639d8c523edd679161990d8c91ea8d212d18
    @facebook-github-bot
    Amlan Nayak authored and facebook-github-bot committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    70523e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2020

  1. Need to return a boolean instead of an enum in SyncFileRange 

    Summary:
Stupid bug. Should return `false` in case of `fadvise` error. Replacing
the error code enum with boolean.

Differential Revision: D19730619

fbshipit-source-id: dfe6b2dc4e5be0b6d157e232a5f26cf530d602d6
    @facebook-github-bot
    Amlan Nayak authored and facebook-github-bot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    1e247c2 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Verifing identity in P2P downloads 

    Summary:
1. add a new init method for WDT, where users can pass in a whitelist of identities when initializing WDT service
2. plug in a logic in WDT server so that it verifies the caller's identity, and only callers with allowed identity ("laser_db_leaf") can get permission to download data from peer

Differential Revision: D21887094

fbshipit-source-id: c78f4f045985421b80485ac681c70e9fedfe337e
    @facebook-github-bot
    Sijia Wang authored and facebook-github-bot committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    5a5a597 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2020

  1. remediation of S205607 

    fbshipit-source-id: 5113fe0c527595e4227ff827253b7414abbdf7ac
    @StanislavGlebik @facebook-github-bot
    StanislavGlebik authored and facebook-github-bot committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    9b89eee View commit details
    Browse the repository at this point in the history

  2. remediation of S205607 

    fbshipit-source-id: 798decc90db4f13770e97cdce3c0df7d5421b2a3
    @StanislavGlebik @facebook-github-bot
    StanislavGlebik authored and facebook-github-bot committed Jul 18, 2020
    Configuration menu
    Copy the full SHA
    b3ac9ba View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. changing transfer progress to VLOG 

    Summary: It's dominating the logs.

Differential Revision: D23063896

fbshipit-source-id: d8ffbee1a18edf69db8a8afcc993c6e58aecbfe0
    @facebook-github-bot
    Trey Lu authored and facebook-github-bot committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    51dd649 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Add O_CLOEXEC flag when opening files during index download 

    Summary: Context: https://fb.workplace.com/groups/lasereng/permalink/3555830174428424/

Reviewed By: lujcmss

Differential Revision: D23488492

fbshipit-source-id: 89cf8887245019094123ff973d62e3cf60520cda
    @facebook-github-bot
    Ran Bi authored and facebook-github-bot committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    35d2c31 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Back out "changing transfer progress to VLOG" 

    Summary:
addressing feedback from https://www.internalfb.com/intern/diff/D23063896 (https://github.com/facebook/wdt/commit/51dd64982051475571acc7874d556f54f2b36173)/?transaction_id=1211402319222670

Original commit changeset: d8ffbee1a18e

Differential Revision: D23605056

fbshipit-source-id: b8b5703e616819833fb38de9aebaeffa6c030b3b
    @facebook-github-bot
    Trey Lu authored and facebook-github-bot committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    b585d21 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2020

  1. Update README.md (#207) 

    Summary:
Fixed typo functionality

Pull Request resolved: #207

Differential Revision: D24874427

Pulled By: davide125

fbshipit-source-id: 17fbdfbdd3e506629fab7a5b7ece8db590afdaef
    @saravananselvamohan @facebook-github-bot
    saravananselvamohan authored and facebook-github-bot committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    716fa17 View commit details
    Browse the repository at this point in the history

  2. Fix some of the tests running on docker (#190) 

    Summary:
env:`USER` is not available in docker so use the python inbuilt getpass to try all available methods to get username.

Pull Request resolved: #190

Reviewed By: claudiozz

Differential Revision: D24872834

Pulled By: davide125

fbshipit-source-id: be1a308ffa47e041009c6eca2268d15ba8001d7e
    @hjmallon @facebook-github-bot
    hjmallon authored and facebook-github-bot committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    123dab2 View commit details
    Browse the repository at this point in the history

  3. Add missing include for std::find (#210) 

    Summary:
Without this, the compilation fails with :
wdt/test/EncryptionTest.cpp:76:57: error: no matching function for call to 'find(std::vector<std::__cxx11::basic_string<char> >::iterator, std::vector<std::__cxx11::basic_string<char> >::iterator, std::string&)'

Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>

Pull Request resolved: #210

Reviewed By: claudiozz

Differential Revision: D24869824

Pulled By: davide125

fbshipit-source-id: 78777f76f0bee7f3fd9d0d6362d7673b9f7c0f13
    @kwizart @facebook-github-bot
    kwizart authored and facebook-github-bot committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    0b1e48a View commit details
    Browse the repository at this point in the history

  4. Fix gtest build on Xcode (#188) 

    Summary:
This is the method to integrate Gtest described in their docs here https://github.com/google/googletest/blob/master/googletest/README.md.

Before integrating this I could not build on Xcode or Makefiles on macOS.

Pull Request resolved: #188

Reviewed By: claudiozz

Differential Revision: D24890600

Pulled By: davide125

fbshipit-source-id: ae3f8d6eee5cfe4190e1b6b424bb4b8098f74c38
    @hjmallon @facebook-github-bot
    hjmallon authored and facebook-github-bot committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    8bfcd3f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Add support for gflags <2.2.0 (#191) 

    Summary:
GFlags 2.1.1 is what is available without rebuilding on CentOS 7. This patch to the CMake makes sure we can always build with gflags < 2.2.0.

Pull Request resolved: #191

Reviewed By: michel-slm

Differential Revision: D24900188

Pulled By: davide125

fbshipit-source-id: cb1fbf604473192b8ae446ff9686811b79c1b813
    @hjmallon @facebook-github-bot
    hjmallon authored and facebook-github-bot committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    cfb0790 View commit details
    Browse the repository at this point in the history

  2. Remove CMake warnings (#195) 

    Summary: Pull Request resolved: #195

Reviewed By: filbranden

Differential Revision: D24907319

Pulled By: davide125

fbshipit-source-id: e590df2cea6f71166a90fa71a99e5555e30e9dad
    @hjmallon @facebook-github-bot
    hjmallon authored and facebook-github-bot committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    0da7235 View commit details
    Browse the repository at this point in the history

  3. Fixes compilation with latest version of folly (#201) 

    Summary: Pull Request resolved: #201

Reviewed By: filbranden

Differential Revision: D24924059

Pulled By: davide125

fbshipit-source-id: 50acaa1a34f4bc8d25a9eff432706af14931220e
    @fran6co @facebook-github-bot
    fran6co authored and facebook-github-bot committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    b4a1541 View commit details
    Browse the repository at this point in the history

  4. Add CMake option WDT_USE_SYSTEM_FOLLY to disable folly4wdt (#197) 

    Summary:
This is a proposed fix for #194

Pull Request resolved: #197

Reviewed By: filbranden

Differential Revision: D24929345

Pulled By: davide125

fbshipit-source-id: 280fa841cbfff1ddde846b3116adbeb08d3bcd40
    @hjmallon @facebook-github-bot
    hjmallon authored and facebook-github-bot committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    90a1212 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. WIP: Fix Travis-CI builds (#193) 

    Summary:
These changes fix Travis-CI builds on macOS and partially on Linux.

The only thing left to do on Linux is #192

This pull request also requires #188

Pull Request resolved: #193

Reviewed By: claudiozz

Differential Revision: D24933398

Pulled By: davide125

fbshipit-source-id: eb96db30a3cb71695111a7d41ca2c27fbe891d87
    @hjmallon @facebook-github-bot
    hjmallon authored and facebook-github-bot committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    3573f1c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. wdt: fix gtest integration 

    Summary: Use a system gtest if one is available

Reviewed By: filbranden

Differential Revision: D25059075

fbshipit-source-id: 46ebfb1298529bbf3ada22e31f2ce19413c38852
    @davide125 @facebook-github-bot
    davide125 authored and facebook-github-bot committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    27e6611 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Cut FOLLY_HAVE_MEMRCHR 

    Summary: [Folly] Cut `FOLLY_HAVE_MEMRCHR` since it is now unused.

Reviewed By: Orvid

Differential Revision: D22130149

fbshipit-source-id: b10c5a52354f5c549d96b54e0c165f08b96612b1
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    f352c6f View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. wdt: port tests to python3 

    Summary: Update and fix Python tests

Reviewed By: michel-slm

Differential Revision: D26033500

fbshipit-source-id: 757e5c44b0d8c467127fcb60340f4312b14a7a4a
    @davide125 @facebook-github-bot
    davide125 authored and facebook-github-bot committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    f63e46c View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. wdt: add version to soname 

    Summary: To identify ABI breaks and make this easier to package

Reviewed By: michel-slm

Differential Revision: D26127827

fbshipit-source-id: 2b611ef7282e0c94399b5f72dcc23663667ee4e6
    @davide125 @facebook-github-bot
    davide125 authored and facebook-github-bot committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    6aec23c View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Remove dead includes in wdt/test 

    Reviewed By: igorsugak

Differential Revision: D27006737

fbshipit-source-id: b6278159eff56a4d8657ce505b616a1812addb86
    @facebook-github-bot
    generatedunixname89002005287564 authored and facebook-github-bot committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    97a8c0a View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. remove folly::SpinLockGuard 

    Summary:
C++17 permits use of `std::unique_lock` instead of `folly::SpinLockGuard`; just use that.

C++11 permits use of `std::unique_lock<SpinLock>`.

Differential Revision: D27390136

fbshipit-source-id: bcc34a043644289523ddfdfbf47a260c133db186
    @yfeldblum @facebook-github-bot
    yfeldblum authored and facebook-github-bot committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    fdbc543 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. use the C++17 standard for public builds 

    Summary:
Per D27390136 (fdbc543) / fdbc543, WDT requires
C++17 to build (for the refactor replacing `folly::SpinLockGuard` with
`std::unique_lock`).

Bump the language standard declared in `CMakeLists.txt` so public builds
can succeed.

Reviewed By: davide125

Differential Revision: D27867115

fbshipit-source-id: 38e9237d31b3750647279e9a5e227249923406f5
    @michel-slm @facebook-github-bot
    michel-slm authored and facebook-github-bot committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    0f100c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. remove patent grant 

    Summary:
Facebook no longer recommends using patent grants for open source projects;
bring this project in alignment.

Brought up during the Fedora review back in March:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/2AVHXQD3 (https://github.com/facebook/wdt/commit/a38ef09636bfc4ea4e49d0f38ee8f3e17edc4841)C2JBSZQT7E6HK3HHQ4O5KBDV/

Reviewed By: davide125

Differential Revision: D29374358

fbshipit-source-id: 39552b102286a558ed68e2684a8e3616d062defa
    @michel-slm @facebook-github-bot
    michel-slm authored and facebook-github-bot committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b98479c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Fix TSAN issue due to std::chrono non atomic access 

    Summary: Fix TSAN issue due to std::chrono non atomic access

Reviewed By: danobi

Differential Revision: D29903190

fbshipit-source-id: 31c574741542cc6303d01b42a74ef5d30ebc7e04
    @dmm-fb @facebook-github-bot
    dmm-fb authored and facebook-github-bot committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    7c44f79 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Remove dead includes in wdt/util 

    Reviewed By: biran0079

Differential Revision: D30011604

fbshipit-source-id: 7d3f52cde6cbf9abc27b8b4954df990bbd7a58e0
    @facebook-github-bot
    Dead Code Bot authored and facebook-github-bot committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    57bbd43 View commit details
    Browse the repository at this point in the history