-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
closes #108 Created CHANGELOG.md with the last five changes #330
Conversation
This is my first PR in my life |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, @jchoi136, on your first PR!🚀
Well done @jchoi136!! If I may, the PR fixes an issue but we'll have the same problem in few commits/releases unless this becomes an automated process. @mnicpt what do you think about https://github.com/atlassian/changesets or https://github.com/conventional-changelog/standard-version? |
ping @bluepnume any thoughts on @apuntovanini 's comments? I feel like commit automation may not be as human readable as user written updates, especially when sometimes commits usually parts of an overall feature and only the overall feature is important enough to be written. |
I worry without some kind of automation, we'll end up falling behind with manually keeping a change-log up to date. Plus, we have "squash and merge" set as default on all of these repos; so any PRs should ideally cover an entire, atomic change that should fit neatly into a change-log. We do need to be good at enforcing good commit/pr messages, though. |
Actually @changesets/cli (for instance) is automated in the sense that enforces a standard for publishing changesets with proper commits, and automatically builds changelogs. I find it very useful, but, yes, it's strongly related to how contributing / merging and releasing is structured. You can see some examples in https://atlassian.design/components/banner/code (click on changelog on the right) |
a6dbeec
to
f8eeb3e
Compare
22cbfdf
to
c890107
Compare
Created a changelog using the format from keep a changelog