Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/redux into feature/apollo #1881

Closed
wants to merge 107 commits into from
Closed

Merge feature/redux into feature/apollo #1881

wants to merge 107 commits into from

Conversation

patsa
Copy link

@patsa patsa commented Mar 24, 2020

No description provided.

mmarkelov and others added 30 commits April 1, 2018 12:03
 * chore: Update packages 
 * fix: "Deprecation warning for String based operators" sequelize/sequelize#8417
It was added in 79e5575 to work around an npm issue,
but we instead use yarn as of 78868e6.
It looks like we stopped using it in 1ed83b6 (#1237).
* chore: upgrade packages

* chore: make babel and jest working after upgrade
* Updated from Mocha to Jest

Still need to update React-intl

* modified tests to jest instead of mocha and chai

* left react-intl example the same due to yarn eval
* Upgrade all dependencies including Babel 7

1. ncu --upgradeAll
4. Leave "graphql" to be "^13.2.0" that apollo packages depend on
2. Apply patch of "npx babel-upgrade" output
3. Leave only necessary babel plugins
4. Pass "yarn fix" by disabling stricter rules

fixes #1654 #1626 #1607

* Also ignore babel config file from webpack.config.js
* Update sqlite3
* Add Ci builds against the latest active LTS (10)
* Fix styles error in Home.css

* Fix deprecation warnings
* fix: change node from 6.5 to 6.9

* fix: change node 6.5 -> 6.9 on getting-started
Bumps [sequelize](https://github.com/sequelize/sequelize) from 4.38.1 to 5.15.1.
- [Release notes](https://github.com/sequelize/sequelize/releases)
- [Commits](sequelize/sequelize@v4.38.1...v5.15.1)

Signed-off-by: dependabot[bot] <support@github.com>
* yarn add react@latest react-dom@latest

* yarn add isomorphic-style-loader@latest

* git cherry-pick 812d8ac

With respect I used @mglace 's react-starter-kit folk

* change deps versions (adopted higher ones)
* include minimum change of react-style-guide.md

Fixes #1715

* fix: update react-test-renderer too
Bumps [merge](https://github.com/yeikos/js.merge) from 1.2.0 to 1.2.1.
- [Release notes](https://github.com/yeikos/js.merge/releases)
- [Commits](swordev/merge@v1.2.0...v1.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [url-parse](https://github.com/unshiftio/url-parse) from 1.4.1 to 1.4.7.
- [Release notes](https://github.com/unshiftio/url-parse/releases)
- [Commits](unshiftio/url-parse@1.4.1...1.4.7)

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.4.0...4.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
```
find . -path ./node_modules -prune -o -name '*.md' | xargs yarn prettier --write
```
dependabot-preview bot and others added 26 commits November 14, 2019 20:06
Bumps [query-string](https://github.com/sindresorhus/query-string) from 6.8.3 to 6.9.0.
- [Release notes](https://github.com/sindresorhus/query-string/releases)
- [Commits](sindresorhus/query-string@v6.8.3...v6.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [express-graphql](https://github.com/graphql/express-graphql) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/graphql/express-graphql/releases)
- [Commits](graphql/express-graphql@v0.8.0...v0.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* mod: Use execa

* mod: Connect IO to the front process by default

* Test "yarn start"

* "starts GraphiQL" should fail. Should downgrade express-graphql to 0.8.9.

* Downgrade express-graphql for quick fix for #1822
From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded
…1836)

Bumps [@babel/plugin-transform-react-inline-elements](https://github.com/babel/babel) from 7.2.0 to 7.7.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.2.0...v7.7.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@babel/plugin-proposal-class-properties](https://github.com/babel/babel) from 7.7.0 to 7.7.4.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](babel/babel@v7.7.0...v7.7.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
According to the read me it should go:

yarn run test-watch             # Run unit tests in watch mode
…#1866)

Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) from 2.1.0 to 2.1.1. **This update includes a security fix.**
- [Release notes](https://github.com/yahoo/serialize-javascript/releases)
- [Commits](yahoo/serialize-javascript@v2.1.0...v2.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Update node base image to 8.16.2

Update node alpine image to fix the engine "node" incompatible error.

* Set permissions for "node" user

Fix SequelizeConnectionError: SQLITE_CANTOPEN: unable to open database file
@piglovesyou
Copy link
Collaborator

@patsa Thank you for doing this. I have a question, at least Home.js in the current feature/redux and yours look so different. It seems you changed it to what you'd like (and there could be other commits to effect). Please point me out if it's wrong.

I think here we should always follow the upstream implementation (feature/redux, this time) and get rid of arbitrary changes as much as possible. What do you think?

@ulani
Copy link
Member

ulani commented May 27, 2021

@patsa thank you very much for this PR! Unfortunately, we have close it due to inactivity. Feel free to re-open it or join our Discord channel for discussion.

NOTE: The main branch has been updated with React Starter Kit v2, using JAM-style architecture.

@ulani ulani closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.