Add check for array parameter to Q.all() #667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…must take an array, we need to make sure that it isnt passed the arguments object directly
| @@ -1502,6 +1506,10 @@ Promise.prototype.keys = function () { | |||
| Q.all = all; | |||
| function all(promises) { | |||
| return when(promises, function (promises) { | |||
| if (!isArray(arguments[0]) || arguments.length !== 1) { | |||
| throw Error("All must be passed an array of promises."); | |||
There was a problem hiding this comment.
Would you mind replacing All with all() to make the error message more clear?
There was a problem hiding this comment.
TypeError is appropriate here.
|
@domenic 👍 |
… array_slice from promised()
| @@ -1502,6 +1502,10 @@ Promise.prototype.keys = function () { | |||
| Q.all = all; | |||
| function all(promises) { | |||
| return when(promises, function (promises) { | |||
| if (typeof arguments[0].length === "undefined") { | |||
There was a problem hiding this comment.
Why this as opposed to Array.isArray(promises)?
There was a problem hiding this comment.
With Array.isArray, if all() gets passed the arguments object it would be rejected.
|
What about iterables? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #656.
This pull request adds a check to the Q.all() function to make sure it is being passed an array or array-like object.