-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for array parameter to Q.all() #667
Open
vingiarrusso
wants to merge
7
commits into
kriskowal:v1
Choose a base branch
from
vingiarrusso:v1
base: v1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b323ee5
adds error check to make sure parameter to all is an array
vingiarrusso 3b80013
arguments is an array-like object, not an actual array. now that all…
vingiarrusso 2d9e1fc
update test spec
vingiarrusso 1250591
update to use array_slice
vingiarrusso 1429af8
add isArray helper function, update all to use it
vingiarrusso b800fa0
update test to work as intended
vingiarrusso 3a3a367
check for length property on arguments, remove isArray method, remove…
vingiarrusso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1096,6 +1096,20 @@ describe("propagation", function () { | |
}); | ||
|
||
describe("all", function () { | ||
it("rejects if not passed an array", function() { | ||
var promise = Q.defer(), | ||
willBeRejected = Q.all(promise); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also check the case with many arguments to |
||
|
||
return willBeRejected.then( | ||
function () { | ||
expect(true).toBe(false); | ||
}, | ||
function (err) { | ||
expect(err.constructor).toBe(TypeError); | ||
} | ||
); | ||
}); | ||
|
||
it("fulfills when passed an empty array", function () { | ||
return Q.all([]); | ||
}); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this as opposed to
Array.isArray(promises)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Array.isArray, if all() gets passed the arguments object it would be rejected.