Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require user login before oAuth2 request authorization #6

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ajgarlag
Copy link
Contributor

See: thephpleague/oauth2-server-bundle#196

After this, the league/oauth2-server-bundle can be upgraded to version 0.9 without any issue.

@krkabol
Copy link
Owner

krkabol commented Oct 15, 2024

Great, I can confirm it!
the issue seems more like a misunderstanding. In my case because I used older examples, in the documentation https://github.com/thephpleague/oauth2-server-bundle/blob/master/docs/index.md it is probably also not ideally stated:

line 26 - users of Flex do not need to follow the next steps - but they have to set { path: ^/authorize, roles: IS_AUTHENTICATED_REMEMEMBERED }

line 142 - "It is recommended" - but for the application to run it is actually "required" ?


what is next - do I have to keep this repository, or I can delete it to clean my desk?

thank you very much
Petr

@krkabol krkabol merged commit 3f4a60a into krkabol:main Oct 15, 2024
@ajgarlag
Copy link
Contributor Author

Thanks for the reproducer.

I've just opened a PR to fix documentation issues.

IMO this repository can be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants