Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require a logged in user to resolve an authorization request #196

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

ajgarlag
Copy link
Contributor

@ajgarlag ajgarlag commented Aug 16, 2024

Introduces BC breaks

Fix #195

@ajgarlag ajgarlag changed the title Require a logged in user to resolve an authoration request Require a logged in user to resolve an authorization request Aug 16, 2024
@ajgarlag
Copy link
Contributor Author

@chalasr Can your review this? Thanks!

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Let's merge for now and reconsider in case the BC break appears to be too annoying.

@chalasr
Copy link
Member

chalasr commented Aug 26, 2024

Thank you @ajgarlag.

@chalasr chalasr merged commit 44272ff into thephpleague:master Aug 26, 2024
20 checks passed
@ajgarlag
Copy link
Contributor Author

@ajgarlag ref #200 :) im wondering if the runtimeexception is reasonable

I was unsure too. Do you think a logicexception is more reasonable here?

@ro0NL
Copy link

ro0NL commented Oct 15, 2024

@ajgarlag figured the config is required

i was more thinking about throwing UnauthorizedHttpException to avoid the 500 response

but then the issue may not be noticed in logs 🤔

@ajgarlag
Copy link
Contributor Author

IMO the UnauthorizedHttpException is not a good option.

Since 0.9.0 a logged-in user is required to authorize the request, so the error must be explicit and force the modification of the security config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require an UserInterface instance before resolving an AuthorizationRequest
3 participants