Executing JSONTestSuite parsing tests cases #24
Closed
joeslice wants to merge 4 commits intokson-org:mainfrom
Closed
Executing JSONTestSuite parsing tests cases #24joeslice wants to merge 4 commits intokson-org:mainfrom
joeslice wants to merge 4 commits intokson-org:mainfrom
Conversation
Using an ascii dash `-` instead of endash (\u2013) allows for more obvious manipulation/grepping later.
Allowing parser to retutn a nullable `KsonRoot` ensures that unparseable data is not used to create a partial AST.
Importing tests from [nst/JSONTestSuite](https://github.com/nst/JSONTestSuite) to understand whether KSON is JSON-compatible. See details in readme for more information Note: Initial sync is revision d64aefb.
Using [nst/JSONTestSuite](https://github.com/nst/JSONTestSuite) provided test cases, this framework allows reporting of whether we are compying with the edge cases defined in the upstream project. Note that many of the test cases are "skipped", and follow on enablement of these tests is part of #21, #22, and #23.
Contributor
Author
|
Notable TODOs at the time of initial PR:
|
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing and executing tests from nst/JSONTestSuite
to understand whether KSON is JSON-compatible. See details in readme for
more information.
Note: Initial sync is revision d64aefb.
In combination with issues #21, #22, and #23, closes #19.