Merged
Conversation
The experiment started in 17cbf03 of keeping these in git went fairly well, with just a bit of churn, but we're about to introduce an embedded intellij project in `buildSrc/`, and dual maintaining this seems like too much. So back to basics: no committed IDE configs (our `build.gradle.kts` files should be responsible for fully determining the project structure and settings anyway)
Prepare for some planned advanced build features by setting up a [Gradle `buildSrc/`](https://stackoverflow.com/questions/13874680/what-is-the-purpose-of-gradles-buildsrc-folder/13875350#13875350) project for our build
The native compilation and tests in particular were running out of memory in some cases using the defaults.
Generate a cross-platform set of JSON-validation tests based on the [JSONTestSuite](https://github.com/nst/JSONTestSuite) project to help validate Kson's goal of being a JSON-superset. Also incorporate the generator into our build using custom gradle task `GenerateJsonTestSuiteTask` so that this is seamless for developers and CI.
Replace the static placeholder test name with the appropriate test name in the comment links on the `JsonSuiteTest` tests
Generate the `JsonSuiteTest` tests alphabetically since it's an easy bit of organization to automate in the generation, and it makes the large file more easily browsable
We had the tests depending on this generation, but that's actually a bit too late: it needs to run before test compile. Note that I was not able to figure how to configure the Kotlin MPP compile task types, so we simply ensure `generateJsonTestSuiteTask` runs before _every_ task (this is fine since it caches well and is almost always up-to-date)
Organize our not-yet-supported tests into [JsonTestSuiteSkipList], getting our build green on the supported tests and staking out the work needed to achieve full JSON-compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate a cross-platform set of JSON-validation tests based on the JSONTestSuite project to help validate Kson's goal of being a JSON-superset.
Also incorporate the generator into our build using custom gradle task
GenerateJsonTestSuiteTaskso that this is seamless for developers and CI.