Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-6158 JS. Remove redundant require calls #4422

Merged
merged 6 commits into from
Oct 29, 2024
Merged

KTOR-6158 JS. Remove redundant require calls #4422

merged 6 commits into from
Oct 29, 2024

Conversation

turansky
Copy link
Contributor

@turansky turansky commented Oct 22, 2024 •
edited
Loading

Subsystem
Client, JS

Motivation
https://youtrack.jetbrains.com/issue/KTOR-6158

Solution
Remove redundant require calls

Related PRs

e5l
e5l approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace class with interface to avoid breaking changes

@turansky turansky force-pushed the js-remove-redundant-polyfills branch from 7712bb7 to 7e2ac48 Compare October 24, 2024 07:07
@turansky
Copy link
Contributor Author

please replace class with interface to avoid breaking changes

Done

@turansky turansky requested a review from e5l October 24, 2024 07:09
@whyoleg
Copy link
Contributor

whyoleg commented Oct 24, 2024

Probably the same changes could be applied for wasmJs target

@Vampire
Copy link

Vampire commented Oct 24, 2024

Can we also get rid of the remaining two require calls? (for ws and crypto)
I guess the same problems will be hit with those if their code paths are hit?

@turansky
Copy link
Contributor Author

turansky commented Oct 24, 2024 •
edited
Loading

Can we also get rid of the remaining two require calls? (for ws and crypto)

2 additional separate PR-s (1 for ws and 1 for crypto) - preferable option

@e5l e5l merged commit e5e8ae7 into ktorio:main Oct 29, 2024
9 of 12 checks passed
@turansky
Copy link
Contributor Author

@osipxd Thank you for assistance :)

@turansky turansky deleted the js-remove-redundant-polyfills branch October 29, 2024 10:58
This was referenced Oct 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l Awaiting requested review from e5l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@turansky @whyoleg @Vampire @e5l @osipxd