Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-6158 JS. Remove redundant require call for crypto #4434

Merged
merged 2 commits into from
Oct 30, 2024
Merged

KTOR-6158 JS. Remove redundant require call for crypto #4434

merged 2 commits into from
Oct 30, 2024

Conversation

turansky
Copy link
Contributor

@turansky turansky commented Oct 29, 2024 •
edited
Loading

Subsystem
Client, JS

Motivation
https://youtrack.jetbrains.com/issue/KTOR-6158

Solution

  • Use common global crypto
    • Available since Node 15. Current LTS - Node 22 ;)

Related PRs

@turansky turansky mentioned this pull request Oct 29, 2024
Merged
osipxd
osipxd requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@osipxd osipxd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request!
Tests are failing with "TypeError: get__crypto(...).randomFillSync is not a function". Could you check it, please?

@turansky turansky requested a review from osipxd October 29, 2024 16:55
osipxd
osipxd approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osipxd osipxd merged commit 8c9fc74 into ktorio:main Oct 30, 2024
10 of 13 checks passed
@turansky turansky mentioned this pull request Nov 1, 2024
Merged
marychatte pushed a commit that referenced this pull request Nov 5, 2024
@turansky @marychatte
KTOR-6158 JS. Remove redundant require call for crypto (#4434)
ecf2731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osipxd osipxd osipxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turansky @osipxd