Allow setting a description on a derived CRD #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
force-pushed
the
derived-crd-description
branch
from
82d0f8f to
6d3a482
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1359 +/- ##
=======================================
- Coverage 72.1% 72.1% -0.0%
=======================================
Files 75 75
Lines 6434 6436 +2
=======================================
Hits 4635 4635
- Misses 1799 1801 +2
|
clux
reviewed
Nov 30, 2023
Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
sbernauer
force-pushed
the
derived-crd-description
branch
from
7754d4a to
a32e7cc
Compare
|
How about |
|
Works for me. If @clux agrees I can raise a PR to fix it |
|
Ah. 🤦 yeah that also sounds better to me. |
sbernauer
added a commit
to sbernauer/kube
that referenced
this pull request
Dec 1, 2023
Follow-up of kube-rs#1359 Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
clux
pushed a commit
that referenced
this pull request
Dec 1, 2023
Follow-up of #1359 Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on a website which shows our CRDs we noticed the sentence
Auto-generated derived type for TrinoClusterSpec via CustomResourceshowing up prominently. We therefore would like to have it configurable.Solution
Add support for a new
kube(description = "xxx")attribute on the struct that is used to generate the CRD.Fixup
Renamed to
kube(doc = "xxx")in #1363 before release.