Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kube-derive attribute from description to doc #1363

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

sbernauer
Copy link
Contributor

@sbernauer sbernauer commented Dec 1, 2023

Fixup of #1359, which was merged just minutes ago (so no user depends on the naming yet)
Changes kube(description = "xxx") to kube(doc = "xxx")

Follow-up of kube-rs#1359

Signed-off-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clux clux merged commit 3a4f724 into kube-rs:main Dec 1, 2023
16 checks passed
@clux clux added the changelog-exclude changelog excluded prs label Dec 2, 2023
@clux clux added this to the 0.88.0 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants