-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run e2e,integration tests against kubernetes versions and ssl stacks #924
Conversation
As part of Kubernetes version policies proposed in kube-rs/website#19 for #684 Signed-off-by: clux <sszynrae@gmail.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Now two e2e tests, and more feature combinations. Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Am fairly happy with the way this is now. It matches the policy in the upstream website PR, and we have better e2e tests to at least compile time guarantee we are not building on top of removed apis. Minor improvements here and there as outlined in edited main post. Feedback welcome. EDIT: i guess the flaky test is still flaky. Will look at that later, but ultimately it should be unrelated to the rest of this PR. |
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Not sure why this is stuck. By the way, I just enabled https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits at org level, which will prevent the DCO issue when committing suggested changes. |
It's not actually stuck. This PR has changed jobs + job names, so I need to change required statuses before merging (hence why the required ones are not reported).
Ah, that sounds great. Thanks! |
(won't build until that is merged) Signed-off-by: clux <sszynrae@gmail.com>
As part of Kubernetes version policies for #684.
Actual proposed policies are in kube-rs/website#19 and is mostly in line with our current advice.
This is larger overhaul for the CI situation for e2e tests to at least guarantee that the various Kubernetes versions work:
Main stuff done:
k3s complication: k3s is lagging behind k8s; pre-releases available 1w later, but 1mo later no stable 1.24.. => pinning only minimum supported and running against latest => can only really test against minimum and max available.
Verification strategy:
v1_19
(but without changing cluster version)e2e/boot.rs
against both latest k8s-openapi feature and our msrv (currentlyv1_19
feature)Thus the compile check avoids the error where we accidentally publish abstractions on apis that k8s-openapi have removed, and the integration tests run with a later k8s-openapi no matter what (because it's super hard to untangle that, and also not super necessary).