Add information on supported k8s versions and how to pick them #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factored out of #923 Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
that referenced
this pull request
May 31, 2022
Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
to kube-rs/kube
that referenced
this pull request
May 31, 2022
As part of Kubernetes version policies proposed in kube-rs/website#19 for #684 Signed-off-by: clux <sszynrae@gmail.com>
This was referenced May 31, 2022
Signed-off-by: clux <sszynrae@gmail.com>
|
Have factored this out of the general policy PR and cleaned it up a bit. It is kind of mergeable together with kube-rs/kube#924. But could use some thoughts on the points edited into the main PR. |
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
|
OK, have added a small bit about how we can remove special abstractions when the upstream source removes them to avoid being forced into a double support period for things like CRD/v1beta1. All in all, I am reasonably happy with this now. The policy, while a bit arbitrary is easy to implement, matches real world use cases (cloud providers), and it explains what to expect + our special cases. Will merge later tomorrow unless there are no comments on this. |
kazk
approved these changes
Jun 19, 2022
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Eirik A <sszynrae@gmail.com>
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Eirik A <sszynrae@gmail.com>
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Eirik A <sszynrae@gmail.com>
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Eirik A <sszynrae@gmail.com>
Co-authored-by: kazk <kazk.dev@gmail.com> Signed-off-by: Eirik A <sszynrae@gmail.com>
|
man, i am really bad with those capitalizations huh 😅 Thanks! |
clux
added a commit
to kube-rs/kube
that referenced
this pull request
Jun 19, 2022
* Run e2e tests against supported kubernetes versions As part of Kubernetes version policies proposed in kube-rs/website#19 for #684 Signed-off-by: clux <sszynrae@gmail.com> * add integration tests as specific job to run it against mk8sv Signed-off-by: clux <sszynrae@gmail.com> * rename tests and try to fix integration Signed-off-by: clux <sszynrae@gmail.com> * fix k3d args? Signed-off-by: clux <sszynrae@gmail.com> * fix e2e Signed-off-by: clux <sszynrae@gmail.com> * test against v1.19 Signed-off-by: clux <sszynrae@gmail.com> * badge update Signed-off-by: clux <sszynrae@gmail.com> * s/MINK8SV/MK8SV Signed-off-by: clux <sszynrae@gmail.com> * Big e2e rework (WIP) Now two e2e tests, and more feature combinations. Signed-off-by: clux <sszynrae@gmail.com> * avoid rustls local due to the issues Signed-off-by: clux <sszynrae@gmail.com> * split e2e tests into own file and clean up when to matrix Signed-off-by: clux <sszynrae@gmail.com> * running bump-k8s also bumps mk8sv Signed-off-by: clux <sszynrae@gmail.com> * avoid illegal anchors and add badge bumping Signed-off-by: clux <sszynrae@gmail.com> * better version checks for mk8sv and msrv on ci Signed-off-by: clux <sszynrae@gmail.com> * move some ci around for consistency in naming Signed-off-by: clux <sszynrae@gmail.com> * stray command Signed-off-by: clux <sszynrae@gmail.com> * fix syntax errors? Signed-off-by: clux <sszynrae@gmail.com> * fix test warning from kube-derive after apiext removal Signed-off-by: clux <sszynrae@gmail.com> * evars from tests Signed-off-by: clux <sszynrae@gmail.com> * better run description on integration jobs Signed-off-by: clux <sszynrae@gmail.com> * better output for flaky integration test Signed-off-by: clux <sszynrae@gmail.com> * fmt + give test more time? Signed-off-by: clux <sszynrae@gmail.com> * sanity after timeout. seems likely cause. Signed-off-by: clux <sszynrae@gmail.com> * no need for an agent in k3d cmd Signed-off-by: clux <sszynrae@gmail.com> * how slow is this actions cluster? Signed-off-by: clux <sszynrae@gmail.com> * re-trigger once more to check * apiserver, are you ok? Signed-off-by: clux <sszynrae@gmail.com> * another empty commit to retrigger Signed-off-by: clux <sszynrae@gmail.com> * remove duplicate changes from #924 (won't build until that is merged) Signed-off-by: clux <sszynrae@gmail.com>
clux
added a commit
that referenced
this pull request
Mar 5, 2023
Signed-off-by: clux <sszynrae@gmail.com> link to future stability policy discussion Signed-off-by: clux <sszynrae@gmail.com> create a kubernetes versioning matrix now since we can't use kubernetes versioning post 1.0, there's no point waiting. let's define and get clarity now. Signed-off-by: clux <sszynrae@gmail.com> potential solution for kubernetes version policy Propose a 5 version range from [MAX-4, MAX], since this matches kubernetes upstream support. This will need to go with better e2e tests. Signed-off-by: clux <sszynrae@gmail.com> remove kubernetes doc - moved into #19 Signed-off-by: clux <sszynrae@gmail.com> update with unstable features Signed-off-by: clux <sszynrae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes versioning docs (factored out of #18):
Done
Slightly iffy
v1_19, v1_24], but it was actually removed from structs inv1_22`)For the badge; we link to this policy document because it's unclear what a soft minimum means. MK8SV is always going to be a soft minimum, and what matters is how that range changes what you can expect. As a result, have also mentioned the stricter part about when we remove our own special abstractions (like CRD/v1beta1).
Unfortunately we cannot always test the maximum directly (k3s releases lagging as found in kube-rs/kube#924 ) but at least that PR does a good job of improving the situation.