Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bugs #255

Merged
merged 1 commit into from
Nov 16, 2022
Merged

fix: fix bugs #255

merged 1 commit into from
Nov 16, 2022

Conversation

moweiwei
Copy link
Collaborator

  1. container registry display
  2. enable reset cluster when status is Updating
  3. disable backup for rancher cluster

Signed-off-by: moweiwei mo.weiwei@99cloud.net

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:


Does this PR introduced a user-facing change?


Additional documentation, usage docs, etc.:


@kubeclipper-bot
Copy link
Collaborator

@moweiwei: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2022
1. container registry display
2. enable reset cluster when status is Updating
3. disable backup for rancher cluster

Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
@moweiwei
Copy link
Collaborator Author

/cherrypick release-1.3

@kubeclipper-bot
Copy link
Collaborator

@moweiwei: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lysign
Copy link
Collaborator

lysign commented Nov 16, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@kubeclipper-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysign, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: ecc28153fa051160b4ee97f99c3aa2f55a47ce68

@kubeclipper-bot kubeclipper-bot merged commit 1d8128a into kubeclipper:master Nov 16, 2022
@kubeclipper-bot
Copy link
Collaborator

@moweiwei: new pull request created: #256

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

moweiwei added a commit to moweiwei/console that referenced this pull request Jan 5, 2023
1. container registry display
2. enable reset cluster when status is Updating
3. disable backup for rancher cluster

Signed-off-by: moweiwei <mo.weiwei@99cloud.net>

Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants