Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.3] fix: fix bugs #256

Merged
merged 1 commit into from
Nov 16, 2022
Merged

[release-1.3] fix: fix bugs #256

merged 1 commit into from
Nov 16, 2022

Conversation

kubeclipper-bot
Copy link
Collaborator

This is an automated cherry-pick of #255

@moweiwei
fix: fix bugs
0b70eae 
1. container registry display
2. enable reset cluster when status is Updating
3. disable backup for rancher cluster

Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
@kubeclipper-bot kubeclipper-bot mentioned this pull request Nov 16, 2022
Merged
@kubeclipper-bot
Copy link
Collaborator Author

@kubeclipper-bot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2022
@lysign
Copy link
Collaborator

lysign commented Nov 16, 2022

/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2022
@kubeclipper-bot
Copy link
Collaborator Author

LGTM label has been added.

Git tree hash: ed99f5eeb7f4e5af6f9d89fa839a2376a5b930cb

@codecov-commenter
Copy link

Codecov Report

Merging #256 (0b70eae) into release-1.3 (6a9ce9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.3     #256   +/-   ##
============================================
  Coverage        46.20%   46.20%           
============================================
  Files                7        7           
  Lines              606      606           
  Branches           171      171           
============================================
  Hits               280      280           
  Misses             252      252           
  Partials            74       74

@moweiwei
Copy link
Collaborator

/approve

@kubeclipper-bot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kubeclipper-bot, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2022
@kubeclipper-bot kubeclipper-bot merged commit dc4e723 into kubeclipper:release-1.3 Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lysign lysign

@moweiwei moweiwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. release-notes-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubeclipper-bot @lysign @codecov-commenter @moweiwei