Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default-enable Multi Cluster Diagnostics #3397

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

thomasvn
Copy link
Member

@thomasvn thomasvn commented May 8, 2024

What does this PR change?

Default enables the Multi-Cluster Diagnostics primary. The primary is a dedicated goroutine which continually fetches new data from the bucket, aggregates the data, and handles queries.

For users who are leveraging .Values.federatedETL.agentOnly=true for their secondary clusters, we default DIAGNOSTICS_PRIMARY=false to ensure that those secondary agents are not making an unnecessary amount of API requests to the bucket. All other users still have the option to override this new default by setting .Values.diagnostics.primary.enabled=false.

Does this PR rely on any other PRs?

N/A

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Full Multi-cluster diagnostics features are now enabled by default.

Links to Issues or tickets this PR addresses or fixes

N/A

What risks are associated with merging this PR? What is required to fully test this PR?

As mentioned above. If we end up enabling DIAGNOSTICS_PRIMARY=true on all of the user's clusters, we may cause unnecessary overhead in requests to the S3 bucket. The user has the ability to override this change by setting .Values.diagnostics.primary.enabled=false on their secondaries.

How was this PR tested?

TODO

Have you made an update to documentation? If so, please provide the corresponding PR.

TODO

Copy link

github-actions bot commented Aug 7, 2024

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

@github-actions github-actions bot added the stale label Aug 7, 2024
@thomasvn thomasvn removed the stale label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant