Default-enable Multi Cluster Diagnostics #3397
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Default enables the Multi-Cluster Diagnostics primary. The primary is a dedicated goroutine which continually fetches new data from the bucket, aggregates the data, and handles queries.
For users who are leveraging
.Values.federatedETL.agentOnly=true
for their secondary clusters, we defaultDIAGNOSTICS_PRIMARY=false
to ensure that those secondary agents are not making an unnecessary amount of API requests to the bucket. All other users still have the option to override this new default by setting.Values.diagnostics.primary.enabled=false
.Does this PR rely on any other PRs?
N/A
How does this PR impact users? (This is the kind of thing that goes in release notes!)
Full Multi-cluster diagnostics features are now enabled by default.
Links to Issues or tickets this PR addresses or fixes
N/A
What risks are associated with merging this PR? What is required to fully test this PR?
As mentioned above. If we end up enabling
DIAGNOSTICS_PRIMARY=true
on all of the user's clusters, we may cause unnecessary overhead in requests to the S3 bucket. The user has the ability to override this change by setting.Values.diagnostics.primary.enabled=false
on their secondaries.How was this PR tested?
TODO
Have you made an update to documentation? If so, please provide the corresponding PR.
TODO