Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default-enable Multi Cluster Diagnostics #3397

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Default-enable Multi Cluster Diagnostics #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14ac5c4
First draft at default-enabling diagnostics primary.
thomasvn May 8, 2024
33b4488
Merge branch 'develop' into thomasn/mcd-primary-default-enabled
thomasvn Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cost-analyzer/templates/cost-analyzer-deployment-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,8 +1134,14 @@ spec:
value: "localhost"
- name: DIAGNOSTICS_KUBECOST_NAMESPACE
value: {{ .Release.Namespace }}
{{- /* When Kubecost is run on a secondary cluster as an agent the Diagnostics service should never be the primary */}}
{{- if .Values.federatedETL.agentOnly }}
- name: DIAGNOSTICS_PRIMARY
value: "false"
{{- else }}
- name: DIAGNOSTICS_PRIMARY
value: {{ quote .Values.diagnostics.primary.enabled }}
{{- end }}
- name: DIAGNOSTICS_RETENTION
value: {{ .Values.diagnostics.primary.retention }}
- name: DIAGNOSTICS_PRIMARY_READONLY
Expand Down
6 changes: 6 additions & 0 deletions cost-analyzer/templates/diagnostics-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,14 @@ spec:
value: {{ template "cost-analyzer.serviceName" . }}
- name: DIAGNOSTICS_KUBECOST_NAMESPACE
value: {{ .Release.Namespace }}
{{- /* When Kubecost is run on a secondary cluster as an agent the Diagnostics service should never be the primary */}}
{{- if .Values.federatedETL.agentOnly }}
- name: DIAGNOSTICS_PRIMARY
value: "false"
{{- else }}
- name: DIAGNOSTICS_PRIMARY
value: {{ quote .Values.diagnostics.primary.enabled }}
{{- end }}
- name: DIAGNOSTICS_RETENTION
value: {{ .Values.diagnostics.primary.retention }}
- name: DIAGNOSTICS_PRIMARY_READONLY
Expand Down
2 changes: 1 addition & 1 deletion cost-analyzer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2710,7 +2710,7 @@ diagnostics:
## retention. When in readonly mode it does not push its own diagnostic data
## to the bucket.
primary:
enabled: false
enabled: true
retention: "7d"
readonly: false

Expand Down