Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize comments #3699

Closed
wants to merge 7 commits into from
Closed

Standardize comments #3699

wants to merge 7 commits into from

Conversation

thomasvn
Copy link
Member

@thomasvn thomasvn commented Oct 4, 2024

What does this PR change?

Standardizes how comments are styled. Makes comments more concise.

Does this PR rely on any other PRs?

N/A

How does this PR impact users? (This is the kind of thing that goes in release notes!)

N/A

Links to Issues or tickets this PR addresses or fixes

N/A

What risks are associated with merging this PR? What is required to fully test this PR?

N/A

How was this PR tested?

N/A

Have you made an update to documentation? If so, please provide the corresponding PR.

N/A

Copy link

gitguardian bot commented Oct 28, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7414 Triggered Google API Key 08b5eaf cost-analyzer/templates/kubecost-metrics-deployment-template.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

github-actions bot commented Feb 7, 2025

This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 7, 2025
Copy link

This pull request was closed because it has been inactive for 95 days with no activity.

@github-actions github-actions bot closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant