Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize comments #3699

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Standardize comments #3699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
869a4c1
Begin standardizing comments
thomasvn Oct 4, 2024
27091fd
More standardized comments.
thomasvn Oct 4, 2024
aaec629
More comments
thomasvn Oct 4, 2024
08b5eaf
Merge branch 'develop' into thomasn/standardize-comments
thomasvn Oct 28, 2024
612edee
Merge branch 'develop' into thomasn/standardize-comments
thomasvn Oct 30, 2024
f1911e2
Progress on standardizing comments.
thomasvn Oct 31, 2024
9ace81c
Merge branch 'develop' into thomasn/standardize-comments
thomasvn Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cost-analyzer/templates/cost-analyzer-deployment-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,17 +847,17 @@ spec:
{{- end }}
{{- if .Values.kubecostMetrics }}
- name: EMIT_POD_ANNOTATIONS_METRIC
value: {{ (quote .Values.kubecostMetrics.emitPodAnnotations) | default (quote false) }}
value: {{ (quote .Values.kubecostMetrics.emitPodAnnotations) }}
- name: EMIT_NAMESPACE_ANNOTATIONS_METRIC
value: {{ (quote .Values.kubecostMetrics.emitNamespaceAnnotations) | default (quote false) }}
value: {{ (quote .Values.kubecostMetrics.emitNamespaceAnnotations) }}
{{- end }}
{{- if .Values.kubecostMetrics }}
- name: EMIT_KSM_V1_METRICS
value: {{ (quote .Values.kubecostMetrics.emitKsmV1Metrics) | default (quote true) }}
value: {{ (quote .Values.kubecostMetrics.emitKsmV1Metrics) }}
{{- end }}
{{- if .Values.kubecostMetrics }}
- name: EMIT_KSM_V1_METRICS_ONLY # ONLY emit KSM v1 metrics that do not exist in KSM 2 by default
value: {{ (quote .Values.kubecostMetrics.emitKsmV1MetricsOnly) | default (quote false) }}
value: {{ (quote .Values.kubecostMetrics.emitKsmV1MetricsOnly) }}
{{- end }}
{{- if .Values.reporting }}
- name: LOG_COLLECTION_ENABLED
Expand Down
Loading
Loading