Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Put Docker image for the GitHub triage action in the kubeflow docker hub registry #66

Open
jlewi opened this issue Nov 26, 2019 · 6 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Nov 26, 2019

The GitHub action for Kubeflow triage is currently using the image
hamelsmu/kubeflow-triage

docker build -t hamelsmu/kubeflow-triage -f Issue_Triage/Dockerfile .

image: 'docker://hamelsmu/kubeflow-triage'

We should instead push the image to Docker in the kubeflow organization and then update the image to use that.

Note GitHub actions doesn't currently support GCR.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.83. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented Nov 26, 2019

We have the kubeflow github organization
https://hub.docker.com/orgs/kubeflow

We have the kubeflowrobot account for automating pushes to kubeflow

I created a personal access token for this account. This is currently stored in google's internal secret management system; Google team can access it.

I replaced the DOCKER_USERNAME and DOCKER_PASSWORD secrets on kubeflow/code-intelligence with kubeflowrobot and the associated access token.

jlewi pushed a commit to jlewi/Issue-Label-Bot that referenced this issue Nov 26, 2019
…ue_triage.

* Instead of storing the image in a personal account we should use the kubeflow
  organization.
* Related to kubeflow/code-intelligence#66
k8s-ci-robot pushed a commit that referenced this issue Nov 26, 2019
…ue_triage (#67)

* Use the Kubeflow DockerHub organization for the GitHub action for issue_triage.

* Instead of storing the image in a personal account we should use the kubeflow
  organization.
* Related to #66

* Update the readme.

* Update the issue_triage workflow to use the master version of the action.

* Provide more explanation in the README including instructions for how to deploy.
@jlewi
Copy link
Contributor Author

jlewi commented Nov 26, 2019

When the action triggered we got a permission error trying to push to DockerHub
https://github.com/kubeflow/code-intelligence/commit/ea1e5995d7e9bc8e6326c1adf9c5149af2294ced/checks?check_suite_id=329459221

@jlewi
Copy link
Contributor Author

jlewi commented Nov 26, 2019

I'm going to try reproducing it locally; by logging in as the kubeflow robot to docker and building the image.

I got the same error.

@jlewi
Copy link
Contributor Author

jlewi commented Nov 26, 2019

It looks like I had to do a couple things

  1. In Docker hub I had to create the repository kubeflow/kubeflow-triage
  2. I had to add the developer team with read/write permissions on that repository

I was then able to successfully run docker push using the kubeflowrobot account

@jlewi
Copy link
Contributor Author

jlewi commented Nov 26, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant