Use the Kubeflow DockerHub organization for the GitHub action for issue_triage #67
Conversation
…ue_triage. * Instead of storing the image in a personal account we should use the kubeflow organization. * Related to kubeflow/code-intelligence#66
|
/assign @hamelsmu |
|
@jlewi you also need to change .github/workflows/triage_issues.yaml Don't forget to refer to While you are at it can you add a more verbose explanation to |
Issue_Triage/action/README.md
Outdated
| 1. Create a workflow like the one above in your repository in the directory | ||
|
|
||
| ``` | ||
| .github/workflows/ |
There was a problem hiding this comment.
| .github/workflows/ | |
| .github/workflows/<your_file_name>.yaml |
|
Nevermind looks like that is trying to run on stale workflow ...hmm but this PR should be triggering a build with each push you do |
|
Ohhhhh ! !!!! I know why b/c you are opening this PR from a Fork. Yeah you cannot trigger a build from a Fork because your Fork doesn't have access to secrets and you cannot get access to secrets just by opening a PR |
|
@jlewi what do you think about my suggested changes above? If you like them please commit and we can merge |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Done |
This seems like its working as intended. I would only expect the builds of the docker image to be triggered on postsubmit not presubmit. If we trigger on presubmit then people running the action might use unmerged code which seems problematic. |
…ion. * Provide more explanation in the README including instructions for how to deploy.
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@hamelsmu I think I addressed all your comments. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamelsmu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead of storing the image in a personal account we should use the kubeflow
organization.
Update the issue_triage.yaml workflow in this repository to use the master version of the action
Related to Put Docker image for the GitHub triage action in the kubeflow docker hub registry #66
Related to Provide instructions on the PR workflow based on OWNERS files. community#27 - GitHub action for adding issues to triage
This change is