Provide instructions on the PR workflow based on OWNERS files. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Instructions describe how we will use prow bots and OWNERs files to manage the PR workload. * Instructions are based on the Kubernetes workflow https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#code-review-using-owners-files
|
@DjangoPeng @gaocegege @erikerlandson @ddysher Does someone want to review this? |
ScorpioCPH
approved these changes
Mar 7, 2018
contributing.md
Outdated
| - [plugin: lgtm](https://git.k8s.io/test-infra/prow/plugins/lgtm) | ||
| - adds the `lgtm` label when a **reviewer** comments `/lgtm` on a PR | ||
| - the **PR author** may not `/lgtm` their own PR | ||
| - [pkg: k8s.io/test-infra/prow/repowners](https://git.k8s.io/test-infra/prow/repoowners/repoowners.go) |
gaocegege
approved these changes
Mar 7, 2018
|
@ScorpioCPH Changes from the K8s doc are trivially. Main difference is "kubernetes" -> "kubeflow" and I deleted the section about mungeithub. Don't forget to "/lgtm" |
|
/lgtm |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege, jlewi, ScorpioCPH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @k8s-ci-robot 😄 |
jlewi
pushed a commit
to jlewi/kubeflow
that referenced
this pull request
Nov 26, 2019
k8s-ci-robot
pushed a commit
to kubeflow/kubeflow
that referenced
this pull request
Nov 26, 2019
woop
pushed a commit
to woop/community
that referenced
this pull request
Nov 16, 2020
…flow#27) * Dynamic layout for TOC on documents. * whitespace cleanup
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions describe how we will use prow bots and OWNERs files
to manage the PR workload.
Instructions are based on the Kubernetes workflow
https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#code-review-using-owners-files
Fix #3
This change is