Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Add utility methods for job reconciliation #24

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Add utility methods for job reconciliation #24

merged 3 commits into from
Apr 26, 2019

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Apr 23, 2019

This PR adds utility methods for job reconciliation (part of #7). Note that part of the code is commented out for now until service reconciliation logic is in place.


This change is Reviewable

@terrytangyuan
Copy link
Member Author

@richardsliu Coverage/coveralls calculation does not seem correct (it says job_controller folder's coverage decreased but I see no file under this directory seems to have decreased coverage). Would we still be able to merge this PR (once approved) while coveralls check failed?

job_controller/job_test.go Outdated Show resolved Hide resolved
job_controller/job_test.go Outdated Show resolved Hide resolved
@terrytangyuan
Copy link
Member Author

Thanks @richardsliu. Just updated so they are more readable now.

@gaocegege
Copy link
Member

gaocegege commented Apr 24, 2019

LGTM Is there anyone working on service reconciliation logic?

@terrytangyuan
Copy link
Member Author

@gaocegege Yes someone from our team is putting together a PR (should be out soon).

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsliu richardsliu merged commit 48fede2 into kubeflow:master Apr 26, 2019
@terrytangyuan terrytangyuan deleted the job-reconciliation branch April 26, 2019 20:14
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants