This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Enable Travis CI on kubeflow/common #6

Merged

k8s-ci-robot merged 8 commits into kubeflow:master from richardsliu:travis

Apr 5, 2019

Contributor

richardsliu commented Apr 4, 2019 •

edited by jlewi

Loading

This change is


          Add travis config

2d9e578

k8s-ci-robot requested review from gaocegege and johnugeorge

April 4, 2019 18:15

k8s-ci-robot added the size/M label

TravisBuddy commented Apr 4, 2019

Hey @richardsliu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy Request Identifier: 00d59b50-5706-11e9-979a-6d93f48c24a0

TravisBuddy commented Apr 4, 2019

Hey @richardsliu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

TravisBuddy Request Identifier: 7e867780-5707-11e9-979a-6d93f48c24a0


          Use golangci-lint

4f39264

TravisBuddy commented Apr 4, 2019

Travis tests have failed

Hey @richardsliu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0daa7610-570c-11e9-979a-6d93f48c24a0

terrytangyuan reviewed

View reviewed changes

Member

terrytangyuan left a comment

Should we disable TravisBuddy as it’s quite verbose?

richardsliu added 2 commits

April 4, 2019 13:52


          Merge remote-tracking branch 'upstream/master' into travis

2a5c931


          set GO111MODUlE on

3bbae40

richardsliu changed the title ~~Add travis config to kubeflow/common~~ WIP Add travis config to kubeflow/common

k8s-ci-robot added the do-not-merge/work-in-progress label

TravisBuddy commented Apr 4, 2019

Travis tests have failed

Hey @richardsliu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ada57d10-571e-11e9-979a-6d93f48c24a0


          update go.sum

240e98a

k8s-ci-robot added size/L and removed size/M labels

TravisBuddy commented Apr 4, 2019

Travis tests have failed

Hey @richardsliu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d55e23b0-571f-11e9-979a-6d93f48c24a0

TravisBuddy commented Apr 4, 2019

Travis tests have failed

Hey @richardsliu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6dea9190-5720-11e9-979a-6d93f48c24a0

richardsliu added 2 commits

April 4, 2019 14:30


          Fix travis

f3792cb


          Fix goveralls

4cc529c

TravisBuddy commented Apr 4, 2019

Travis tests have failed

Hey @richardsliu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 24b22f80-5723-11e9-979a-6d93f48c24a0

TravisBuddy commented Apr 4, 2019

Travis tests have failed

Hey @richardsliu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7e9c6a50-5724-11e9-979a-6d93f48c24a0

richardsliu changed the title ~~WIP Add travis config to kubeflow/common~~ Enable Travis CI on kubeflow/common

k8s-ci-robot removed the do-not-merge/work-in-progress label

Contributor Author

richardsliu commented Apr 4, 2019

/assign @johnugeorge
/assign @terrytangyuan

k8s-ci-robot assigned johnugeorge and terrytangyuan

Member

terrytangyuan commented Apr 4, 2019

Is TravisBuddy necessary? The comments seem pretty verbose.
/lgtm

k8s-ci-robot added the lgtm label


          Disable travis buddy

0efbd54

k8s-ci-robot removed the lgtm label

Contributor Author

richardsliu commented Apr 5, 2019

Removed TravisBuddy.

gaocegege reviewed

View reviewed changes

Member

gaocegege left a comment

/lgtm

k8s-ci-robot assigned gaocegege

k8s-ci-robot added the lgtm label

Member

johnugeorge commented Apr 5, 2019

/approve

k8s-ci-robot commented Apr 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the approved label

k8s-ci-robot merged commit dbfd0cc into kubeflow:master

georgkaleido pushed a commit to georgkaleido/common that referenced this pull request


          Refactored server code (kubeflow#6)

8a94e8f

* Refactored removebg server

* Use is_server_initializing, _submit_result

* Use _handle_command

* Comment line length

* Return when cmd is handled

* Let unknown exceptions bubble up, are handled in core lib

* Handle None when server is stopped

* Correct error descriptions

* Use encode_image from core-lib

* Corrected passed data

* Loosen requirements torch, torchvision

* Refactored removebg server

* Use is_server_initializing, _submit_result

* Use _handle_command

* Comment line length

* Return when cmd is handled

* Let unknown exceptions bubble up, are handled in core lib

* Handle None when server is stopped

* Correct error descriptions

* Corrected passed data

* Update repo link setup.cfg, Change quote type to double in editorconfig to be compatible with black, Update Dockerfile base image and set removebg-core to patch version v1.3.1.dev1 for review

* Update requirements.in

* Remove pip and setuptools from requirements.txt as considered unsafe by pip-compile, Update requirements

* Set removebg-core to 1.3.1.dev.1 to allow testing

* Update requirements

Co-authored-by: Paul Angerer <dabauxi@users.noreply.github.com>
Co-authored-by: Alexander Graf <alex@basecamp.tirol>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

georgkaleido pushed a commit to georgkaleido/common that referenced this pull request


          Revert "Refactored server code (kubeflow#6)" (kubeflow#24)

5fb73f0

This reverts commit 8a94e8f.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved lgtm size/L